• johpow01's avatar
    Fix casting bug in gicv2_main.c · 20d38497
    johpow01 authored
    
    
    In the function gicv2_set_spi_routing, the signed value proc_num is cast
    to unsigned int before being compared to other unsigned values in two
    assert calls.  The value proc_num can be a negative value, and once the
    negative value is cast to unsigned it becomes a very large number which
    will trigger the assert.  This patch changes the assert cast so that the
    unsigned values are cast to signed instead, keeping the same functionality
    but allowing proc_num to be negative.
    
    This bug can be seen when running the SDEI RM_ANY routing mode test in
    TFTF on the Juno platform.
    
    This patch also makes the usage of the proc_num variable in other gicv2
    functions more clear.
    Signed-off-by: default avatarJohn Powell <john.powell@arm.com>
    Change-Id: If1b98eebb00bd9b73862e5e995e5e68c168170a6
    20d38497
gicv2_main.c 19.1 KB