Commit 04589e2b authored by Yidi Lin's avatar Yidi Lin
Browse files

mediatek: mt8192: Fix non-MISRA compliant code



CID 364144: Integer handling issues (NO_EFFECT)

The unsigned value is always greater-than-or-equal-to-zero.
Remove such check.

Change-Id: Ia395eb32f55a7098d2581ce7f548b7e1112beaa0
Signed-off-by: default avatarYidi Lin <yidi.lin@mediatek.com>
parent 42f2fa82
...@@ -39,15 +39,15 @@ void ptp3_init(unsigned int core) ...@@ -39,15 +39,15 @@ void ptp3_init(unsigned int core)
{ {
unsigned int _core; unsigned int _core;
if (core >= PTP3_CFG1_CPU_START_ID) { /* Apply ptp3_cfg1 for core 0 to 7 */
if (core < NR_PTP3_CFG1_CPU) { if (core < NR_PTP3_CFG1_CPU) {
/* update ptp3_cfg1 */ /* update ptp3_cfg1 */
ptp3_write( ptp3_write(
ptp3_cfg1[core][PTP3_CFG_ADDR], ptp3_cfg1[core][PTP3_CFG_ADDR],
ptp3_cfg1[core][PTP3_CFG_VALUE]); ptp3_cfg1[core][PTP3_CFG_VALUE]);
} }
}
/* Apply ptp3_cfg2 for core 4 to 7 */
if (core >= PTP3_CFG2_CPU_START_ID) { if (core >= PTP3_CFG2_CPU_START_ID) {
_core = core - PTP3_CFG2_CPU_START_ID; _core = core - PTP3_CFG2_CPU_START_ID;
...@@ -59,6 +59,7 @@ void ptp3_init(unsigned int core) ...@@ -59,6 +59,7 @@ void ptp3_init(unsigned int core)
} }
} }
/* Apply ptp3_cfg3 for core 4 to 7 */
if (core >= PTP3_CFG3_CPU_START_ID) { if (core >= PTP3_CFG3_CPU_START_ID) {
_core = core - PTP3_CFG3_CPU_START_ID; _core = core - PTP3_CFG3_CPU_START_ID;
...@@ -73,7 +74,6 @@ void ptp3_init(unsigned int core) ...@@ -73,7 +74,6 @@ void ptp3_init(unsigned int core)
void ptp3_deinit(unsigned int core) void ptp3_deinit(unsigned int core)
{ {
if (core >= PTP3_CFG1_CPU_START_ID) {
if (core < NR_PTP3_CFG1_CPU) { if (core < NR_PTP3_CFG1_CPU) {
/* update ptp3_cfg1 */ /* update ptp3_cfg1 */
ptp3_write( ptp3_write(
...@@ -81,5 +81,4 @@ void ptp3_deinit(unsigned int core) ...@@ -81,5 +81,4 @@ void ptp3_deinit(unsigned int core)
ptp3_cfg1[core][PTP3_CFG_VALUE] & ptp3_cfg1[core][PTP3_CFG_VALUE] &
~PTP3_CFG1_MASK); ~PTP3_CFG1_MASK);
} }
}
} }
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment