Commit 30affd56 authored by Harry Liebel's avatar Harry Liebel Committed by Dan Handley
Browse files

Do not enable CCI on Foundation FVP

- The Foundation FVP only has one cluster and does not have
  CCI.

Change-Id: If91e81ff72c52e448150089c4cfea3e4d6ae1232
parent 43ef4f1e
...@@ -225,15 +225,6 @@ platform_cold_boot_init:; .type platform_cold_boot_init, %function ...@@ -225,15 +225,6 @@ platform_cold_boot_init:; .type platform_cold_boot_init, %function
bl dcivac bl dcivac
str x19, [x1, x2] str x19, [x1, x2]
/* ---------------------------------------------
* Enable CCI-400 for this cluster. No need
* for locks as no other cpu is active at the
* moment
* ---------------------------------------------
*/
mov x0, x19
bl cci_enable_coherency
/* --------------------------------------------- /* ---------------------------------------------
* Architectural init. can be generic e.g. * Architectural init. can be generic e.g.
* enabling stack alignment and platform spec- * enabling stack alignment and platform spec-
......
...@@ -576,6 +576,7 @@ int platform_config_setup(void) ...@@ -576,6 +576,7 @@ int platform_config_setup(void)
platform_config[CONFIG_MAX_AFF1] = 1; platform_config[CONFIG_MAX_AFF1] = 1;
platform_config[CONFIG_CPU_SETUP] = 0; platform_config[CONFIG_CPU_SETUP] = 0;
platform_config[CONFIG_BASE_MMAP] = 0; platform_config[CONFIG_BASE_MMAP] = 0;
platform_config[CONFIG_HAS_CCI] = 0;
break; break;
case HBI_FVP_BASE: case HBI_FVP_BASE:
midr_pn = (read_midr() >> MIDR_PN_SHIFT) & MIDR_PN_MASK; midr_pn = (read_midr() >> MIDR_PN_SHIFT) & MIDR_PN_MASK;
...@@ -587,6 +588,7 @@ int platform_config_setup(void) ...@@ -587,6 +588,7 @@ int platform_config_setup(void)
platform_config[CONFIG_MAX_AFF0] = 4; platform_config[CONFIG_MAX_AFF0] = 4;
platform_config[CONFIG_MAX_AFF1] = 2; platform_config[CONFIG_MAX_AFF1] = 2;
platform_config[CONFIG_BASE_MMAP] = 1; platform_config[CONFIG_BASE_MMAP] = 1;
platform_config[CONFIG_HAS_CCI] = 1;
break; break;
default: default:
assert(0); assert(0);
......
...@@ -34,6 +34,7 @@ ...@@ -34,6 +34,7 @@
#include <platform.h> #include <platform.h>
#include <bl1.h> #include <bl1.h>
#include <console.h> #include <console.h>
#include <cci400.h>
/******************************************************************************* /*******************************************************************************
* Declarations of linker defined symbols which will help us find the layout * Declarations of linker defined symbols which will help us find the layout
...@@ -126,6 +127,9 @@ void bl1_early_platform_setup(void) ...@@ -126,6 +127,9 @@ void bl1_early_platform_setup(void)
bl1_tzram_layout.free_size = bl1_tzram_layout.free_size =
tzram_limit - bl1_coherent_ram_limit; tzram_limit - bl1_coherent_ram_limit;
} }
/* Initialize the platform config for future decision making */
platform_config_setup();
} }
/******************************************************************************* /*******************************************************************************
...@@ -153,11 +157,23 @@ void bl1_platform_setup(void) ...@@ -153,11 +157,23 @@ void bl1_platform_setup(void)
/******************************************************************************* /*******************************************************************************
* Perform the very early platform specific architecture setup here. At the * Perform the very early platform specific architecture setup here. At the
* moment this is only intializes the mmu in a quick and dirty way. Later arch- * moment this only does basic initialization. Later architectural setup
* itectural setup (bl1_arch_setup()) does not do anything platform specific. * (bl1_arch_setup()) does not do anything platform specific.
******************************************************************************/ ******************************************************************************/
void bl1_plat_arch_setup(void) void bl1_plat_arch_setup(void)
{ {
unsigned long cci_setup;
/*
* Enable CCI-400 for this cluster. No need
* for locks as no other cpu is active at the
* moment
*/
cci_setup = platform_get_cfgvar(CONFIG_HAS_CCI);
if (cci_setup) {
cci_enable_coherency(read_mpidr());
}
configure_mmu(&bl1_tzram_layout, configure_mmu(&bl1_tzram_layout,
TZROM_BASE, /* Read_only region start */ TZROM_BASE, /* Read_only region start */
TZROM_BASE + TZROM_SIZE, /* Read_only region size */ TZROM_BASE + TZROM_SIZE, /* Read_only region size */
......
...@@ -111,7 +111,7 @@ int fvp_affinst_off(unsigned long mpidr, ...@@ -111,7 +111,7 @@ int fvp_affinst_off(unsigned long mpidr,
{ {
int rc = PSCI_E_SUCCESS; int rc = PSCI_E_SUCCESS;
unsigned int gicc_base, ectlr; unsigned int gicc_base, ectlr;
unsigned long cpu_setup; unsigned long cpu_setup, cci_setup;
switch (afflvl) { switch (afflvl) {
case MPIDR_AFFLVL1: case MPIDR_AFFLVL1:
...@@ -120,7 +120,10 @@ int fvp_affinst_off(unsigned long mpidr, ...@@ -120,7 +120,10 @@ int fvp_affinst_off(unsigned long mpidr,
* Disable coherency if this cluster is to be * Disable coherency if this cluster is to be
* turned off * turned off
*/ */
cci_setup = platform_get_cfgvar(CONFIG_HAS_CCI);
if (cci_setup) {
cci_disable_coherency(mpidr); cci_disable_coherency(mpidr);
}
/* /*
* Program the power controller to turn the * Program the power controller to turn the
...@@ -187,7 +190,7 @@ int fvp_affinst_suspend(unsigned long mpidr, ...@@ -187,7 +190,7 @@ int fvp_affinst_suspend(unsigned long mpidr,
{ {
int rc = PSCI_E_SUCCESS; int rc = PSCI_E_SUCCESS;
unsigned int gicc_base, ectlr; unsigned int gicc_base, ectlr;
unsigned long cpu_setup, linear_id; unsigned long cpu_setup, cci_setup, linear_id;
mailbox *fvp_mboxes; mailbox *fvp_mboxes;
/* Cannot allow NS world to execute trusted firmware code */ /* Cannot allow NS world to execute trusted firmware code */
...@@ -203,7 +206,10 @@ int fvp_affinst_suspend(unsigned long mpidr, ...@@ -203,7 +206,10 @@ int fvp_affinst_suspend(unsigned long mpidr,
* Disable coherency if this cluster is to be * Disable coherency if this cluster is to be
* turned off * turned off
*/ */
cci_setup = platform_get_cfgvar(CONFIG_HAS_CCI);
if (cci_setup) {
cci_disable_coherency(mpidr); cci_disable_coherency(mpidr);
}
/* /*
* Program the power controller to turn the * Program the power controller to turn the
...@@ -270,7 +276,7 @@ int fvp_affinst_on_finish(unsigned long mpidr, ...@@ -270,7 +276,7 @@ int fvp_affinst_on_finish(unsigned long mpidr,
unsigned int state) unsigned int state)
{ {
int rc = PSCI_E_SUCCESS; int rc = PSCI_E_SUCCESS;
unsigned long linear_id, cpu_setup; unsigned long linear_id, cpu_setup, cci_setup;
mailbox *fvp_mboxes; mailbox *fvp_mboxes;
unsigned int gicd_base, gicc_base, reg_val, ectlr; unsigned int gicd_base, gicc_base, reg_val, ectlr;
...@@ -278,8 +284,12 @@ int fvp_affinst_on_finish(unsigned long mpidr, ...@@ -278,8 +284,12 @@ int fvp_affinst_on_finish(unsigned long mpidr,
case MPIDR_AFFLVL1: case MPIDR_AFFLVL1:
/* Enable coherency if this cluster was off */ /* Enable coherency if this cluster was off */
if (state == PSCI_STATE_OFF) if (state == PSCI_STATE_OFF) {
cci_setup = platform_get_cfgvar(CONFIG_HAS_CCI);
if (cci_setup) {
cci_enable_coherency(mpidr); cci_enable_coherency(mpidr);
}
}
break; break;
case MPIDR_AFFLVL0: case MPIDR_AFFLVL0:
......
...@@ -72,7 +72,9 @@ ...@@ -72,7 +72,9 @@
/* Indicate whether the CPUECTLR SMP bit should be enabled. */ /* Indicate whether the CPUECTLR SMP bit should be enabled. */
#define CONFIG_CPU_SETUP 6 #define CONFIG_CPU_SETUP 6
#define CONFIG_BASE_MMAP 7 #define CONFIG_BASE_MMAP 7
#define CONFIG_LIMIT 8 /* Indicates whether CCI should be enabled on the platform. */
#define CONFIG_HAS_CCI 8
#define CONFIG_LIMIT 9
/******************************************************************************* /*******************************************************************************
* Platform memory map related constants * Platform memory map related constants
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment