Skip to content

GitLab

"vscode:/vscode.git/clone" did not exist on "3e16d6434778ee9e1d7d5369c53d1e9c6b0517cb"
Commit 60d23323 authored by Andrew F. Davis's avatar Andrew F. Davis
Browse files

ti: k3: drivers: ti_sci: Request and check for ACK by default 



Currently almost all TI-SCI messages request and check for an ACK from
the system firmware. Move this into a common place to remove the same
from each function.
Signed-off-by: default avatarAndrew F. Davis <afd@ti.com>
parent b3ca8aab
Show whitespace changes
Inline Side-by-side
plat/ti/k3/common/drivers/ti_sci/ti_sci.c
View file @ 60d23323
...@@ -95,7 +95,7 @@ static int ti_sci_setup_one_xfer(uint16_t msg_type, uint32_t msg_flags, ...@@ -95,7 +95,7 @@ static int ti_sci_setup_one_xfer(uint16_t msg_type, uint32_t msg_flags,
hdr->seq = info.seq; hdr->seq = info.seq;
hdr->type = msg_type; hdr->type = msg_type;
hdr->host = info.desc.host_id; hdr->host = info.desc.host_id;
hdr->flags = msg_flags; hdr->flags = msg_flags | TI_SCI_FLAG_REQ_ACK_ON_PROCESSED;
xfer->tx_message.buf = tx_buf; xfer->tx_message.buf = tx_buf;
xfer->tx_message.len = tx_message_size; xfer->tx_message.len = tx_message_size;
...@@ -143,6 +143,9 @@ static inline int ti_sci_get_response(struct ti_sci_xfer *xfer, ...@@ -143,6 +143,9 @@ static inline int ti_sci_get_response(struct ti_sci_xfer *xfer,
return -EINVAL; return -EINVAL;
} }
if (!(hdr->flags & TI_SCI_FLAG_RESP_GENERIC_ACK))
return -ENODEV;
return 0; return 0;
} }
...@@ -213,20 +216,6 @@ int ti_sci_get_revision(struct ti_sci_msg_resp_version *rev_info) ...@@ -213,20 +216,6 @@ int ti_sci_get_revision(struct ti_sci_msg_resp_version *rev_info)
return 0; return 0;
} }
/**
* ti_sci_is_response_ack() - Generic ACK/NACK message check
*
* @r: pointer to response buffer
*
* Return: true if the response was an ACK, else returns false
*/
static inline bool ti_sci_is_response_ack(void *r)
{
struct ti_sci_msg_hdr *hdr = r;
return hdr->flags & TI_SCI_FLAG_RESP_GENERIC_ACK ? true : false;
}
/** /**
* ti_sci_device_set_state() - Set device state * ti_sci_device_set_state() - Set device state
* *
...@@ -244,8 +233,7 @@ static int ti_sci_device_set_state(uint32_t id, uint32_t flags, uint8_t state) ...@@ -244,8 +233,7 @@ static int ti_sci_device_set_state(uint32_t id, uint32_t flags, uint8_t state)
struct ti_sci_xfer xfer; struct ti_sci_xfer xfer;
int ret; int ret;
ret = ti_sci_setup_one_xfer(TI_SCI_MSG_SET_DEVICE_STATE, ret = ti_sci_setup_one_xfer(TI_SCI_MSG_SET_DEVICE_STATE, flags,
flags | TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
&req, sizeof(req), &req, sizeof(req),
&resp, sizeof(resp), &resp, sizeof(resp),
&xfer); &xfer);
...@@ -263,9 +251,6 @@ static int ti_sci_device_set_state(uint32_t id, uint32_t flags, uint8_t state) ...@@ -263,9 +251,6 @@ static int ti_sci_device_set_state(uint32_t id, uint32_t flags, uint8_t state)
return ret; return ret;
} }
if (!ti_sci_is_response_ack(&resp))
return -ENODEV;
return 0; return 0;
} }
...@@ -310,9 +295,6 @@ static int ti_sci_device_get_state(uint32_t id, uint32_t *clcnt, ...@@ -310,9 +295,6 @@ static int ti_sci_device_get_state(uint32_t id, uint32_t *clcnt,
return ret; return ret;
} }
if (!ti_sci_is_response_ack(&resp))
return -ENODEV;
if (clcnt) if (clcnt)
*clcnt = resp.context_loss_count; *clcnt = resp.context_loss_count;
if (resets) if (resets)
...@@ -573,8 +555,7 @@ int ti_sci_device_set_resets(uint32_t id, uint32_t reset_state) ...@@ -573,8 +555,7 @@ int ti_sci_device_set_resets(uint32_t id, uint32_t reset_state)
struct ti_sci_xfer xfer; struct ti_sci_xfer xfer;
int ret; int ret;
ret = ti_sci_setup_one_xfer(TI_SCI_MSG_SET_DEVICE_RESETS, ret = ti_sci_setup_one_xfer(TI_SCI_MSG_SET_DEVICE_RESETS, 0,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
&req, sizeof(req), &req, sizeof(req),
&resp, sizeof(resp), &resp, sizeof(resp),
&xfer); &xfer);
...@@ -592,9 +573,6 @@ int ti_sci_device_set_resets(uint32_t id, uint32_t reset_state) ...@@ -592,9 +573,6 @@ int ti_sci_device_set_resets(uint32_t id, uint32_t reset_state)
return ret; return ret;
} }
if (!ti_sci_is_response_ack(&resp))
return -ENODEV;
return 0; return 0;
} }
...@@ -632,8 +610,7 @@ int ti_sci_clock_set_state(uint32_t dev_id, uint8_t clk_id, ...@@ -632,8 +610,7 @@ int ti_sci_clock_set_state(uint32_t dev_id, uint8_t clk_id,
struct ti_sci_xfer xfer; struct ti_sci_xfer xfer;
int ret; int ret;
ret = ti_sci_setup_one_xfer(TI_SCI_MSG_SET_CLOCK_STATE, ret = ti_sci_setup_one_xfer(TI_SCI_MSG_SET_CLOCK_STATE, flags,
flags | TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
&req, sizeof(req), &req, sizeof(req),
&resp, sizeof(resp), &resp, sizeof(resp),
&xfer); &xfer);
...@@ -652,9 +629,6 @@ int ti_sci_clock_set_state(uint32_t dev_id, uint8_t clk_id, ...@@ -652,9 +629,6 @@ int ti_sci_clock_set_state(uint32_t dev_id, uint8_t clk_id,
return ret; return ret;
} }
if (!ti_sci_is_response_ack(&resp))
return -ENODEV;
return 0; return 0;
} }
...@@ -683,8 +657,7 @@ int ti_sci_clock_get_state(uint32_t dev_id, uint8_t clk_id, ...@@ -683,8 +657,7 @@ int ti_sci_clock_get_state(uint32_t dev_id, uint8_t clk_id,
if (!programmed_state && !current_state) if (!programmed_state && !current_state)
return -EINVAL; return -EINVAL;
ret = ti_sci_setup_one_xfer(TI_SCI_MSG_GET_CLOCK_STATE, ret = ti_sci_setup_one_xfer(TI_SCI_MSG_GET_CLOCK_STATE, 0,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
&req, sizeof(req), &req, sizeof(req),
&resp, sizeof(resp), &resp, sizeof(resp),
&xfer); &xfer);
...@@ -702,9 +675,6 @@ int ti_sci_clock_get_state(uint32_t dev_id, uint8_t clk_id, ...@@ -702,9 +675,6 @@ int ti_sci_clock_get_state(uint32_t dev_id, uint8_t clk_id,
return ret; return ret;
} }
if (!ti_sci_is_response_ack(&resp))
return -ENODEV;
if (programmed_state) if (programmed_state)
*programmed_state = resp.programmed_state; *programmed_state = resp.programmed_state;
if (current_state) if (current_state)
...@@ -889,8 +859,7 @@ int ti_sci_clock_set_parent(uint32_t dev_id, uint8_t clk_id, uint8_t parent_id) ...@@ -889,8 +859,7 @@ int ti_sci_clock_set_parent(uint32_t dev_id, uint8_t clk_id, uint8_t parent_id)
struct ti_sci_xfer xfer; struct ti_sci_xfer xfer;
int ret; int ret;
ret = ti_sci_setup_one_xfer(TI_SCI_MSG_SET_CLOCK_PARENT, ret = ti_sci_setup_one_xfer(TI_SCI_MSG_SET_CLOCK_PARENT, 0,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
&req, sizeof(req), &req, sizeof(req),
&resp, sizeof(resp), &resp, sizeof(resp),
&xfer); &xfer);
...@@ -909,9 +878,6 @@ int ti_sci_clock_set_parent(uint32_t dev_id, uint8_t clk_id, uint8_t parent_id) ...@@ -909,9 +878,6 @@ int ti_sci_clock_set_parent(uint32_t dev_id, uint8_t clk_id, uint8_t parent_id)
return ret; return ret;
} }
if (!ti_sci_is_response_ack(&resp))
return -ENODEV;
return 0; return 0;
} }
...@@ -934,8 +900,7 @@ int ti_sci_clock_get_parent(uint32_t dev_id, uint8_t clk_id, uint8_t *parent_id) ...@@ -934,8 +900,7 @@ int ti_sci_clock_get_parent(uint32_t dev_id, uint8_t clk_id, uint8_t *parent_id)
struct ti_sci_xfer xfer; struct ti_sci_xfer xfer;
int ret; int ret;
ret = ti_sci_setup_one_xfer(TI_SCI_MSG_GET_CLOCK_PARENT, ret = ti_sci_setup_one_xfer(TI_SCI_MSG_GET_CLOCK_PARENT, 0,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
&req, sizeof(req), &req, sizeof(req),
&resp, sizeof(resp), &resp, sizeof(resp),
&xfer); &xfer);
...@@ -953,9 +918,6 @@ int ti_sci_clock_get_parent(uint32_t dev_id, uint8_t clk_id, uint8_t *parent_id) ...@@ -953,9 +918,6 @@ int ti_sci_clock_get_parent(uint32_t dev_id, uint8_t clk_id, uint8_t *parent_id)
return ret; return ret;
} }
if (!ti_sci_is_response_ack(&resp))
return -ENODEV;
*parent_id = resp.parent_id; *parent_id = resp.parent_id;
return 0; return 0;
...@@ -981,8 +943,7 @@ int ti_sci_clock_get_num_parents(uint32_t dev_id, uint8_t clk_id, ...@@ -981,8 +943,7 @@ int ti_sci_clock_get_num_parents(uint32_t dev_id, uint8_t clk_id,
struct ti_sci_xfer xfer; struct ti_sci_xfer xfer;
int ret; int ret;
ret = ti_sci_setup_one_xfer(TI_SCI_MSG_GET_NUM_CLOCK_PARENTS, ret = ti_sci_setup_one_xfer(TI_SCI_MSG_GET_NUM_CLOCK_PARENTS, 0,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
&req, sizeof(req), &req, sizeof(req),
&resp, sizeof(resp), &resp, sizeof(resp),
&xfer); &xfer);
...@@ -1000,9 +961,6 @@ int ti_sci_clock_get_num_parents(uint32_t dev_id, uint8_t clk_id, ...@@ -1000,9 +961,6 @@ int ti_sci_clock_get_num_parents(uint32_t dev_id, uint8_t clk_id,
return ret; return ret;
} }
if (!ti_sci_is_response_ack(&resp))
return -ENODEV;
*num_parents = resp.num_parents; *num_parents = resp.num_parents;
return 0; return 0;
...@@ -1037,8 +995,7 @@ int ti_sci_clock_get_match_freq(uint32_t dev_id, uint8_t clk_id, ...@@ -1037,8 +995,7 @@ int ti_sci_clock_get_match_freq(uint32_t dev_id, uint8_t clk_id,
struct ti_sci_xfer xfer; struct ti_sci_xfer xfer;
int ret; int ret;
ret = ti_sci_setup_one_xfer(TI_SCI_MSG_QUERY_CLOCK_FREQ, ret = ti_sci_setup_one_xfer(TI_SCI_MSG_QUERY_CLOCK_FREQ, 0,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
&req, sizeof(req), &req, sizeof(req),
&resp, sizeof(resp), &resp, sizeof(resp),
&xfer); &xfer);
...@@ -1059,9 +1016,6 @@ int ti_sci_clock_get_match_freq(uint32_t dev_id, uint8_t clk_id, ...@@ -1059,9 +1016,6 @@ int ti_sci_clock_get_match_freq(uint32_t dev_id, uint8_t clk_id,
return ret; return ret;
} }
if (!ti_sci_is_response_ack(&resp))
return -ENODEV;
*match_freq = resp.freq_hz; *match_freq = resp.freq_hz;
return 0; return 0;
...@@ -1094,8 +1048,7 @@ int ti_sci_clock_set_freq(uint32_t dev_id, uint8_t clk_id, uint64_t min_freq, ...@@ -1094,8 +1048,7 @@ int ti_sci_clock_set_freq(uint32_t dev_id, uint8_t clk_id, uint64_t min_freq,
struct ti_sci_xfer xfer; struct ti_sci_xfer xfer;
int ret; int ret;
ret = ti_sci_setup_one_xfer(TI_SCI_MSG_SET_CLOCK_FREQ, ret = ti_sci_setup_one_xfer(TI_SCI_MSG_SET_CLOCK_FREQ, 0,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
&req, sizeof(req), &req, sizeof(req),
&resp, sizeof(resp), &resp, sizeof(resp),
&xfer); &xfer);
...@@ -1115,9 +1068,6 @@ int ti_sci_clock_set_freq(uint32_t dev_id, uint8_t clk_id, uint64_t min_freq, ...@@ -1115,9 +1068,6 @@ int ti_sci_clock_set_freq(uint32_t dev_id, uint8_t clk_id, uint64_t min_freq,
return ret; return ret;
} }
if (!ti_sci_is_response_ack(&resp))
return -ENODEV;
return 0; return 0;
} }
...@@ -1140,8 +1090,7 @@ int ti_sci_clock_get_freq(uint32_t dev_id, uint8_t clk_id, uint64_t *freq) ...@@ -1140,8 +1090,7 @@ int ti_sci_clock_get_freq(uint32_t dev_id, uint8_t clk_id, uint64_t *freq)
struct ti_sci_xfer xfer; struct ti_sci_xfer xfer;
int ret; int ret;
ret = ti_sci_setup_one_xfer(TI_SCI_MSG_GET_CLOCK_FREQ, ret = ti_sci_setup_one_xfer(TI_SCI_MSG_GET_CLOCK_FREQ, 0,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
&req, sizeof(req), &req, sizeof(req),
&resp, sizeof(resp), &resp, sizeof(resp),
&xfer); &xfer);
...@@ -1159,9 +1108,6 @@ int ti_sci_clock_get_freq(uint32_t dev_id, uint8_t clk_id, uint64_t *freq) ...@@ -1159,9 +1108,6 @@ int ti_sci_clock_get_freq(uint32_t dev_id, uint8_t clk_id, uint64_t *freq)
return ret; return ret;
} }
if (!ti_sci_is_response_ack(&resp))
return -ENODEV;
*freq = resp.freq_hz; *freq = resp.freq_hz;
return 0; return 0;
...@@ -1180,8 +1126,7 @@ int ti_sci_core_reboot(void) ...@@ -1180,8 +1126,7 @@ int ti_sci_core_reboot(void)
struct ti_sci_xfer xfer; struct ti_sci_xfer xfer;
int ret; int ret;
ret = ti_sci_setup_one_xfer(TI_SCI_MSG_SYS_RESET, ret = ti_sci_setup_one_xfer(TI_SCI_MSG_SYS_RESET, 0,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
&req, sizeof(req), &req, sizeof(req),
&resp, sizeof(resp), &resp, sizeof(resp),
&xfer); &xfer);
...@@ -1196,9 +1141,6 @@ int ti_sci_core_reboot(void) ...@@ -1196,9 +1141,6 @@ int ti_sci_core_reboot(void)
return ret; return ret;
} }
if (!ti_sci_is_response_ack(&resp))
return -ENODEV;
return 0; return 0;
} }
...@@ -1217,8 +1159,7 @@ int ti_sci_proc_request(uint8_t proc_id) ...@@ -1217,8 +1159,7 @@ int ti_sci_proc_request(uint8_t proc_id)
struct ti_sci_xfer xfer; struct ti_sci_xfer xfer;
int ret; int ret;
ret = ti_sci_setup_one_xfer(TISCI_MSG_PROC_REQUEST, ret = ti_sci_setup_one_xfer(TISCI_MSG_PROC_REQUEST, 0,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
&req, sizeof(req), &req, sizeof(req),
&resp, sizeof(resp), &resp, sizeof(resp),
&xfer); &xfer);
...@@ -1235,9 +1176,6 @@ int ti_sci_proc_request(uint8_t proc_id) ...@@ -1235,9 +1176,6 @@ int ti_sci_proc_request(uint8_t proc_id)
return ret; return ret;
} }
if (!ti_sci_is_response_ack(&resp))
return -ENODEV;
return 0; return 0;
} }
...@@ -1256,8 +1194,7 @@ int ti_sci_proc_release(uint8_t proc_id) ...@@ -1256,8 +1194,7 @@ int ti_sci_proc_release(uint8_t proc_id)
struct ti_sci_xfer xfer; struct ti_sci_xfer xfer;
int ret; int ret;
ret = ti_sci_setup_one_xfer(TISCI_MSG_PROC_RELEASE, ret = ti_sci_setup_one_xfer(TISCI_MSG_PROC_RELEASE, 0,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
&req, sizeof(req), &req, sizeof(req),
&resp, sizeof(resp), &resp, sizeof(resp),
&xfer); &xfer);
...@@ -1274,9 +1211,6 @@ int ti_sci_proc_release(uint8_t proc_id) ...@@ -1274,9 +1211,6 @@ int ti_sci_proc_release(uint8_t proc_id)
return ret; return ret;
} }
if (!ti_sci_is_response_ack(&resp))
return -ENODEV;
return 0; return 0;
} }
...@@ -1297,8 +1231,7 @@ int ti_sci_proc_handover(uint8_t proc_id, uint8_t host_id) ...@@ -1297,8 +1231,7 @@ int ti_sci_proc_handover(uint8_t proc_id, uint8_t host_id)
struct ti_sci_xfer xfer; struct ti_sci_xfer xfer;
int ret; int ret;
ret = ti_sci_setup_one_xfer(TISCI_MSG_PROC_HANDOVER, ret = ti_sci_setup_one_xfer(TISCI_MSG_PROC_HANDOVER, 0,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
&req, sizeof(req), &req, sizeof(req),
&resp, sizeof(resp), &resp, sizeof(resp),
&xfer); &xfer);
...@@ -1316,9 +1249,6 @@ int ti_sci_proc_handover(uint8_t proc_id, uint8_t host_id) ...@@ -1316,9 +1249,6 @@ int ti_sci_proc_handover(uint8_t proc_id, uint8_t host_id)
return ret; return ret;
} }
if (!ti_sci_is_response_ack(&resp))
return -ENODEV;
return 0; return 0;
} }
...@@ -1341,8 +1271,7 @@ int ti_sci_proc_set_boot_cfg(uint8_t proc_id, uint64_t bootvector, ...@@ -1341,8 +1271,7 @@ int ti_sci_proc_set_boot_cfg(uint8_t proc_id, uint64_t bootvector,
struct ti_sci_xfer xfer; struct ti_sci_xfer xfer;
int ret; int ret;
ret = ti_sci_setup_one_xfer(TISCI_MSG_SET_PROC_BOOT_CONFIG, ret = ti_sci_setup_one_xfer(TISCI_MSG_SET_PROC_BOOT_CONFIG, 0,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
&req, sizeof(req), &req, sizeof(req),
&resp, sizeof(resp), &resp, sizeof(resp),
&xfer); &xfer);
...@@ -1364,9 +1293,6 @@ int ti_sci_proc_set_boot_cfg(uint8_t proc_id, uint64_t bootvector, ...@@ -1364,9 +1293,6 @@ int ti_sci_proc_set_boot_cfg(uint8_t proc_id, uint64_t bootvector,
return ret; return ret;
} }
if (!ti_sci_is_response_ack(&resp))
return -ENODEV;
return 0; return 0;
} }
...@@ -1388,8 +1314,7 @@ int ti_sci_proc_set_boot_ctrl(uint8_t proc_id, uint32_t control_flags_set, ...@@ -1388,8 +1314,7 @@ int ti_sci_proc_set_boot_ctrl(uint8_t proc_id, uint32_t control_flags_set,
struct ti_sci_xfer xfer; struct ti_sci_xfer xfer;
int ret; int ret;
ret = ti_sci_setup_one_xfer(TISCI_MSG_SET_PROC_BOOT_CTRL, ret = ti_sci_setup_one_xfer(TISCI_MSG_SET_PROC_BOOT_CTRL, 0,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
&req, sizeof(req), &req, sizeof(req),
&resp, sizeof(resp), &resp, sizeof(resp),
&xfer); &xfer);
...@@ -1408,9 +1333,6 @@ int ti_sci_proc_set_boot_ctrl(uint8_t proc_id, uint32_t control_flags_set, ...@@ -1408,9 +1333,6 @@ int ti_sci_proc_set_boot_ctrl(uint8_t proc_id, uint32_t control_flags_set,
return ret; return ret;
} }
if (!ti_sci_is_response_ack(&resp))
return -ENODEV;
return 0; return 0;
} }
...@@ -1431,8 +1353,7 @@ int ti_sci_proc_auth_boot_image(uint8_t proc_id, uint64_t cert_addr) ...@@ -1431,8 +1353,7 @@ int ti_sci_proc_auth_boot_image(uint8_t proc_id, uint64_t cert_addr)
struct ti_sci_xfer xfer; struct ti_sci_xfer xfer;
int ret; int ret;
ret = ti_sci_setup_one_xfer(TISCI_MSG_PROC_AUTH_BOOT_IMIAGE, ret = ti_sci_setup_one_xfer(TISCI_MSG_PROC_AUTH_BOOT_IMIAGE, 0,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
&req, sizeof(req), &req, sizeof(req),
&resp, sizeof(resp), &resp, sizeof(resp),
&xfer); &xfer);
...@@ -1452,9 +1373,6 @@ int ti_sci_proc_auth_boot_image(uint8_t proc_id, uint64_t cert_addr) ...@@ -1452,9 +1373,6 @@ int ti_sci_proc_auth_boot_image(uint8_t proc_id, uint64_t cert_addr)
return ret; return ret;
} }
if (!ti_sci_is_response_ack(&resp))
return -ENODEV;
return 0; return 0;
} }
...@@ -1476,8 +1394,7 @@ int ti_sci_proc_get_boot_status(uint8_t proc_id, uint64_t *bv, ...@@ -1476,8 +1394,7 @@ int ti_sci_proc_get_boot_status(uint8_t proc_id, uint64_t *bv,
struct ti_sci_xfer xfer; struct ti_sci_xfer xfer;
int ret; int ret;
ret = ti_sci_setup_one_xfer(TISCI_MSG_GET_PROC_BOOT_STATUS, ret = ti_sci_setup_one_xfer(TISCI_MSG_GET_PROC_BOOT_STATUS, 0,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
&req, sizeof(req), &req, sizeof(req),
&resp, sizeof(resp), &resp, sizeof(resp),
&xfer); &xfer);
...@@ -1494,9 +1411,6 @@ int ti_sci_proc_get_boot_status(uint8_t proc_id, uint64_t *bv, ...@@ -1494,9 +1411,6 @@ int ti_sci_proc_get_boot_status(uint8_t proc_id, uint64_t *bv,
return ret; return ret;
} }
if (!ti_sci_is_response_ack(&resp))
return -ENODEV;
*bv = (resp.bootvector_low & TISCI_ADDR_LOW_MASK) | *bv = (resp.bootvector_low & TISCI_ADDR_LOW_MASK) |
(((uint64_t)resp.bootvector_high << TISCI_ADDR_HIGH_SHIFT) & (((uint64_t)resp.bootvector_high << TISCI_ADDR_HIGH_SHIFT) &
TISCI_ADDR_HIGH_MASK); TISCI_ADDR_HIGH_MASK);
...@@ -1556,8 +1470,7 @@ int ti_sci_proc_wait_boot_status(uint8_t proc_id, uint8_t num_wait_iterations, ...@@ -1556,8 +1470,7 @@ int ti_sci_proc_wait_boot_status(uint8_t proc_id, uint8_t num_wait_iterations,
struct ti_sci_xfer xfer; struct ti_sci_xfer xfer;
int ret; int ret;
ret = ti_sci_setup_one_xfer(TISCI_MSG_WAIT_PROC_BOOT_STATUS, ret = ti_sci_setup_one_xfer(TISCI_MSG_WAIT_PROC_BOOT_STATUS, 0,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
&req, sizeof(req), &req, sizeof(req),
&resp, sizeof(resp), &resp, sizeof(resp),
&xfer); &xfer);
...@@ -1582,9 +1495,6 @@ int ti_sci_proc_wait_boot_status(uint8_t proc_id, uint8_t num_wait_iterations, ...@@ -1582,9 +1495,6 @@ int ti_sci_proc_wait_boot_status(uint8_t proc_id, uint8_t num_wait_iterations,
return ret; return ret;
} }
if (!ti_sci_is_response_ack(&resp))
return -ENODEV;
return 0; return 0;
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment