Commit 71a35273 authored by Andrew F. Davis's avatar Andrew F. Davis
Browse files

ti: k3: drivers: ti_sci: Retry message receive on bad sequence ID



When we get a sequence ID that does not match what we expect then the we
are looking at is not the one we are expecting and so we error out. We
can also assume this message is a stale message left in the queue, in
this case we can read in the next message and check again for our
message. Switch to doing that here. We only retry a set number of times
so we don't lock the system if our message is actually lost and will
never show up.
Signed-off-by: default avatarAndrew F. Davis <afd@ti.com>
Change-Id: I6c8186ccc45e646d3ba9d431f7d4c451dcd70c5c
parent 7a469035
...@@ -116,8 +116,10 @@ static inline int ti_sci_get_response(struct ti_sci_xfer *xfer, ...@@ -116,8 +116,10 @@ static inline int ti_sci_get_response(struct ti_sci_xfer *xfer,
{ {
struct k3_sec_proxy_msg *msg = &xfer->rx_message; struct k3_sec_proxy_msg *msg = &xfer->rx_message;
struct ti_sci_msg_hdr *hdr; struct ti_sci_msg_hdr *hdr;
unsigned int retry = 5;
int ret; int ret;
for (; retry > 0; retry--) {
/* Receive the response */ /* Receive the response */
ret = k3_sec_proxy_recv(chan, msg); ret = k3_sec_proxy_recv(chan, msg);
if (ret) { if (ret) {
...@@ -129,8 +131,13 @@ static inline int ti_sci_get_response(struct ti_sci_xfer *xfer, ...@@ -129,8 +131,13 @@ static inline int ti_sci_get_response(struct ti_sci_xfer *xfer,
hdr = (struct ti_sci_msg_hdr *)msg->buf; hdr = (struct ti_sci_msg_hdr *)msg->buf;
/* Sanity check for message response */ /* Sanity check for message response */
if (hdr->seq != info.seq) { if (hdr->seq == info.seq)
ERROR("Message for %d is not expected\n", hdr->seq); break;
else
WARN("Message with sequence ID %u is not expected\n", hdr->seq);
}
if (!retry) {
ERROR("Timed out waiting for message\n");
return -EINVAL; return -EINVAL;
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment