Commit be4cd40e authored by Masahiro Yamada's avatar Masahiro Yamada
Browse files

Build: fix assert_boolean implementation



The current assert_boolean does not work with variables assigned with
'=' flavor instead of ':='.

For example,

 FOO = $(BAR)
 BAR := 1

Here, $(value FOO) is evaluated to $(BAR), not 1.  This is not what
we expect.  While I am here, I simplified the implementation.
Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
parent 727a68b8
...@@ -54,7 +54,7 @@ endef ...@@ -54,7 +54,7 @@ endef
# Convenience function for verifying option has a boolean value # Convenience function for verifying option has a boolean value
# $(eval $(call assert_boolean,FOO)) will assert FOO is 0 or 1 # $(eval $(call assert_boolean,FOO)) will assert FOO is 0 or 1
define assert_boolean define assert_boolean
$(and $(patsubst 0,,$(value $(1))),$(patsubst 1,,$(value $(1))),$(error $(1) must be boolean)) $(if $(filter-out 0 1,$($1)),$(error $1 must be boolean))
endef endef
0-9 := 0 1 2 3 4 5 6 7 8 9 0-9 := 0 1 2 3 4 5 6 7 8 9
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment