Commit c0f73edc authored by Jan Kiszka's avatar Jan Kiszka Committed by Konstantin Porotchkin
Browse files

tools: Fix broken object compilation rules



As these rules depend on non-existing headers as well (likely copy &
pasted from fiptool), they never matched, and the built-in rules were
used. That led to random breakages when e.g. CPPFLAGS was suddenly
evaluated and contained invalid options.

For the stm32image, this reveals that we were relying on the built-in
rules by passing -D_GNU_SOURCE via CPPFLAGS, rather than using CFLAGS as
used in the local rule. Fix that as well.
Signed-off-by: default avatarJan Kiszka <jan.kiszka@siemens.com>
parent 37c4341b
......@@ -39,7 +39,7 @@ ${PROJECT}: ${OBJECTS} Makefile
@echo "Built $@ successfully"
@echo
%.o: %.c %.h Makefile
%.o: %.c Makefile
@echo " CC $<"
${Q}${CC} -c ${CFLAGS} ${INCLUDE_PATHS} $< -o $@
......
......@@ -12,8 +12,7 @@ PROJECT := stm32image${BIN_EXT}
OBJECTS := stm32image.o
V := 0
override CPPFLAGS += -D_GNU_SOURCE
CFLAGS := -Wall -Werror -pedantic -std=c99
CFLAGS := -Wall -Werror -pedantic -std=c99 -D_GNU_SOURCE
ifeq (${DEBUG},1)
CFLAGS += -g -O0 -DDEBUG
else
......@@ -39,7 +38,7 @@ ${PROJECT}: ${OBJECTS} Makefile
@echo "Built $@ successfully"
@${ECHO_BLANK_LINE}
%.o: %.c %.h Makefile
%.o: %.c Makefile
@echo " CC $<"
${Q}${CC} -c ${CFLAGS} $< -o $@
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment