Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
Menu
Open sidebar
adam.huang
Arm Trusted Firmware
Commits
cc392dd8
Commit
cc392dd8
authored
Oct 12, 2020
by
Madhukar Pappireddy
Committed by
TrustedFirmware Code Review
Oct 12, 2020
Browse files
Merge "Fix casting bug in gicv2_main.c" into integration
parents
e180cdba
20d38497
Changes
1
Show whitespace changes
Inline
Side-by-side
drivers/arm/gic/v2/gicv2_main.c
View file @
cc392dd8
/*
/*
* Copyright (c) 2015-20
18
, ARM Limited and Contributors. All rights reserved.
* Copyright (c) 2015-20
20
, ARM Limited and Contributors. All rights reserved.
*
*
* SPDX-License-Identifier: BSD-3-Clause
* SPDX-License-Identifier: BSD-3-Clause
*/
*/
...
@@ -296,8 +296,8 @@ void gicv2_set_pe_target_mask(unsigned int proc_num)
...
@@ -296,8 +296,8 @@ void gicv2_set_pe_target_mask(unsigned int proc_num)
assert
(
driver_data
!=
NULL
);
assert
(
driver_data
!=
NULL
);
assert
(
driver_data
->
gicd_base
!=
0U
);
assert
(
driver_data
->
gicd_base
!=
0U
);
assert
(
driver_data
->
target_masks
!=
NULL
);
assert
(
driver_data
->
target_masks
!=
NULL
);
assert
(
(
unsigned
int
)
proc_num
<
GICV2_MAX_TARGET_PE
);
assert
(
proc_num
<
GICV2_MAX_TARGET_PE
);
assert
(
(
unsigned
int
)
proc_num
<
driver_data
->
target_masks_num
);
assert
(
proc_num
<
driver_data
->
target_masks_num
);
/* Return if the target mask is already populated */
/* Return if the target mask is already populated */
if
(
driver_data
->
target_masks
[
proc_num
]
!=
0U
)
if
(
driver_data
->
target_masks
[
proc_num
]
!=
0U
)
...
@@ -422,7 +422,8 @@ void gicv2_raise_sgi(int sgi_num, int proc_num)
...
@@ -422,7 +422,8 @@ void gicv2_raise_sgi(int sgi_num, int proc_num)
unsigned
int
sgir_val
,
target
;
unsigned
int
sgir_val
,
target
;
assert
(
driver_data
!=
NULL
);
assert
(
driver_data
!=
NULL
);
assert
((
unsigned
int
)
proc_num
<
GICV2_MAX_TARGET_PE
);
assert
(
proc_num
>=
0
);
assert
(
proc_num
<
(
int
)
GICV2_MAX_TARGET_PE
);
assert
(
driver_data
->
gicd_base
!=
0U
);
assert
(
driver_data
->
gicd_base
!=
0U
);
/*
/*
...
@@ -430,7 +431,7 @@ void gicv2_raise_sgi(int sgi_num, int proc_num)
...
@@ -430,7 +431,7 @@ void gicv2_raise_sgi(int sgi_num, int proc_num)
* should be valid.
* should be valid.
*/
*/
assert
(
driver_data
->
target_masks
!=
NULL
);
assert
(
driver_data
->
target_masks
!=
NULL
);
assert
(
(
unsigned
int
)
proc_num
<
driver_data
->
target_masks_num
);
assert
(
proc_num
<
(
int
)
driver_data
->
target_masks_num
);
/* Don't raise SGI if the mask hasn't been populated */
/* Don't raise SGI if the mask hasn't been populated */
target
=
driver_data
->
target_masks
[
proc_num
];
target
=
driver_data
->
target_masks
[
proc_num
];
...
@@ -466,8 +467,9 @@ void gicv2_set_spi_routing(unsigned int id, int proc_num)
...
@@ -466,8 +467,9 @@ void gicv2_set_spi_routing(unsigned int id, int proc_num)
* should be valid.
* should be valid.
*/
*/
assert
(
driver_data
->
target_masks
!=
NULL
);
assert
(
driver_data
->
target_masks
!=
NULL
);
assert
((
unsigned
int
)
proc_num
<
GICV2_MAX_TARGET_PE
);
assert
(
proc_num
<
(
int
)
GICV2_MAX_TARGET_PE
);
assert
((
unsigned
int
)
proc_num
<
driver_data
->
target_masks_num
);
assert
(
driver_data
->
target_masks_num
<
INT_MAX
);
assert
(
proc_num
<
(
int
)
driver_data
->
target_masks_num
);
if
(
proc_num
<
0
)
{
if
(
proc_num
<
0
)
{
/* Target all PEs */
/* Target all PEs */
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment