Commit e74afb65 authored by Antonio Nino Diaz's avatar Antonio Nino Diaz
Browse files

Deprecate weak crash console functions


The default behaviour of the plat_crash_console_xxx functions isn't
obvious to someone that hasn't read all the documentation. As they are
not mandatory, it is unlikely that the code will be checked when doing a
platform port, which may mean that some platforms may not have crash
console support at all.

The idea of this patch is to force platform maintainers to decide how
the crash console has to behave so that the final behaviour isn't
unexpected.

Change-Id: I40b2a7b56c5530c1dcd63eace5bd37ae6335056e
Signed-off-by: default avatarAntonio Nino Diaz <antonio.ninodiaz@arm.com>
parent a9d5a3ff
Showing with 8 additions and 0 deletions
+8 -0
...@@ -8,9 +8,11 @@ ...@@ -8,9 +8,11 @@
#include <asm_macros.S> #include <asm_macros.S>
.weak plat_report_exception .weak plat_report_exception
#if !ERROR_DEPRECATED
.weak plat_crash_console_init .weak plat_crash_console_init
.weak plat_crash_console_putc .weak plat_crash_console_putc
.weak plat_crash_console_flush .weak plat_crash_console_flush
#endif
.weak plat_reset_handler .weak plat_reset_handler
.weak plat_disable_acp .weak plat_disable_acp
.weak bl1_plat_prepare_exit .weak bl1_plat_prepare_exit
...@@ -26,6 +28,7 @@ func plat_report_exception ...@@ -26,6 +28,7 @@ func plat_report_exception
bx lr bx lr
endfunc plat_report_exception endfunc plat_report_exception
#if !ERROR_DEPRECATED
/* ----------------------------------------------------- /* -----------------------------------------------------
* Placeholder function which should be redefined by * Placeholder function which should be redefined by
* each platform. * each platform.
...@@ -54,6 +57,7 @@ func plat_crash_console_flush ...@@ -54,6 +57,7 @@ func plat_crash_console_flush
mov r0, #0 mov r0, #0
bx lr bx lr
endfunc plat_crash_console_flush endfunc plat_crash_console_flush
#endif
/* ----------------------------------------------------- /* -----------------------------------------------------
* Placeholder function which should be redefined by * Placeholder function which should be redefined by
......
...@@ -10,9 +10,11 @@ ...@@ -10,9 +10,11 @@
#include <platform_def.h> #include <platform_def.h>
.weak plat_report_exception .weak plat_report_exception
#if !ERROR_DEPRECATED
.weak plat_crash_console_init .weak plat_crash_console_init
.weak plat_crash_console_putc .weak plat_crash_console_putc
.weak plat_crash_console_flush .weak plat_crash_console_flush
#endif
.weak plat_reset_handler .weak plat_reset_handler
.weak plat_disable_acp .weak plat_disable_acp
.weak bl1_plat_prepare_exit .weak bl1_plat_prepare_exit
...@@ -37,6 +39,7 @@ func plat_report_exception ...@@ -37,6 +39,7 @@ func plat_report_exception
ret ret
endfunc plat_report_exception endfunc plat_report_exception
#if !ERROR_DEPRECATED
#if MULTI_CONSOLE_API #if MULTI_CONSOLE_API
/* ----------------------------------------------------- /* -----------------------------------------------------
* int plat_crash_console_init(void) * int plat_crash_console_init(void)
...@@ -109,6 +112,7 @@ func plat_crash_console_flush ...@@ -109,6 +112,7 @@ func plat_crash_console_flush
ret ret
endfunc plat_crash_console_flush endfunc plat_crash_console_flush
#endif #endif
#endif /* ERROR_DEPRECATED */
/* ----------------------------------------------------- /* -----------------------------------------------------
* Placeholder function which should be redefined by * Placeholder function which should be redefined by
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment