From f6c4b19ac84054f191d69662404f4af321f08b2e Mon Sep 17 00:00:00 2001 From: Hadi Asyrafi Date: Mon, 13 Jan 2020 16:26:22 +0800 Subject: [PATCH] intel: Remove un-needed checks for qspi driver r/w This patch removes un-needed r/w parameter checks for qspi driver. The driver can actually access any offset and size. Signed-off-by: Hadi Asyrafi Change-Id: If60b2c016aa91e2c24ddc57c6ad410c8dc5dcf53 --- plat/intel/soc/common/drivers/qspi/cadence_qspi.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/plat/intel/soc/common/drivers/qspi/cadence_qspi.c b/plat/intel/soc/common/drivers/qspi/cadence_qspi.c index d7cd71bec..cecf56088 100644 --- a/plat/intel/soc/common/drivers/qspi/cadence_qspi.c +++ b/plat/intel/soc/common/drivers/qspi/cadence_qspi.c @@ -688,10 +688,7 @@ int cad_qspi_read(void *buffer, uint32_t offset, uint32_t size) if ((offset >= qspi_device_size) || (offset + size - 1 >= qspi_device_size) || - (size == 0) || - ((long) ((int *)buffer) & 0x3) || - (offset & 0x3) || - (size & 0x3)) { + (size == 0)) { ERROR("Invalid read parameter\n"); return -1; } @@ -766,11 +763,9 @@ int cad_qspi_write(void *buffer, uint32_t offset, uint32_t size) if ((offset >= qspi_device_size) || (offset + size - 1 >= qspi_device_size) || - (size == 0) || - ((long)buffer & 0x3) || - (offset & 0x3) || - (size & 0x3)) + (size == 0)) { return -2; + } if (CAD_QSPI_INDWR_RDSTAT(mmio_read_32(CAD_QSPI_OFFSET + CAD_QSPI_INDWR))) { -- GitLab