From fa06b744305be8538f4908e86ef563ff15b898e7 Mon Sep 17 00:00:00 2001 From: John Tsichritzis Date: Thu, 16 Aug 2018 14:37:40 +0100 Subject: [PATCH] Fix static analysis defects Fixed a Coverity defect by adding a runtime check to avoid potential NULL pointer dereference. Change-Id: I9a0aa0efd27334131ac835b43348658b436c657d Signed-off-by: John Tsichritzis --- plat/arm/css/sgi/sgi_image_load.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/plat/arm/css/sgi/sgi_image_load.c b/plat/arm/css/sgi/sgi_image_load.c index dda5e96c5..09403f884 100644 --- a/plat/arm/css/sgi/sgi_image_load.c +++ b/plat/arm/css/sgi/sgi_image_load.c @@ -39,10 +39,15 @@ static int plat_sgi_append_config_node(void) platform_name = (char *)fdt_getprop(fdt, 0, "compatible", NULL); + if (platform_name == NULL) { + ERROR("Invalid HW_CONFIG DTB passed\n"); + return -1; + } + if (strcmp(platform_name, "arm,sgi575") == 0) { platid = mmio_read_32(SSC_VERSION); } else { - WARN("Invalid platform \n"); + WARN("Invalid platform\n"); return -1; } -- GitLab