Improving wireless AP mode detection. Displaying a warning on few low quality...

Improving wireless AP mode detection. Displaying a warning on few low quality or know to fail combinations.

debian-config-jobs

@@ -270,6 +270,7 @@ function jobs ()
 				ifdown $WIRELESS_ADAPTER 2> /dev/null
 				rm -f /etc/network/interfaces.d/armbian.ap.nat
 				rm -f /etc/network/interfaces.d/armbian.ap.bridge
+				rm -f /var/run/hostapd/* >/dev/null 2>&1
 				sed -i '/^iptables/ d' /etc/rc.local
 				sed 's/interface-name:wl.*//' -i /etc/NetworkManager/conf.d/10-ignore-interfaces.conf
 				sed 's/,$//' -i /etc/NetworkManager/conf.d/10-ignore-interfaces.conf
@@ -282,12 +283,22 @@ function jobs ()
 		elif [[ -z $CURRENT_UUID ]]; then
 				dialog --title " Info " --backtitle "$BACKTITLE" --no-collapse --msgbox "\nAll wireless connections are in use." 7 40
 		else
+				# check for low quality drivers and combinations
+				check_and_warn
+
 				# remove interfaces from managed list
 				if [[ -f /etc/NetworkManager/conf.d/10-ignore-interfaces.conf ]]; then
 					sed 's/interface-name:wl.*//' -i /etc/NetworkManager/conf.d/10-ignore-interfaces.conf
 					sed 's/,$//' -i /etc/NetworkManager/conf.d/10-ignore-interfaces.conf
 				fi
 
+				# clear current settings
+				rm -f /etc/network/interfaces.d/armbian.ap.nat
+				rm -f /etc/network/interfaces.d/armbian.ap.bridge
+				service networking restart
+				service network-manager restart
+				{ for ((i = 0 ; i <= 100 ; i+=20)); do sleep 1; echo $i; done } | dialog --title " Initializing wireless adapters " --colors --gauge "" 5 50 0
+
 				# start with basic config
 				if grep -q "^## IEEE 802.11ac" /etc/hostapd.conf; then sed '/## IEEE 802.11ac\>/,/^## IEEE 802.11ac\>/ s/.*/#&/' -i /etc/hostapd.conf; fi
 				if grep -q "^## IEEE 802.11a" /etc/hostapd.conf; then sed '/## IEEE 802.11a\>/,/^## IEEE 802.11a\>/ s/.*/#&/' -i /etc/hostapd.conf; fi
@@ -311,7 +322,7 @@ function jobs ()
 				# display dialog
 				dialog --colors --backtitle "$BACKTITLE" --title "Please wait" --infobox \
 				"\nWireless adapter: \Z1${WIRELESS_ADAPTER}\Z0\n\nProbing nl80211 hostapd driver compatibility." 7 50
-				apt-get -o Dpkg::Options::="--force-confnew" -y -qq --no-install-recommends install hostapd > /dev/null
+				debconf-apt-progress -- apt-get --reinstall -o Dpkg::Options::="--force-confnew" -y -qq --no-install-recommends install hostapd
 				# change to selected interface
 				sed -i "s/^interface=.*/interface=$WIRELESS_ADAPTER/" /etc/hostapd.conf
 				# add hostapd.conf to services
@@ -326,11 +337,10 @@ function jobs ()
 				#
 				check_advanced_modes
 				#
-				CHECK=$(systemctl daemon-reload;service hostapd stop; sleep 2;service hostapd start;sleep 2;service hostapd status|grep fail)
-				if [[ -n "$CHECK" ]]; then
+				if [[ -n "$hostapd_error" ]]; then
 					dialog --colors --backtitle "$BACKTITLE" --title "Please wait" --infobox \
 					"\nWireless adapter: \Z1${WIRELESS_ADAPTER}\Z0\n\nProbing Realtek hostapd driver compatibility." 7 50
-					apt-get -o Dpkg::Options::="--force-confnew" -y -qq --no-install-recommends install hostapd-realtek > /dev/null
+					debconf-apt-progress -- apt-get --reinstall -o Dpkg::Options::="--force-confnew" -y -qq --no-install-recommends install hostapd-realtek
 					# change to selected interface
 					sed -i "s/^interface=.*/interface=$WIRELESS_ADAPTER/" /etc/hostapd.conf
 					# add allow cli access if not exists. temporally
@@ -343,9 +353,7 @@ function jobs ()
 					#
 				fi
 
-				CHECK=$(systemctl daemon-reload;service hostapd stop; sleep 2;service hostapd start;service hostapd status|grep fail)
-				# if both fails there is other problem
-				if [[ -n "$CHECK" ]]; then
+				if [[ -n "$hostapd_error" ]]; then
 					dialog --backtitle "$BACKTITLE" --title "Warning" \
 					--infobox "\nWireless adapter: $WIRELESS_ADAPTER\n\nNo compatible hostapd driver found." 7 39
 					sed -i "s/^DAEMON_CONF=.*/DAEMON_CONF=/" /etc/init.d/hostapd
@@ -353,8 +361,6 @@ function jobs ()
 					sed 's/interface-name:wl.*//' -i /etc/NetworkManager/conf.d/10-ignore-interfaces.conf
 					sed 's/,$//' -i /etc/NetworkManager/conf.d/10-ignore-interfaces.conf
 					systemctl daemon-reload;service hostapd restart
-					sleep 3
-					break
 				fi
 
 				# let's remove bridge out for this simple configurator
@@ -432,7 +438,7 @@ function jobs ()
 				255) exit;;
 				esac
 
-				dialog --backtitle "$BACKTITLE" --title " Please wait " --infobox "\nEnabling hotstop. Please wait!" 5 34
+				dialog --backtitle "$BACKTITLE" --title " Please wait " --infobox "\nEnabling hotspot. Please wait!" 5 34
 
 				#
 				# only for bridged connection we need to check and reboot. tdlr check if it can be done on the fly

debian-config-submenu

@@ -7,10 +7,11 @@
 # warranty of any kind, whether express or implied.
 
 
+
 check_if_installed (){
 #------------------------------------------------------------------------------------------------------------------------------------------
 # check dpkg status of $1 -- currently only 'not installed at all' case catched
-#------------------------------------------------------------------------------------------------------------------------------------------
+#
 	local DPKG_Status="$(dpkg -s "$1" 2>/dev/null | awk -F": " '/^Status/ {print $2}')"
 	if [[ "X${DPKG_Status}" = "X" || "${DPKG_Status}" = *deinstall* ]]; then
 		return 1
@@ -20,55 +21,65 @@ check_if_installed (){
 }
 
 
+#-----------------------------------------------------------------------------------------------------------------------------------------#
+# check hostapd configuration. Return error or empty if o.k.
+#
+check_hostapd ()
+{
+systemctl daemon-reload
+hostapd_error=""
+[[ -n $1 && -n $2 ]] && dialog --title " $1 " --backtitle "$BACKTITLE" --no-collapse --colors --infobox "$2" 5 $((${#2}-3))
+service hostapd stop
+rm -f /var/run/hostapd/*
+sleep 1
+service hostapd start
+sleep 6
+if [[ "$(hostapd_cli ping 2> /dev/null| grep PONG)" == "PONG" ]]; then
+		hostapd_error=""
+	else
+		hostapd_error=$(hostapd /etc/hostapd.conf)
+		sleep 6
+		[[ -n $(echo $hostapd_error | grep "channel") ]] && hostapd_error="channel_restriction"
+		[[ -n $(echo $hostapd_error | grep "does not support" | grep "hw_mode") ]] && hostapd_error="hw_mode"
+		[[ -n $(echo $hostapd_error | grep "not found from the channel list" | grep "802.11g") ]] && hostapd_error="wrong_channel"
+		[[ -n $(echo $hostapd_error | grep "VHT") ]] && hostapd_error="unsupported_vht"
+		[[ -n $(echo $hostapd_error | grep " HT capability") ]] && hostapd_error="unsupported_ht"
+fi
+}
+
+
 #-----------------------------------------------------------------------------------------------------------------------------------------#
 # check all possible wireless modes
 #
 function check_advanced_modes ()
 {
-CHECK=$(systemctl daemon-reload;service hostapd stop; sleep 2;service hostapd start;sleep 2;service hostapd status|grep fail)
-# check n,a and ac modes
-if [[ -z "$CHECK" ]]; then
-	dialog --title " Info " --backtitle "$BACKTITLE" --no-collapse --colors --infobox "\nProbing wireless 802.11n \Z1(150-300Mbps)\Z0" 5 43
-	sleep 2
-	sed '/### IEEE 802.11n/,/^### IEEE 802.11n/ s/^# *//' -i /etc/hostapd.conf
-	CHECK=$(systemctl daemon-reload;service hostapd stop; sleep 2;service hostapd start;sleep 2;service hostapd status|grep fail)
-	if [[ -z "$CHECK" ]]; then
-		# check various HT modes
-		check_ht_capab
-		# than go to check 5Ghz
-		dialog --title " Info " --backtitle "$BACKTITLE" --no-collapse --colors --infobox "\nProbing wireless 802.11a \Z1(5Ghz)\Z0" 5 36
-		sleep 2
+sed '/### IEEE 802.11n/,/^### IEEE 802.11n/ s/^# *//' -i /etc/hostapd.conf
+check_hostapd "Probing" "\n802.11n \Z1(150-300Mbps)\Z0"
+# check HT capability
+check_ht_capab
+if [[ -z "$hostapd_error" ]]; then
 	sed '/### IEEE 802.11a\>/,/^### IEEE 802.11a\>/ s/^# *//' -i /etc/hostapd.conf
-		CHECK=$(systemctl daemon-reload;service hostapd stop; sleep 2;service hostapd start;sleep 2;service hostapd status|grep fail)
-		if [[ -n "$CHECK" ]]; then
-			check_channels
-		fi
-		CHECK=$(systemctl daemon-reload;service hostapd stop; sleep 2;service hostapd start;service hostapd status|grep fail)
-		if [[ -z "$CHECK" ]]; then
-			dialog --title " Info " --backtitle "$BACKTITLE" --no-collapse --colors \
-			--infobox "\nProbing wireless 802.11ac \Z1(433Mbps x n @ 5Ghz)\Z0" 5 51
-			sleep 2
+	sed -i "s/^channel=.*/channel=40/" /etc/hostapd.conf
+	check_hostapd "Probing" "\n802.11a \Z1(5Ghz)\Z0"
+	if [[ "$hostapd_error" == "channel_restriction" ]]; then check_channels; fi
+	if [[ "$hostapd_error" == "channel_restriction" ]]; then
+		# revering configuration
+		sed -i "s/^channel=.*/channel=5/" /etc/hostapd.conf
+		sed '/## IEEE 802.11a\>/,/^## IEEE 802.11a\>/ s/.*/#&/' -i /etc/hostapd.conf
+		check_hostapd "Reverting" "\nWireless \Z1802.11a (5Ghz)\Z0 is not supported"
+	else
 		sed '/### IEEE 802.11ac\>/,/^### IEEE 802.11ac\>/ s/^# *//' -i /etc/hostapd.conf
-			CHECK=$(systemctl daemon-reload;service hostapd stop; sleep 2;service hostapd start;service hostapd status|grep fail)
-			if [[ -n "$CHECK" ]]; then
-				check_channels
-			fi
-			if [[ -n "$CHECK" ]]; then
-				dialog --title " Reverting configuration " --backtitle "$BACKTITLE" --no-collapse --colors \
-				--infobox "\nWireless 802.11ac \Z1(433Mbps x n @ 5Ghz)\Z0 is not supported!" 5 60
+		# check VHT capability
+		check_vht_capab
+		if [[ "$hostapd_error" == "unsupported_vht" || "$hostapd_error" == "channel_restriction" ]]; then
+			# revering configuration
 			sed '/## IEEE 802.11ac\>/,/^## IEEE 802.11ac\>/ s/.*/#&/' -i /etc/hostapd.conf
+			check_hostapd "Reverting" "\nWireless 802.11ac \Z1(433Mbps x n @ 5Ghz)\Z0 is not supported"
+			if [[ "$hostapd_error" == "channel_restriction" ]]; then check_channels; fi
 		fi
-		else
-			dialog --title " Reverting configuration " --backtitle "$BACKTITLE" --no-collapse --colors \
-			--infobox "\nWireless 802.11a \Z1(5Ghz)\Z0 is not supported!" 5 45
-			sed -i "s/^channel=.*/channel=5/" /etc/hostapd.conf
-			sed '/## IEEE 802.11a\>/,/^## IEEE 802.11a\>/ s/.*/#&/' -i /etc/hostapd.conf
 	fi
-	else
-		dialog --title " Reverting configuration " --backtitle "$BACKTITLE" --no-collapse --colors \
-		--infobox "\nWireless 802.11n \Z1(150-300Mbps)\Z0 is not supported!" 5 52
+else
 	sed '/## IEEE 802.11n/,/^## IEEE 802.11n/ s/.*/#&/' -i /etc/hostapd.conf
-	fi
 fi
 }
 
@@ -147,16 +158,36 @@ dialog --colors --backtitle "$BACKTITLE" --no-collapse --title " $1 " --clear --
 function check_ht_capab ()
 {
 declare -a arr=("[HT40+][LDPC][SHORT-GI-20][SHORT-GI-40][TX-STBC][RX-STBC1][DSSS_CCK-40][SMPS-STATIC]" \
-"[HT40-][SHORT-GI-40][SHORT-GI-40][DSSS_CCK-40]" "[SHORT-GI-20][SHORT-GI-40][HT40+]" "[DSSS_CK-40][HT20+]")
+"[HT40-][SHORT-GI-40][SHORT-GI-40][DSSS_CCK-40]" "[SHORT-GI-20][SHORT-GI-40][HT40+]" "[DSSS_CK-40][HT20+]" "")
 local j=0
 for i in "${arr[@]}"
 do
-	j=$((j+1))
-	dialog --title " Info " --backtitle "$BACKTITLE" --no-collapse --colors \
-	--infobox "\nProbing high throughput capabilities \Z1(${j})\Z0" 5 46
+	j=$((j+(100/${#arr[@]})))
+	echo $j | dialog --title " Probing HT " --colors --gauge "\nSeeking for optimal \Z1high throughput\Z0 settings." 8 50 0
 	sed -i "s/^ht_capab=.*/ht_capab=$i/" /etc/hostapd.conf
-	CHECK=$(systemctl daemon-reload;service hostapd stop; sleep 2;service hostapd start;sleep 2;service hostapd status|grep fail)
-	if [[ -z "$CHECK" ]]; then break; fi
+	check_hostapd
+	if [[ "$hostapd_error" == "channel_restriction" ]]; then check_channels; fi
+	if [[ "$hostapd_error" == "" ]]; then break; fi
+done
+}
+
+
+#-----------------------------------------------------------------------------------------------------------------------------------------#
+#
+# check wifi high throughput
+#
+function check_vht_capab ()
+{
+declare -a arr=("[MAX-MPDU-11454][SHORT-GI-80][TX-STBC-2BY1][RX-STBC-1][MAX-A-MPDU-LEN-EXP3]" "[MAX-MPDU-11454][SHORT-GI-80][RX-STBC-1][MAX-A-MPDU-LEN-EXP3]" "")
+local j=0
+for i in "${arr[@]}"
+do
+	j=$((j+(100/${#arr[@]})))
+	echo $j | dialog --title " Probing VHT " --colors --gauge "\nSeeking for optimal \Z1very high throughput\Z0 settings." 8 54 0
+	sed -i "s/^vht_capab=.*/vht_capab=$i/" /etc/hostapd.conf
+	check_hostapd
+	if [[ "$hostapd_error" == "channel_restriction" ]]; then check_channels; fi
+	if [[ "$hostapd_error" == "" ]]; then break; fi
 done
 }
 
@@ -170,10 +201,9 @@ function check_channels ()
 declare -a arr=("36" "40")
 for i in "${arr[@]}"
 do
-	dialog --title " Info " --backtitle "$BACKTITLE" --no-collapse --colors --infobox "\nProbing channels \Z1(${i})\Z0" 5 26
 	sed -i "s/^channel=.*/channel=$i/" /etc/hostapd.conf
-	CHECK=$(systemctl daemon-reload;service hostapd stop; sleep 2;service hostapd start;sleep 2;service hostapd status|grep fail)
-	if [[ -z "$CHECK" ]]; then break; fi
+	check_hostapd "Probing" "\nChannel:\Z1 ${i}\Z0"
+	if [[ "$hostapd_error" != "channel_restriction" ]]; then break; fi
 done
 }
 
@@ -311,6 +341,22 @@ function wlan_exceptions ()
 	rm /etc/modprobe.d/ap6212.conf && rmmod dhd && modprobe dhd
 }
 
+#-----------------------------------------------------------------------------------------------------------------------------------------#
+# here add shaddy wifi adaptors
+#
+function check_and_warn ()
+{
+local shaddy=false
+# blacklist
+[[ "$LINUXFAMILY" == "sun8i" && $BOARD == "orangepizero" ]] && shaddy=true
+[[ -n "$(lsmod | grep mt7601u)" ]] && shaddy=true
+[[ -n "$(lsmod | grep r8188eu)" ]] && shaddy=true
+# blacklist
+if [[ "$shaddy" == "true" ]]; then
+dialog --title " Warning " --ok-label " Accept and proceed " --msgbox '\nOne of your wireless drivers are on a black list due to poor quality.\n\nAP mode might not be possible!' 9 73
+fi
+}
+
 
 #-----------------------------------------------------------------------------------------------------------------------------------------#
 # check if board has alternative kernels
@@ -693,9 +739,9 @@ while true; do
 		if [[ `grep ^ieee80211n /etc/hostapd.conf` ]]; then local type="N"; fi
 		if [[ `grep ^ieee80211ac /etc/hostapd.conf` ]]; then local type="AC"; fi
 		disclaimer=$disclaimer$" \Z1${band} ${type}\Z0"
-		if [ -n $chpid ]; then disclaimer=$disclaimer$"\n\nChip: \Z1${chpid}\Z0"; fi
+		[[ ! "$chpid" =~ .*IPv6.* ]] && disclaimer=$disclaimer$"\n\nChip: \Z1${chpid}\Z0";
 		if [ "$HOSTAPDCLIENTS" -gt "0" ]; then disclaimer=$disclaimer$" Connected clients: \Z1$HOSTAPDCLIENTS\Zn"; fi
-		if [ -n $chip ] || [ "$HOSTAPDCLIENTS" -gt "0" ]; then LISTLENGHT=$((LISTLENGHT+2)); fi
+		if [[ ! "$chpid" =~ .*IPv6.* ]]; then LISTLENGHT=$((LISTLENGHT+2)); fi
 		disclaimer=$disclaimer$"\n";
 	fi
 	disclaimer=$disclaimer"\n\Z1Note\Zn: This tool can be successful only when drivers are in good shape. If autodetection fails, you are on your own.\n "