Small RFC

softy

@@ -353,32 +353,33 @@ cat >> /etc/cron.daily/seed-armbian-torrent <<"EOF"
 #
 
 # download latest torrent pack
-rm -f /tmp/tmp.zip; wget -qO- -O /tmp/tmp.zip https://dl.armbian.com/torrent/all-torrents.zip
+TEMP=$(mktemp -d)
+wget -qO- -O $TEMP/tmp.zip https://dl.armbian.com/torrent/all-torrents.zip
 
 # test zip for corruption
-unzip -t /tmp/tmp.zip >/dev/null 2>&1
+unzip -t $TEMP/tmp.zip >/dev/null 2>&1
 [[ $? -ne 0 ]] && echo "Error in zip" && exit
 # extract zip
-unzip -o /tmp/tmp.zip -d /tmp/torrent-tmp >/dev/null 2>&1
+unzip -o $TEMP/tmp.zip -d $TEMP/torrent-tmp >/dev/null 2>&1
 
 # create list of current active torrents
-transmission-remote -n 'transmission:transmission' -l | sed '1d; $d' > /tmp/torrent-tmp/active.torrents
+transmission-remote -n 'transmission:transmission' -l | sed '1d; $d' > $TEMP/torrent-tmp/active.torrents
 
 # loop and add/update torrent files
-for f in /tmp/torrent-tmp/*.torrent; do
+for f in $TEMP/torrent-tmp/*.torrent; do
         transmission-remote -n 'transmission:transmission' -a $f > /dev/null 2>&1
         # remove added from the list
-        pattern="${f//.torrent}"; pattern="${pattern//\/tmp\/torrent-tmp\/}";
-        sed -i "/$pattern/d" /tmp/torrent-tmp/active.torrents
+        pattern="${f//.torrent}"; pattern="${pattern##*/}";
+        sed -i "/$pattern/d" $TEMP/torrent-tmp/active.torrents
 done
 
 # remove old armbian torrents
 while read i; do
         [[ $i == *Armbian_* ]] && transmission-remote -n 'transmission:transmission' -t $(echo "$i" | awk '{print $1}';) --remove-and-delete
-done < /tmp/torrent-tmp/active.torrents
+done < $TEMP/torrent-tmp/active.torrents
 
 # remove temporally files and direcotories
-rm -rf /tmp/torrent-tmp
+rm -rf $TEMP
 EOF
 chmod +x /etc/cron.daily/seed-armbian-torrent
 /etc/cron.daily/seed-armbian-torrent