swarm_dial.go 14.3 KB
Newer Older
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1
2
3
4
5
package swarm

import (
	"errors"
	"fmt"
6
	"math/rand"
7
	"net"
8
	"sync"
9
	"time"
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
10

Jeromy's avatar
Jeromy committed
11
	mconn "github.com/ipfs/go-ipfs/metrics/conn"
12
13
14
15
	conn "github.com/ipfs/go-ipfs/p2p/net/conn"
	addrutil "github.com/ipfs/go-ipfs/p2p/net/swarm/addr"
	peer "github.com/ipfs/go-ipfs/p2p/peer"
	lgbl "github.com/ipfs/go-ipfs/util/eventlog/loggables"
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
16

17
18
19
20
21
	ma "github.com/ipfs/go-ipfs/Godeps/_workspace/src/github.com/jbenet/go-multiaddr"
	manet "github.com/ipfs/go-ipfs/Godeps/_workspace/src/github.com/jbenet/go-multiaddr-net"
	process "github.com/ipfs/go-ipfs/Godeps/_workspace/src/github.com/jbenet/goprocess"
	ratelimit "github.com/ipfs/go-ipfs/Godeps/_workspace/src/github.com/jbenet/goprocess/ratelimit"
	context "github.com/ipfs/go-ipfs/Godeps/_workspace/src/golang.org/x/net/context"
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
22
23
)

24
25
26
27
28
29
30
31
32
33
34
// Diagram of dial sync:
//
//   many callers of Dial()   synched w.  dials many addrs       results to callers
//  ----------------------\    dialsync    use earliest            /--------------
//  -----------------------\              |----------\           /----------------
//  ------------------------>------------<-------     >---------<-----------------
//  -----------------------|              \----x                 \----------------
//  ----------------------|                \-----x                \---------------
//                                         any may fail          if no addr at end
//                                                             retry dialAttempt x

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
35
36
37
38
39
40
var (
	ErrDialBackoff = errors.New("dial backoff")
	ErrDialFailed  = errors.New("dial attempt failed")
	ErrDialToSelf  = errors.New("dial to self attempted")
)

41
// dialAttempts governs how many times a goroutine will try to dial a given peer.
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
42
43
44
// Note: this is down to one, as we have _too many dials_ atm. To add back in,
// add loop back in Dial(.)
const dialAttempts = 1
45

46
47
48
// DialTimeout is the amount of time each dial attempt has. We can think about making
// this larger down the road, or putting more granular timeouts (i.e. within each
// subcomponent of Dial)
49
var DialTimeout time.Duration = time.Second * 10
50

51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
// dialsync is a small object that helps manage ongoing dials.
// this way, if we receive many simultaneous dial requests, one
// can do its thing, while the rest wait.
//
// this interface is so would-be dialers can just:
//
//  for {
//  	c := findConnectionToPeer(peer)
//  	if c != nil {
//  		return c
//  	}
//
//  	// ok, no connections. should we dial?
//  	if ok, wait := dialsync.Lock(peer); !ok {
//  		<-wait // can optionally wait
//  		continue
//  	}
//  	defer dialsync.Unlock(peer)
//
//  	c := actuallyDial(peer)
//  	return c
//  }
//
type dialsync struct {
	// ongoing is a map of tickets for the current peers being dialed.
	// this way, we dont kick off N dials simultaneously.
	ongoing map[peer.ID]chan struct{}
	lock    sync.Mutex
}

// Lock governs the beginning of a dial attempt.
// If there are no ongoing dials, it returns true, and the client is now
// scheduled to dial. Every other goroutine that calls startDial -- with
//the same dst -- will block until client is done. The client MUST call
// ds.Unlock(p) when it is done, to unblock the other callers.
// The client is not reponsible for achieving a successful dial, only for
// reporting the end of the attempt (calling ds.Unlock(p)).
//
// see the example below `dialsync`
func (ds *dialsync) Lock(dst peer.ID) (bool, chan struct{}) {
	ds.lock.Lock()
	if ds.ongoing == nil { // init if not ready
		ds.ongoing = make(map[peer.ID]chan struct{})
	}
	wait, found := ds.ongoing[dst]
	if !found {
		ds.ongoing[dst] = make(chan struct{})
	}
	ds.lock.Unlock()

	if found {
		return false, wait
	}

	// ok! you're signed up to dial!
	return true, nil
}

// Unlock releases waiters to a dial attempt. see Lock.
// if Unlock(p) is called without calling Lock(p) first, Unlock panics.
func (ds *dialsync) Unlock(dst peer.ID) {
	ds.lock.Lock()
	wait, found := ds.ongoing[dst]
	if !found {
		panic("called dialDone with no ongoing dials to peer: " + dst.Pretty())
	}
	delete(ds.ongoing, dst) // remove ongoing dial
	close(wait)             // release everyone else
	ds.lock.Unlock()
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
// dialbackoff is a struct used to avoid over-dialing the same, dead peers.
// Whenever we totally time out on a peer (all three attempts), we add them
// to dialbackoff. Then, whenevers goroutines would _wait_ (dialsync), they
// check dialbackoff. If it's there, they don't wait and exit promptly with
// an error. (the single goroutine that is actually dialing continues to
// dial). If a dial is successful, the peer is removed from backoff.
// Example:
//
//  for {
//  	if ok, wait := dialsync.Lock(p); !ok {
//  		if backoff.Backoff(p) {
//  			return errDialFailed
//  		}
//  		<-wait
//  		continue
//  	}
//  	defer dialsync.Unlock(p)
//  	c, err := actuallyDial(p)
//  	if err != nil {
//  		dialbackoff.AddBackoff(p)
//  		continue
//  	}
//  	dialbackoff.Clear(p)
//  }
//
type dialbackoff struct {
	entries map[peer.ID]struct{}
	lock    sync.RWMutex
}

func (db *dialbackoff) init() {
	if db.entries == nil {
		db.entries = make(map[peer.ID]struct{})
	}
}

// Backoff returns whether the client should backoff from dialing
// peeer p
func (db *dialbackoff) Backoff(p peer.ID) bool {
	db.lock.Lock()
	db.init()
	_, found := db.entries[p]
	db.lock.Unlock()
	return found
}

// AddBackoff lets other nodes know that we've entered backoff with
// peer p, so dialers should not wait unnecessarily. We still will
// attempt to dial with one goroutine, in case we get through.
func (db *dialbackoff) AddBackoff(p peer.ID) {
	db.lock.Lock()
	db.init()
	db.entries[p] = struct{}{}
	db.lock.Unlock()
}

// Clear removes a backoff record. Clients should call this after a
// successful Dial.
func (db *dialbackoff) Clear(p peer.ID) {
	db.lock.Lock()
	db.init()
	delete(db.entries, p)
	db.lock.Unlock()
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
187
188
189
190
191
192
193
// Dial connects to a peer.
//
// The idea is that the client of Swarm does not need to know what network
// the connection will happen over. Swarm can use whichever it choses.
// This allows us to use various transport protocols, do NAT traversal/relay,
// etc. to achive connection.
func (s *Swarm) Dial(ctx context.Context, p peer.ID) (*Conn, error) {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
194
	var logdial = lgbl.Dial("swarm", s.LocalPeer(), p, nil, nil)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
195
	if p == s.local {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
196
197
		log.Event(ctx, "swarmDialSelf", logdial)
		return nil, ErrDialToSelf
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
198
199
	}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
200
201
	return s.gatedDialAttempt(ctx, p)
}
202

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
203
204
205
206
207
208
209
210
211
func (s *Swarm) bestConnectionToPeer(p peer.ID) *Conn {
	cs := s.ConnectionsToPeer(p)
	for _, conn := range cs {
		if conn != nil { // dump out the first one we find. (TODO pick better)
			return conn
		}
	}
	return nil
}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
212

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
213
214
215
216
217
// gatedDialAttempt is an attempt to dial a node. It is gated by the swarm's
// dial synchronization systems: dialsync and dialbackoff.
func (s *Swarm) gatedDialAttempt(ctx context.Context, p peer.ID) (*Conn, error) {
	var logdial = lgbl.Dial("swarm", s.LocalPeer(), p, nil, nil)
	defer log.EventBegin(ctx, "swarmDialAttemptSync", logdial).Done()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
218

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
219
220
221
222
223
	// check if we already have an open connection first
	conn := s.bestConnectionToPeer(p)
	if conn != nil {
		return conn, nil
	}
224

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
225
226
	// check if there's an ongoing dial to this peer
	if ok, wait := s.dsync.Lock(p); ok {
227
		// ok, we have been charged to dial! let's do it.
228
		// if it succeeds, dial will add the conn to the swarm itself.
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
229
230

		defer log.EventBegin(ctx, "swarmDialAttemptStart", logdial).Done()
231
		ctxT, cancel := context.WithTimeout(ctx, s.dialT)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
232
		conn, err := s.dial(ctxT, p)
233
		cancel()
234
		s.dsync.Unlock(p)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
235
		log.Debugf("dial end %s", conn)
236
		if err != nil {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
237
			log.Event(ctx, "swarmDialBackoffAdd", logdial)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
238
239
			s.backf.AddBackoff(p) // let others know to backoff

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
240
			return nil, ErrDialFailed // ok, we failed. try again. (if loop is done, our error is output)
241
		}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
242
		log.Event(ctx, "swarmDialBackoffClear", logdial)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
243
		s.backf.Clear(p) // okay, no longer need to backoff
244
		return conn, nil
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267

	} else {
		// we did not dial. we must wait for someone else to dial.

		// check whether we should backoff first...
		if s.backf.Backoff(p) {
			log.Event(ctx, "swarmDialBackoff", logdial)
			return nil, ErrDialBackoff
		}

		defer log.EventBegin(ctx, "swarmDialWait", logdial).Done()
		select {
		case <-wait: // wait for that other dial to finish.

			// see if it worked, OR we got an incoming dial in the meantime...
			conn := s.bestConnectionToPeer(p)
			if conn != nil {
				return conn, nil
			}
			return nil, ErrDialFailed
		case <-ctx.Done(): // or we may have to bail...
			return nil, ctx.Err()
		}
268
269
270
271
272
	}
}

// dial is the actual swarm's dial logic, gated by Dial.
func (s *Swarm) dial(ctx context.Context, p peer.ID) (*Conn, error) {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
273
	var logdial = lgbl.Dial("swarm", s.LocalPeer(), p, nil, nil)
274
	if p == s.local {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
275
276
		log.Event(ctx, "swarmDialDoDialSelf", logdial)
		return nil, ErrDialToSelf
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
277
	}
278
279
	defer log.EventBegin(ctx, "swarmDialDo", logdial).Done()
	logdial["dial"] = "failure" // start off with failure. set to "success" at the end.
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
280
281

	sk := s.peers.PrivKey(s.local)
282
	logdial["encrypted"] = (sk != nil) // log wether this will be an encrypted dial or not.
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
283
	if sk == nil {
284
		// fine for sk to be nil, just log.
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
285
		log.Debug("Dial not given PrivateKey, so WILL NOT SECURE conn.")
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
286
287
	}

288
289
290
291
	// get our own addrs. try dialing out from our listener addresses (reusing ports)
	// Note that using our peerstore's addresses here is incorrect, as that would
	// include observed addresses. TODO: make peerstore's address book smarter.
	localAddrs := s.ListenAddresses()
292
293
294
295
296
	if len(localAddrs) == 0 {
		log.Debug("Dialing out with no local addresses.")
	}

	// get remote peer addrs
297
	remoteAddrs := s.peers.Addrs(p)
298
	// make sure we can use the addresses.
299
	remoteAddrs = addrutil.FilterUsableAddrs(remoteAddrs)
300
301
	// drop out any addrs that would just dial ourselves. use ListenAddresses
	// as that is a more authoritative view than localAddrs.
302
	ila, _ := s.InterfaceListenAddresses()
303
	remoteAddrs = addrutil.Subtract(remoteAddrs, ila)
304
	remoteAddrs = addrutil.Subtract(remoteAddrs, s.peers.Addrs(s.local))
305
	log.Debugf("%s swarm dialing %s -- local:%s remote:%s", s.local, p, s.ListenAddresses(), remoteAddrs)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
306
	if len(remoteAddrs) == 0 {
307
308
309
		err := errors.New("peer has no addresses")
		logdial["error"] = err
		return nil, err
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
310
311
312
313
	}

	// open connection to peer
	d := &conn.Dialer{
314
315
		Dialer: manet.Dialer{
			Dialer: net.Dialer{
316
				Timeout: s.dialT,
317
318
			},
		},
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
319
320
321
		LocalPeer:  s.local,
		LocalAddrs: localAddrs,
		PrivateKey: sk,
Jeromy's avatar
Jeromy committed
322
323
324
		Wrapper: func(c manet.Conn) manet.Conn {
			return mconn.WrapConn(s.bwc, c)
		},
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
325
326
	}

327
328
	// try to get a connection to any addr
	connC, err := s.dialAddrs(ctx, d, p, remoteAddrs)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
329
	if err != nil {
330
		logdial["error"] = err
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
331
332
		return nil, err
	}
333
	logdial["netconn"] = lgbl.NetConn(connC)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
334
335

	// ok try to setup the new connection.
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
336
	defer log.EventBegin(ctx, "swarmDialDoSetup", logdial, lgbl.NetConn(connC)).Done()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
337
338
	swarmC, err := dialConnSetup(ctx, s, connC)
	if err != nil {
339
		logdial["error"] = err
340
		connC.Close() // close the connection. didn't work out :(
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
341
342
343
		return nil, err
	}

344
	logdial["dial"] = "success"
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
345
346
347
	return swarmC, nil
}

348
349
350
func (s *Swarm) dialAddrs(ctx context.Context, d *conn.Dialer, p peer.ID, remoteAddrs []ma.Multiaddr) (conn.Conn, error) {

	// try to connect to one of the peer's known addresses.
351
352
353
354
	// we dial concurrently to each of the addresses, which:
	// * makes the process faster overall
	// * attempts to get the fastest connection available.
	// * mitigates the waste of trying bad addresses
355
	log.Debugf("%s swarm dialing %s %s", s.local, p, remoteAddrs)
356
357
358
359
360
361
362
363

	ctx, cancel := context.WithCancel(ctx)
	defer cancel() // cancel work when we exit func

	foundConn := make(chan struct{})
	conns := make(chan conn.Conn, len(remoteAddrs))
	errs := make(chan error, len(remoteAddrs))

364
365
366
	// dialSingleAddr is used in the rate-limited async thing below.
	dialSingleAddr := func(addr ma.Multiaddr) {
		connC, err := s.dialAddr(ctx, d, p, addr)
367

368
369
370
371
372
		// check parent still wants our results
		select {
		case <-foundConn:
			if connC != nil {
				connC.Close()
373
			}
374
375
376
			return
		default:
		}
377

378
379
380
381
382
383
384
		if err != nil {
			errs <- err
		} else if connC == nil {
			errs <- fmt.Errorf("failed to dial %s %s", p, addr)
		} else {
			conns <- connC
		}
385
	}
386

387
388
389
390
	// this whole thing is in a goroutine so we can use foundConn
	// to end early.
	go func() {
		// rate limiting just in case. at most 10 addrs at once.
391
		limiter := ratelimit.NewRateLimiter(process.Background(), 10)
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
		limiter.Go(func(worker process.Process) {
			// permute addrs so we try different sets first each time.
			for _, i := range rand.Perm(len(remoteAddrs)) {
				select {
				case <-foundConn: // if one of them succeeded already
					break
				case <-worker.Closing(): // our context was cancelled
					break
				default:
				}

				workerAddr := remoteAddrs[i] // shadow variable to avoid race
				limiter.LimitedGo(func(worker process.Process) {
					dialSingleAddr(workerAddr)
				})
407
			}
408
		})
409
410
411

		<-ctx.Done()
		limiter.Close()
412
413
414
415
	}()

	// wair fot the results.
	exitErr := fmt.Errorf("failed to dial %s", p)
416
417
	for i := 0; i < len(remoteAddrs); i++ {
		select {
418
419
		case exitErr = <-errs: //
			log.Debug(exitErr)
420
421
422
423
424
		case connC := <-conns:
			// take the first + return asap
			close(foundConn)
			return connC, nil
		}
425
	}
426
	return nil, exitErr
427
428
429
430
431
432
}

func (s *Swarm) dialAddr(ctx context.Context, d *conn.Dialer, p peer.ID, addr ma.Multiaddr) (conn.Conn, error) {
	log.Debugf("%s swarm dialing %s %s", s.local, p, addr)

	connC, err := d.Dial(ctx, addr, p)
433
	if err != nil {
434
		return nil, fmt.Errorf("%s --> %s dial attempt failed: %s", s.local, p, err)
435
	}
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453

	// if the connection is not to whom we thought it would be...
	remotep := connC.RemotePeer()
	if remotep != p {
		connC.Close()
		return nil, fmt.Errorf("misdial to %s through %s (got %s)", p, addr, remotep)
	}

	// if the connection is to ourselves...
	// this can happen TONS when Loopback addrs are advertized.
	// (this should be caught by two checks above, but let's just make sure.)
	if remotep == s.local {
		connC.Close()
		return nil, fmt.Errorf("misdial to %s through %s (got self)", p, addr)
	}

	// success! we got one!
	return connC, nil
454
455
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
456
457
458
459
460
461
462
463
464
465
466
467
468
// dialConnSetup is the setup logic for a connection from the dial side. it
// needs to add the Conn to the StreamSwarm, then run newConnSetup
func dialConnSetup(ctx context.Context, s *Swarm, connC conn.Conn) (*Conn, error) {

	psC, err := s.swarm.AddConn(connC)
	if err != nil {
		// connC is closed by caller if we fail.
		return nil, fmt.Errorf("failed to add conn to ps.Swarm: %s", err)
	}

	// ok try to setup the new connection. (newConnSetup will add to group)
	swarmC, err := s.newConnSetup(ctx, psC)
	if err != nil {
469
		psC.Close() // we need to make sure psC is Closed.
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
470
471
472
473
474
		return nil, err
	}

	return swarmC, err
}