GitLab

This reverts commit aca83b9b, reversing
changes made to 86b8929d.

This was is not the correct fix. We already expose these addresses via the
host's AllAddrs method. The real problem is probably that we just don't ever
tell anyone about them (unless we disconnect and reconnect to our nearby DHT
nodes).

We need an address gossip protocol.

related to #383

I won't call this *fixed* yet but it should help.

(counting open connections requires copying)

Also, make the libp2p constructor fully useful. There should now be no need to
manually construct a swarm/host.

It is source of most warning noise in Warning channel and we would like
to enable warning channel some time in future by default

There's really no reason to *only* do this if we have relays enabled. Doing it
this way makes `go vet` happier and reduces conditional logic.

The legacy interface stays unchanged with a panic though.

There were previously 4 different ways of passing various options
into BasicHost construction.

1. Function parameters to New
2. Option parameters to New
3. Global variables, e.g. NegotiateTimeout
4. Options struct, in the calling code in go-ipfs

This changeset deprecated all of these, and introduces the HostOpts
struct to replace them. It also introduces a new constructor called
NewHost, which accepts a *HostOpts.

The old New constructor continues to work the same way,
but is from now on deprecated too.