- 21 Oct, 2015 3 commits
-
-
Marc Cornellà authored
We need to use POSIX syntax. This file is no longer executed with zsh. Fixes #4483.
-
Marc Cornellà authored
Drops the `function` keyword and uses only `func(){}` syntax as per the POSIX specification: http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_09_05 Related: #4531
-
Marc Cornellà authored
This reverts commit c9d93757, which makes it fail with a syntax error: sh: 1: Syntax error: "(" unexpected
-
- 20 Oct, 2015 1 commit
-
-
Brian J Brennan authored
This changeset wraps all of the commands in tools/install.sh in a function and then calls that function as the last line of the script. The current install instructions ask the user to download the install script using `curl` and pass the result to `sh`. This is totally fine (as long as both the instructions and the script itself are served using HTTPS), but the script should be written in a way such that it doesn't start trying to actually *do* anything until the very last line. The reason is due to the way `curl` work: if the socket drops before the request is complete (server abruptly hangs up, client's internet flakes out, etc.), `curl` will return the partial data that it received. Here is an example of that: ![partial file execution](https://cldup.com/qU_Mnh2GmT.png) A way this might cause issues for tools/install.sh is if the connection drops after cloning but before the repository (L53-56). The .zshrc configuration will not be copied and the shell will not be changed, but if the user tries to run the install script again it will claim oh-my-zsh is already installed (L31-39). While this is not a particularly dangerous error condition (the user can just delete .oh-my-zsh and re-run), it can certainly be confusing for new users. This also helps future-proof the script for a time when it might need to use a "dangerous" command, e.g. `rm`, and we want to make sure it happens in the most transactional way possible.
-
- 16 Oct, 2015 2 commits
-
-
Yannick Eckey authored
@fcrozat's original fix assumes `which` not to output anything to STDOUT in case the command is not found. That is not necessarily true on all systems. A better solution is to check the return value instead. Fixes #4376
-
Arvind Chembarpu authored
-
- 05 Oct, 2015 1 commit
-
-
Rodrigo Chiossi authored
Prompt the user before removing oh-my-zsh from the system
-
- 28 Sep, 2015 1 commit
-
-
Andrew Janke authored
This is a hack to keep the installer working on systems without tput/terminfo.
-
- 22 Sep, 2015 1 commit
-
-
Frederic Crozat authored
-
- 21 Sep, 2015 1 commit
-
-
Frederic Crozat authored
Fixes issue #4376
-
- 03 Sep, 2015 1 commit
-
-
Andrew Janke authored
* Balk at incompatible Windows/MSYS git * Test for chsh presence before trying to use it * Replace non-portable `[[ ... ]]` and `[ x = *pattern* ]` constructs
-
- 27 Aug, 2015 1 commit
-
-
Andrew Janke authored
-
- 16 Aug, 2015 1 commit
-
-
Felix Krause authored
-
- 12 Aug, 2015 1 commit
-
-
Chang Hyun Park authored
Check if Zsh is installed before installing anything else. New-commers, or people who don't read the disclaimers(ex. me) will go straight to stack overflow if chsh -s returns an error.
-
- 20 Jul, 2015 2 commits
-
-
leycec authored
Installation previously assumed the existence of a "chsh" command in the current ${PATH}. Since Cygwin does *NOT* provide this command, installation now tests for the existence of this command before attempting to run it.
-
leycec authored
For safety, a umask of 022 prohibiting both group and other writability is now enforced during OMZ installation. In theory, this should reduce the likelihood of subsequent compinit() failures due to insecure directory permissions under all platforms except for default Cygwin installations (in which Windows ACLs override POSIX umasks).
-
- 07 Jul, 2015 1 commit
-
-
Andrew Janke authored
Do not use terminal visual effects if not connected to a terminal.
-
- 06 Jul, 2015 1 commit
-
-
Andrew Janke authored
-
- 10 Jun, 2015 1 commit
-
-
HeroCC authored
-
- 05 May, 2015 1 commit
-
-
Pablo Tamarit authored
fix test for chsh in install in case $SHELL is zsh but not the last one in /etc/shells fixes #3026 fixes #3779 fixes #3780
-
- 20 Feb, 2015 1 commit
-
-
Andrew Janke authored
install.sh: Replace nonstandard "sed -i" with sed + mv commands. Makes portable to systems whose sed lacks "-i", like OpenBSD.
-
- 14 Jan, 2015 1 commit
-
-
Nicholas T. authored
Use `--depth=1` to clone just the lastest version rather than every version in git.
-
- 15 Dec, 2014 1 commit
-
-
Mark Feltner authored
Reverts #2296, but mostly #1883. There is no need to source ~/.profile when this script is read. oh-my-zsh writes no configuration data in ~/.profile. If the user wishes to use data within ~/.profile, then they should source it in another place. Fixes #2315
-
- 28 Nov, 2014 1 commit
-
-
mizabrik authored
-
- 14 Oct, 2014 1 commit
-
-
Moinak Ghosh authored
-
- 17 Sep, 2014 1 commit
-
-
Moinak Ghosh authored
-
- 16 Sep, 2014 1 commit
-
-
Moinak Ghosh authored
-
- 31 Aug, 2014 2 commits
-
-
Robby Russell authored
-
Robby Russell authored
-
- 21 Aug, 2014 1 commit
-
-
Mathieu Comandon authored
-
- 20 Aug, 2014 1 commit
-
-
Fredrik Fornwall authored
Some environments (such as Android) does not have /usr/bin.
-
- 11 Jul, 2014 1 commit
-
-
Moinak Ghosh authored
-
- 04 Jun, 2014 1 commit
-
-
n.st authored
from #2360
-
- 24 May, 2014 2 commits
-
-
Mark Feltner authored
Reverts #2296, but mostly #1883. There is no need to source ~/.profile when this script is read. oh-my-zsh writes no configuration data in ~/.profile. If the user wishes to use data within ~/.profile, then they should source it in another place. Fixes #2315
-
Adam Luikart authored
-
- 30 Mar, 2014 1 commit
-
-
Henrik Holm authored
The intention of the redirection to /dev/null is to hide the output 'hash: no such command: git' since we rely on the exit status. However, the output goes to stderr, so it's stderr that needs to be redirected. For completeness, we redirect both stderr and stdout using '2>&1'. Example: [~]$ hash git > /dev/null [~]$ PATH='' [~]$ hash git > /dev/null hash: no such command: git [~]$ hash git > /dev/null 2>&1 [~]$
-
- 13 Mar, 2014 1 commit
-
-
Robby Russell authored
Fixing a few quirks in the latest installer updates (quoting /Users/robbyrussell/.oh-my-zsh and such). Also mentioining our twitter account after install
-
- 08 Mar, 2014 3 commits
-
-
Andrew Vit authored
-
Andrew Vit authored
-
Andrew Vit authored
-