1. 21 Oct, 2015 3 commits
  2. 20 Oct, 2015 1 commit
    • Brian J Brennan's avatar
      Make install script safer · c9d93757
      Brian J Brennan authored
      This changeset wraps all of the commands in tools/install.sh in a
      function and then calls that function as the last line of the
      script.
      
      The current install instructions ask the user to download the install
      script using `curl` and pass the result to `sh`. This is totally
      fine (as long as both the instructions and the script itself are served
      using HTTPS), but the script should be written in a way such that it
      doesn't start trying to actually *do* anything until the very last line.
      
      The reason is due to the way `curl` work: if the socket drops before the
      request is complete (server abruptly hangs up, client's internet flakes
      out, etc.), `curl` will return the partial data that it received. Here
      is an example of that:
      
      ![partial file execution](https://cldup.com/qU_Mnh2GmT.png)
      
      A way this might cause issues for tools/install.sh is if the connection drops
      after cloning but before the repository (L53-56). The .zshrc
      configuration will not be copied and the shell will not be changed, but
      if the user tries to run the install script again it will claim
      oh-my-zsh is already installed (L31-39).
      
      While this is not a particularly dangerous error condition (the user can
      just delete .oh-my-zsh and re-run), it can certainly be confusing for
      new users. This also helps future-proof the script for a time when it
      might need to use a "dangerous" command, e.g. `rm`, and we want to make
      sure it happens in the most transactional way possible.
      c9d93757
  3. 16 Oct, 2015 2 commits
  4. 05 Oct, 2015 1 commit
  5. 28 Sep, 2015 1 commit
  6. 22 Sep, 2015 1 commit
  7. 21 Sep, 2015 1 commit
  8. 03 Sep, 2015 1 commit
    • Andrew Janke's avatar
      Add Cygwin support to installer. · 502f08b5
      Andrew Janke authored
      * Balk at incompatible Windows/MSYS git
      * Test for chsh presence before trying to use it
      * Replace non-portable `[[ ... ]]` and `[ x = *pattern* ]` constructs
      502f08b5
  9. 27 Aug, 2015 1 commit
  10. 16 Aug, 2015 1 commit
  11. 12 Aug, 2015 1 commit
  12. 20 Jul, 2015 2 commits
    • leycec's avatar
      Cygwin-specific "chsh" installation issue fixed. · e8caf22b
      leycec authored
      Installation previously assumed the existence of a "chsh" command in the current
      ${PATH}. Since Cygwin does *NOT* provide this command, installation now tests
      for the existence of this command before attempting to run it.
      e8caf22b
    • leycec's avatar
      Secure umask enforced during installation. · da395c58
      leycec authored
      For safety, a umask of 022 prohibiting both group and other writability is now
      enforced during OMZ installation. In theory, this should reduce the likelihood
      of subsequent compinit() failures due to insecure directory permissions under
      all platforms except for default Cygwin installations (in which Windows ACLs
      override POSIX umasks).
      da395c58
  13. 07 Jul, 2015 1 commit
  14. 06 Jul, 2015 1 commit
  15. 10 Jun, 2015 1 commit
  16. 05 May, 2015 1 commit
  17. 20 Feb, 2015 1 commit
  18. 14 Jan, 2015 1 commit
  19. 15 Dec, 2014 1 commit
    • Mark Feltner's avatar
      fix(tools/check_for_upgrade): Don't source profile · 83553597
      Mark Feltner authored
      Reverts #2296, but mostly #1883.
      
      There is no need to source ~/.profile when this script is read. oh-my-zsh writes no configuration data in ~/.profile.
      
      If the user wishes to use data within ~/.profile, then they should source it in another place.
      
      Fixes #2315
      83553597
  20. 28 Nov, 2014 1 commit
  21. 14 Oct, 2014 1 commit
  22. 17 Sep, 2014 1 commit
  23. 16 Sep, 2014 1 commit
  24. 31 Aug, 2014 2 commits
  25. 21 Aug, 2014 1 commit
  26. 20 Aug, 2014 1 commit
  27. 11 Jul, 2014 1 commit
  28. 04 Jun, 2014 1 commit
  29. 24 May, 2014 2 commits
  30. 30 Mar, 2014 1 commit
    • Henrik Holm's avatar
      Correct redirection of output from 'hash' · f46d06da
      Henrik Holm authored
      The intention of the redirection to /dev/null is to hide the output
      'hash: no such command: git' since we rely on the exit status.
      
      However, the output goes to stderr, so it's stderr that needs to be
      redirected. For completeness, we redirect both stderr and stdout using
      '2>&1'.
      
      Example:
      
        [~]$ hash git > /dev/null
        [~]$ PATH=''
        [~]$ hash git > /dev/null
        hash: no such command: git
        [~]$ hash git > /dev/null 2>&1
        [~]$
      f46d06da
  31. 13 Mar, 2014 1 commit
  32. 08 Mar, 2014 3 commits