- 03 Jun, 2019 16 commits
-
-
Marc Cornellà authored
Co-authored-by: Marshall Ford <inbox@marshallford.me> Co-authored-by: Joel Kuzmarski <leoj3n@gmail.com>
-
Andrew Janke authored
-
Marc Cornellà authored
Supposed to be POSIX-compatible. Proved to work in dash, yash and whatever alpine uses. See https://unix.stackexchange.com/a/371873
-
Marc Cornellà authored
-
Andrew Janke authored
This facilitates testing of changes to the core installation code: you'll be able to do a roundtrip test of install and uninstall using the working code on your branch. Controlled by passing $REPO and $BRANCH environment variables to install.sh.
-
Marc Cornellà authored
This changes the behavior to default to the binary found first in $PATH, then checking it's actually in the shells file (/etc/shells). If that fails go back to the previous behavior, but actually check that the path obtained exists in the filesystem. Co-authored-by: Joel Kuzmarski <leoj3n@gmail.com>
-
Fran authored
Co-authored-by: Fredrik Fornwall <fredrik@fornwall.net>
-
Marc Cornellà authored
Guard clauses are if constructs that return early if there is an error that prevents continuing. This way there isn't a big nesting of if expressions.
-
Raf Czlonka authored
Otherwise we risk a situation where a full path to `zsh` is commented, i.e.: #/usr/local/bin/zsh
-
Luca S authored
This replaces the currently running process with the new one using `exec` instead of creating a new process. This way, when the user `exit`s out of the new shell it will not pop them back into the shell from which ohmyzsh was installed from.
-
Marc Cornellà authored
-
Marc Cornellà authored
-
Marc Cornellà authored
-
Marc Cornellà authored
-
Marc Cornellà authored
This will allow us to use tab stripping heredocs with `<<-'. See http://www.tldp.org/LDP/abs/html/here-docs.html#EX71A Add editorconfig file to enforce this style. See http://editorconfig.org for more information.
-
Marc Cornellà authored
-
- 18 Apr, 2019 1 commit
-
-
Guillermo Azurdia authored
-
- 26 Feb, 2019 1 commit
-
-
Robby Russell authored
* Updating Oh My Zsh shop URLs Linking directly to the Oh My Zsh inventory vs the top-level store with non-OMZ items. * Updating link to Oh My Zsh products in the install script * Updating link to Oh My Zsh shop products in the upgrade script * Getting rid of 't-' in shirts for now
-
- 15 Jan, 2019 1 commit
-
-
Jackson Delahunt authored
Fixes #7492
-
- 01 Jul, 2018 1 commit
-
-
Joel Kuzmarski authored
Otherwise these files are not sourced: 1. /etc/zprofile 2. ~/.zprofile 3. /etc/zlogin 4. ~/.zlogin 5. ~/.zlogout 6. /etc/zlogout
-
- 13 Jun, 2018 1 commit
-
-
Dan Wallis authored
Quote $ZSH where necessary in install script
-
- 06 May, 2018 1 commit
-
-
ningwei1993 authored
-
- 05 May, 2018 1 commit
-
-
Marc Cornellà authored
Fixes #4955 Closes #5931 Closes #6398 Co-authored-by: Void <vst4rbot@gmail.com> Co-authored-by: Kaleb Elwert <belak@coded.io>
-
- 17 Apr, 2018 1 commit
-
-
Marc Cornellà authored
Quick fix to the script not finding git due to hash. Solves #6697.
-
- 01 Nov, 2017 1 commit
-
-
Doug Yun authored
-
- 16 Jun, 2016 1 commit
-
-
Felipe Vargas authored
See robbyrussell@b67961d
-
- 30 May, 2016 1 commit
-
-
Andrew Janke authored
-
- 21 Oct, 2015 2 commits
-
-
Marc Cornellà authored
Drops the `function` keyword and uses only `func(){}` syntax as per the POSIX specification: http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_09_05 Related: #4531
-
Marc Cornellà authored
This reverts commit c9d93757, which makes it fail with a syntax error: sh: 1: Syntax error: "(" unexpected
-
- 20 Oct, 2015 1 commit
-
-
Brian J Brennan authored
This changeset wraps all of the commands in tools/install.sh in a function and then calls that function as the last line of the script. The current install instructions ask the user to download the install script using `curl` and pass the result to `sh`. This is totally fine (as long as both the instructions and the script itself are served using HTTPS), but the script should be written in a way such that it doesn't start trying to actually *do* anything until the very last line. The reason is due to the way `curl` work: if the socket drops before the request is complete (server abruptly hangs up, client's internet flakes out, etc.), `curl` will return the partial data that it received. Here is an example of that: ![partial file execution](https://cldup.com/qU_Mnh2GmT.png) A way this might cause issues for tools/install.sh is if the connection drops after cloning but before the repository (L53-56). The .zshrc configuration will not be copied and the shell will not be changed, but if the user tries to run the install script again it will claim oh-my-zsh is already installed (L31-39). While this is not a particularly dangerous error condition (the user can just delete .oh-my-zsh and re-run), it can certainly be confusing for new users. This also helps future-proof the script for a time when it might need to use a "dangerous" command, e.g. `rm`, and we want to make sure it happens in the most transactional way possible.
-
- 16 Oct, 2015 1 commit
-
-
Yannick Eckey authored
@fcrozat's original fix assumes `which` not to output anything to STDOUT in case the command is not found. That is not necessarily true on all systems. A better solution is to check the return value instead. Fixes #4376
-
- 28 Sep, 2015 1 commit
-
-
Andrew Janke authored
This is a hack to keep the installer working on systems without tput/terminfo.
-
- 21 Sep, 2015 1 commit
-
-
Frederic Crozat authored
Fixes issue #4376
-
- 03 Sep, 2015 1 commit
-
-
Andrew Janke authored
* Balk at incompatible Windows/MSYS git * Test for chsh presence before trying to use it * Replace non-portable `[[ ... ]]` and `[ x = *pattern* ]` constructs
-
- 27 Aug, 2015 1 commit
-
-
Andrew Janke authored
-
- 12 Aug, 2015 1 commit
-
-
Chang Hyun Park authored
Check if Zsh is installed before installing anything else. New-commers, or people who don't read the disclaimers(ex. me) will go straight to stack overflow if chsh -s returns an error.
-
- 20 Jul, 2015 2 commits
-
-
leycec authored
Installation previously assumed the existence of a "chsh" command in the current ${PATH}. Since Cygwin does *NOT* provide this command, installation now tests for the existence of this command before attempting to run it.
-
leycec authored
For safety, a umask of 022 prohibiting both group and other writability is now enforced during OMZ installation. In theory, this should reduce the likelihood of subsequent compinit() failures due to insecure directory permissions under all platforms except for default Cygwin installations (in which Windows ACLs override POSIX umasks).
-
- 07 Jul, 2015 1 commit
-
-
Andrew Janke authored
Do not use terminal visual effects if not connected to a terminal.
-
- 06 Jul, 2015 1 commit
-
-
Andrew Janke authored
-