1. 08 Sep, 2019 1 commit
  2. 09 Jun, 2019 1 commit
  3. 03 Jun, 2019 24 commits
  4. 18 Apr, 2019 1 commit
  5. 26 Feb, 2019 1 commit
    • Robby Russell's avatar
      Updating Oh My Zsh shop URLs (#7619) · f319aa84
      Robby Russell authored
      * Updating Oh My Zsh shop URLs
      
      Linking directly to the Oh My Zsh inventory vs the top-level store with non-OMZ items.
      
      * Updating link to Oh My Zsh products in the install script
      
      * Updating link to Oh My Zsh shop products in the upgrade script
      
      * Getting rid of 't-' in shirts for now
      f319aa84
  6. 15 Jan, 2019 1 commit
  7. 01 Jul, 2018 1 commit
  8. 13 Jun, 2018 1 commit
  9. 06 May, 2018 1 commit
  10. 05 May, 2018 1 commit
  11. 17 Apr, 2018 1 commit
  12. 01 Nov, 2017 1 commit
  13. 16 Jun, 2016 1 commit
  14. 30 May, 2016 1 commit
  15. 21 Oct, 2015 2 commits
  16. 20 Oct, 2015 1 commit
    • Brian J Brennan's avatar
      Make install script safer · c9d93757
      Brian J Brennan authored
      This changeset wraps all of the commands in tools/install.sh in a
      function and then calls that function as the last line of the
      script.
      
      The current install instructions ask the user to download the install
      script using `curl` and pass the result to `sh`. This is totally
      fine (as long as both the instructions and the script itself are served
      using HTTPS), but the script should be written in a way such that it
      doesn't start trying to actually *do* anything until the very last line.
      
      The reason is due to the way `curl` work: if the socket drops before the
      request is complete (server abruptly hangs up, client's internet flakes
      out, etc.), `curl` will return the partial data that it received. Here
      is an example of that:
      
      ![partial file execution](https://cldup.com/qU_Mnh2GmT.png)
      
      A way this might cause issues for tools/install.sh is if the connection drops
      after cloning but before the repository (L53-56). The .zshrc
      configuration will not be copied and the shell will not be changed, but
      if the user tries to run the install script again it will claim
      oh-my-zsh is already installed (L31-39).
      
      While this is not a particularly dangerous error condition (the user can
      just delete .oh-my-zsh and re-run), it can certainly be confusing for
      new users. This also helps future-proof the script for a time when it
      might need to use a "dangerous" command, e.g. `rm`, and we want to make
      sure it happens in the most transactional way possible.
      c9d93757