1. 04 Mar, 2026 11 commits
  2. 03 Mar, 2026 26 commits
  3. 02 Mar, 2026 3 commits
    • erio's avatar
      fix: remove unused sanitizeCustomMenuItemsJSON function · 451a8511
      erio authored
      
      
      Replaced by filterUserVisibleMenuItems which includes both array
      validation and admin-item filtering.
      Co-Authored-By: default avatarClaude Opus 4.6 <noreply@anthropic.com>
      451a8511
    • erio's avatar
      fix: security hardening and architectural improvements for custom menu · e97c3766
      erio authored
      
      
      1. (Critical) Filter admin-only menu items from public API responses -
         both GetPublicSettings handler and GetPublicSettingsForInjection now
         exclude visibility=admin items, preventing unauthorized access to
         admin menu URLs.
      
      2. (Medium) Validate JSON array structure in sanitizeCustomMenuItemsJSON -
         use json.Unmarshal into []json.RawMessage instead of json.Valid to
         reject non-array JSON values that would cause frontend runtime errors.
      
      3. (Medium) Decouple router from business JSON parsing - move origin
         extraction logic from router.go to SettingService.GetFrameSrcOrigins,
         eliminating direct JSON parsing of custom_menu_items in the routing
         layer.
      
      4. (Low) Restrict custom menu item ID charset to [a-zA-Z0-9_-] via
         regex validation, preventing route-breaking characters like / ? # or
         spaces.
      
      5. (Low) Handle crypto/rand error in generateMenuItemID - return error
         instead of silently ignoring, preventing potential duplicate IDs.
      Co-Authored-By: default avatarClaude Opus 4.6 <noreply@anthropic.com>
      e97c3766
    • erio's avatar
      style: fix gofmt alignment in setting_service.go · 7541e243
      erio authored
      7541e243