Commit 2271cb05 authored by Jonathan Wright's avatar Jonathan Wright
Browse files

psci: initialize array fully to comply with MISRA



Initializes each element of the last_cpu_in_non_cpu_pd array in PSCI
stat implementation to -1, the reset value. This satisfies MISRA rule
9.3.

Previously, only the first element of the array was initialized to -1.

Change-Id: I666c71e6c073710c67c6d24c07a219b1feb5b773
Signed-off-by: default avatarJonathan Wright <jonathan.wright@arm.com>
parent b7229e49
...@@ -24,7 +24,8 @@ typedef struct psci_stat { ...@@ -24,7 +24,8 @@ typedef struct psci_stat {
* Following is used to keep track of the last cpu * Following is used to keep track of the last cpu
* that goes to power down in non cpu power domains. * that goes to power down in non cpu power domains.
*/ */
static int last_cpu_in_non_cpu_pd[PSCI_NUM_NON_CPU_PWR_DOMAINS] = {-1}; static int last_cpu_in_non_cpu_pd[PSCI_NUM_NON_CPU_PWR_DOMAINS] = {
[0 ... PSCI_NUM_NON_CPU_PWR_DOMAINS-1] = -1};
/* /*
* Following are used to store PSCI STAT values for * Following are used to store PSCI STAT values for
...@@ -129,6 +130,10 @@ void psci_stats_update_pwr_up(unsigned int end_pwrlvl, ...@@ -129,6 +130,10 @@ void psci_stats_update_pwr_up(unsigned int end_pwrlvl,
* prior to this CPU powering on. * prior to this CPU powering on.
*/ */
parent_idx = psci_cpu_pd_nodes[cpu_idx].parent_node; parent_idx = psci_cpu_pd_nodes[cpu_idx].parent_node;
/* Return early if this is the first power up. */
if (last_cpu_in_non_cpu_pd[parent_idx] == -1)
return;
for (lvl = PSCI_CPU_PWR_LVL + 1; lvl <= end_pwrlvl; lvl++) { for (lvl = PSCI_CPU_PWR_LVL + 1; lvl <= end_pwrlvl; lvl++) {
local_state = state_info->pwr_domain_state[lvl]; local_state = state_info->pwr_domain_state[lvl];
if (is_local_state_run(local_state)) { if (is_local_state_run(local_state)) {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment