Commit 3adf6012 authored by Madhukar Pappireddy's avatar Madhukar Pappireddy Committed by TrustedFirmware Code Review
Browse files

Merge changes I19e4e7f5,I226b6e33 into integration

* changes:
  marvell: uart: a3720: Fix macro name for 6th bit of Status Register
  marvell: uart: a3720: Implement console_a3700_core_getc
parents 43d97fae b8e637f4
...@@ -60,14 +60,14 @@ func console_a3700_core_init ...@@ -60,14 +60,14 @@ func console_a3700_core_init
str w3, [x0, #UART_POSSR_REG] str w3, [x0, #UART_POSSR_REG]
/* /*
* Wait for the TX FIFO to be empty. If wait for 20ms, the TX FIFO is * Wait for the TX (THR and TSR) to be empty. If wait for 20ms, the TX FIFO is
* still not empty, TX FIFO will reset by all means. * still not empty, TX FIFO will reset by all means.
*/ */
mov w1, #20 /* max time out 20ms */ mov w1, #20 /* max time out 20ms */
2: 2:
/* Check whether TX FIFO is empty */ /* Check whether TX (THR and TSR) is empty */
ldr w3, [x0, #UART_STATUS_REG] ldr w3, [x0, #UART_STATUS_REG]
and w3, w3, #UARTLSR_TXFIFOEMPTY and w3, w3, #UARTLSR_TXEMPTY
cmp w3, #0 cmp w3, #0
b.ne 4f b.ne 4f
...@@ -196,14 +196,23 @@ endfunc console_a3700_putc ...@@ -196,14 +196,23 @@ endfunc console_a3700_putc
* int console_a3700_core_getc(void) * int console_a3700_core_getc(void)
* Function to get a character from the console. * Function to get a character from the console.
* It returns the character grabbed on success * It returns the character grabbed on success
* or -1 on error. * or -1 if no character is available.
* In : w0 - console base address * In : w0 - console base address
* Out : return -1 on error else return character. * Out : w0 - character if available, else -1
* Clobber list : x0, x1 * Clobber list : x0, x1
* --------------------------------------------- * ---------------------------------------------
*/ */
func console_a3700_core_getc func console_a3700_core_getc
mov w0, #-1 /* Check if there is a pending character */
ldr w1, [x0, #UART_STATUS_REG]
and w1, w1, #UARTLSR_RXRDY
cmp w1, #UARTLSR_RXRDY
b.ne getc_no_char
ldr w0, [x0, #UART_RX_REG]
and w0, w0, #0xff
ret
getc_no_char:
mov w0, #ERROR_NO_PENDING_CHAR
ret ret
endfunc console_a3700_core_getc endfunc console_a3700_core_getc
...@@ -232,10 +241,10 @@ endfunc console_a3700_getc ...@@ -232,10 +241,10 @@ endfunc console_a3700_getc
* --------------------------------------------- * ---------------------------------------------
*/ */
func console_a3700_core_flush func console_a3700_core_flush
/* Wait for the TX FIFO to be empty */ /* Wait for the TX (THR and TSR) to be empty */
1: ldr w1, [x0, #UART_STATUS_REG] 1: ldr w1, [x0, #UART_STATUS_REG]
and w1, w1, #UARTLSR_TXFIFOEMPTY and w1, w1, #UARTLSR_TXEMPTY
cmp w1, #UARTLSR_TXFIFOEMPTY cmp w1, #UARTLSR_TXEMPTY
b.ne 1b b.ne 1b
ret ret
endfunc console_a3700_core_flush endfunc console_a3700_core_flush
......
...@@ -48,11 +48,12 @@ ...@@ -48,11 +48,12 @@
/* Line Status Register bits */ /* Line Status Register bits */
#define UARTLSR_TXFIFOFULL (1 << 11) /* Tx Fifo Full */ #define UARTLSR_TXFIFOFULL (1 << 11) /* Tx Fifo Full */
#define UARTLSR_TXEMPTY (1 << 6) /* Tx Empty */
#define UARTLSR_RXRDY (1 << 4) /* Rx Ready */
/* UART Control Register bits */ /* UART Control Register bits */
#define UART_CTRL_RXFIFO_RESET (1 << 14) #define UART_CTRL_RXFIFO_RESET (1 << 14)
#define UART_CTRL_TXFIFO_RESET (1 << 15) #define UART_CTRL_TXFIFO_RESET (1 << 15)
#define UARTLSR_TXFIFOEMPTY (1 << 6)
#ifndef __ASSEMBLER__ #ifndef __ASSEMBLER__
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment