Unverified Commit 693e278e authored by davidcunado-arm's avatar davidcunado-arm Committed by GitHub
Browse files

Merge pull request #1245 from antonio-nino-diaz-arm/an/checkpatch

Analyze coding style of patches individually
parents 9bc94a6d 51d28937
No related merge requests found
Showing with 17 additions and 3 deletions
+17 -3
# #
# Copyright (c) 2016, ARM Limited and Contributors. All rights reserved. # Copyright (c) 2016-2018, ARM Limited and Contributors. All rights reserved.
# #
# Redistribution and use in source and binary forms, with or without # Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are met: # modification, are permitted provided that the following conditions are met:
...@@ -48,6 +48,10 @@ ...@@ -48,6 +48,10 @@
# drivers/arm/gic/arm_gic.c:160: # drivers/arm/gic/arm_gic.c:160:
--showfile --showfile
# Don't show some messages like the list of ignored types or the suggestion to
# use "--fix" or report changes to the maintainers.
--quiet
# #
# Ignore the following message types, as they don't necessarily make sense in # Ignore the following message types, as they don't necessarily make sense in
# the context of the Trusted Firmware. # the context of the Trusted Firmware.
...@@ -78,6 +82,9 @@ ...@@ -78,6 +82,9 @@
# We allow adding new typedefs in TF. # We allow adding new typedefs in TF.
--ignore NEW_TYPEDEFS --ignore NEW_TYPEDEFS
# Avoid "Does not appear to be a unified-diff format patch" message
--ignore NOT_UNIFIED_DIFF
# VOLATILE reports this kind of messages: # VOLATILE reports this kind of messages:
# "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt" # "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt"
# We allow the usage of the volatile keyword in TF. # We allow the usage of the volatile keyword in TF.
......
# #
# Copyright (c) 2013-2017, ARM Limited and Contributors. All rights reserved. # Copyright (c) 2013-2018, ARM Limited and Contributors. All rights reserved.
# #
# SPDX-License-Identifier: BSD-3-Clause # SPDX-License-Identifier: BSD-3-Clause
# #
...@@ -680,7 +680,14 @@ checkcodebase: locate-checkpatch ...@@ -680,7 +680,14 @@ checkcodebase: locate-checkpatch
checkpatch: locate-checkpatch checkpatch: locate-checkpatch
@echo " CHECKING STYLE" @echo " CHECKING STYLE"
${Q}git format-patch --stdout ${BASE_COMMIT}..HEAD -- ${CHECK_PATHS} | ${CHECKPATCH} - || true ${Q}COMMON_COMMIT=$$(git merge-base HEAD ${BASE_COMMIT}); \
for commit in `git rev-list $$COMMON_COMMIT..HEAD`; do \
printf "\n[*] Checking style of '$$commit'\n\n"; \
git log --format=email "$$commit~..$$commit" \
-- ${CHECK_PATHS} | ${CHECKPATCH} - || true; \
git diff --format=email "$$commit~..$$commit" \
-- ${CHECK_PATHS} | ${CHECKPATCH} - || true; \
done
certtool: ${CRTTOOL} certtool: ${CRTTOOL}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment