Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
Menu
Open sidebar
adam.huang
Arm Trusted Firmware
Commits
693e278e
Unverified
Commit
693e278e
authored
Feb 01, 2018
by
davidcunado-arm
Committed by
GitHub
Feb 01, 2018
Browse files
Merge pull request #1245 from antonio-nino-diaz-arm/an/checkpatch
Analyze coding style of patches individually
parents
9bc94a6d
51d28937
Changes
2
Hide whitespace changes
Inline
Side-by-side
.checkpatch.conf
View file @
693e278e
#
# Copyright (c) 2016, ARM Limited and Contributors. All rights reserved.
# Copyright (c) 2016
-2018
, ARM Limited and Contributors. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are met:
...
...
@@ -48,6 +48,10 @@
# drivers/arm/gic/arm_gic.c:160:
--
showfile
# Don't show some messages like the list of ignored types or the suggestion to
# use "--fix" or report changes to the maintainers.
--
quiet
#
# Ignore the following message types, as they don't necessarily make sense in
# the context of the Trusted Firmware.
...
...
@@ -78,6 +82,9 @@
# We allow adding new typedefs in TF.
--
ignore
NEW_TYPEDEFS
# Avoid "Does not appear to be a unified-diff format patch" message
--
ignore
NOT_UNIFIED_DIFF
# VOLATILE reports this kind of messages:
# "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt"
# We allow the usage of the volatile keyword in TF.
...
...
Makefile
View file @
693e278e
#
# Copyright (c) 2013-201
7
, ARM Limited and Contributors. All rights reserved.
# Copyright (c) 2013-201
8
, ARM Limited and Contributors. All rights reserved.
#
# SPDX-License-Identifier: BSD-3-Clause
#
...
...
@@ -680,7 +680,14 @@ checkcodebase: locate-checkpatch
checkpatch
:
locate-checkpatch
@
echo
" CHECKING STYLE"
${Q}
git format-patch
--stdout
${BASE_COMMIT}
..HEAD
--
${CHECK_PATHS}
|
${CHECKPATCH}
-
||
true
${Q}COMMON_COMMIT
=
$$
(
git merge-base HEAD
${BASE_COMMIT}
)
;
\
for
commit
in
`
git rev-list
$$
COMMON_COMMIT..HEAD
`
;
do
\
printf
"
\n
[*] Checking style of '
$$
commit'
\n\n
"
;
\
git log
--format
=
email
"
$$
commit~..
$$
commit"
\
--
${CHECK_PATHS}
|
${CHECKPATCH}
-
||
true
;
\
git diff
--format
=
email
"
$$
commit~..
$$
commit"
\
--
${CHECK_PATHS}
|
${CHECKPATCH}
-
||
true
;
\
done
certtool
:
${CRTTOOL}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment