Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
Menu
Open sidebar
adam.huang
Arm Trusted Firmware
Commits
92a7b0c3
Commit
92a7b0c3
authored
Apr 04, 2014
by
danh-arm
Browse files
Merge pull request #34 from danh-arm/dh/new-integration-process
Update contributing.md with new integration process
parents
2eb01d34
7b5bf5c6
Changes
1
Hide whitespace changes
Inline
Side-by-side
contributing.md
View file @
92a7b0c3
...
@@ -78,16 +78,24 @@ Submitting Changes
...
@@ -78,16 +78,24 @@ Submitting Changes
*
Ensure we have your signed CLA.
*
Ensure we have your signed CLA.
*
Push your local changes to your fork of the repository.
*
Push your local changes to your fork of the repository.
*
Submit a [pull request] to arm-trusted-firmware.
*
Submit a [pull request] to
the [
arm-trusted-firmware
]
`integration`
branch
.
*
The changes in the pull request will then undergo further review and
*
The changes in the
[
pull request
]
will then undergo further review and
testing. Any review comments will be made as comments on the [pull
testing. Any review comments will be made as comments on the [pull
request]. This may require you to do some rework.
request]. This may require you to do some rework.
*
When the changes are accepted, ARM will integrate them.
*
When the changes are accepted, ARM will integrate them.
*
To ensure a linear commit history, ARM will typically rebase the commits
*
Typically, ARM will merge the [pull request] into the
`integration`
locally before merging to the [arm-trusted-firmware]
`master`
branch. In
branch within the GitHub UI, creating a merge commit.
this case, the [pull request] will be closed rather than directly merged
*
Please avoid creating merge commits in the [pull request] itself.
on GitHub. If the rebase is not trivial, you may be asked to rebase the
*
If the [pull request] is not based on a recent commit, ARM may rebase
commits yourself.
it onto the
`master`
branch first, or ask you to do this.
*
If the [pull request] cannot be automatically merged, ARM will ask you
to rebase it onto the
`master`
branch.
*
After final integration testing, ARM will push your merge commit to the
`master`
branch. If a problem is found at this stage, the merge commit
will be removed from the
`integration`
branch and ARM will ask you to
create a new pull request to resolve the problem.
*
Please do not delete your topic branch until it is safely merged into
the
`master`
branch.
- - - - - - - - - - - - - - - - - - - - - - - - - -
- - - - - - - - - - - - - - - - - - - - - - - - - -
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment