Commit a14988c6 authored by Jimmy Brisson's avatar Jimmy Brisson
Browse files

Move static vars into functions in bl1



This reduces the scope of these variables and resolves Misra violations
such as:
    bl1/aarch64/bl1_context_mgmt.c:21:[MISRA C-2012 Rule 8.9 (advisory)]
    "bl1_cpu_context" should be defined at block scope.
Signed-off-by: default avatarJimmy Brisson <jimmy.brisson@arm.com>
Change-Id: I9b0b26395bce07e10e61d10158c67f9c22ecce44
parent 859df7d5
...@@ -14,12 +14,6 @@ ...@@ -14,12 +14,6 @@
#include "../bl1_private.h" #include "../bl1_private.h"
/*
* Following array will be used for context management.
* There are 2 instances, for the Secure and Non-Secure contexts.
*/
static cpu_context_t bl1_cpu_context[2];
/* Following contains the cpu context pointers. */ /* Following contains the cpu context pointers. */
static void *bl1_cpu_context_ptr[2]; static void *bl1_cpu_context_ptr[2];
...@@ -42,6 +36,13 @@ void cm_set_context(void *context, uint32_t security_state) ...@@ -42,6 +36,13 @@ void cm_set_context(void *context, uint32_t security_state)
******************************************************************************/ ******************************************************************************/
void bl1_prepare_next_image(unsigned int image_id) void bl1_prepare_next_image(unsigned int image_id)
{ {
/*
* Following array will be used for context management.
* There are 2 instances, for the Secure and Non-Secure contexts.
*/
static cpu_context_t bl1_cpu_context[2];
unsigned int security_state, mode = MODE_EL1; unsigned int security_state, mode = MODE_EL1;
image_desc_t *desc; image_desc_t *desc;
entry_point_info_t *next_bl_ep; entry_point_info_t *next_bl_ep;
......
...@@ -24,11 +24,6 @@ ...@@ -24,11 +24,6 @@
#include "bl1_private.h" #include "bl1_private.h"
/* BL1 Service UUID */
DEFINE_SVC_UUID2(bl1_svc_uid,
U(0xd46739fd), 0xcb72, 0x9a4d, 0xb5, 0x75,
0x67, 0x15, 0xd6, 0xf4, 0xbb, 0x4a);
static void bl1_load_bl2(void); static void bl1_load_bl2(void);
#if ENABLE_PAUTH #if ENABLE_PAUTH
...@@ -234,6 +229,11 @@ u_register_t bl1_smc_handler(unsigned int smc_fid, ...@@ -234,6 +229,11 @@ u_register_t bl1_smc_handler(unsigned int smc_fid,
void *handle, void *handle,
unsigned int flags) unsigned int flags)
{ {
/* BL1 Service UUID */
DEFINE_SVC_UUID2(bl1_svc_uid,
U(0xd46739fd), 0xcb72, 0x9a4d, 0xb5, 0x75,
0x67, 0x15, 0xd6, 0xf4, 0xbb, 0x4a);
#if TRUSTED_BOARD_BOOT #if TRUSTED_BOARD_BOOT
/* /*
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment