Commit dae695ab authored by dp-arm's avatar dp-arm
Browse files

Fix minor issues found by cppcheck



cppcheck highlighted variables that were initialized but then later
reassigned.

Change-Id: Ie12742c01fd3bf48b2d6c05a3b448da91d57a2e4
Signed-off-by: default avatardp-arm <dimitris.papastamos@arm.com>
parent 4d07e782
...@@ -95,7 +95,7 @@ static int sh_file_open(io_dev_info_t *dev_info __unused, ...@@ -95,7 +95,7 @@ static int sh_file_open(io_dev_info_t *dev_info __unused,
const uintptr_t spec, io_entity_t *entity) const uintptr_t spec, io_entity_t *entity)
{ {
int result = -ENOENT; int result = -ENOENT;
long sh_result = -1; long sh_result;
const io_file_spec_t *file_spec = (const io_file_spec_t *)spec; const io_file_spec_t *file_spec = (const io_file_spec_t *)spec;
assert(file_spec != NULL); assert(file_spec != NULL);
...@@ -151,7 +151,7 @@ static int sh_file_read(io_entity_t *entity, uintptr_t buffer, size_t length, ...@@ -151,7 +151,7 @@ static int sh_file_read(io_entity_t *entity, uintptr_t buffer, size_t length,
size_t *length_read) size_t *length_read)
{ {
int result = -ENOENT; int result = -ENOENT;
long sh_result = -1; long sh_result;
size_t bytes = length; size_t bytes = length;
long file_handle; long file_handle;
...@@ -176,7 +176,7 @@ static int sh_file_read(io_entity_t *entity, uintptr_t buffer, size_t length, ...@@ -176,7 +176,7 @@ static int sh_file_read(io_entity_t *entity, uintptr_t buffer, size_t length,
static int sh_file_write(io_entity_t *entity, const uintptr_t buffer, static int sh_file_write(io_entity_t *entity, const uintptr_t buffer,
size_t length, size_t *length_written) size_t length, size_t *length_written)
{ {
long sh_result = -1; long sh_result;
long file_handle; long file_handle;
size_t bytes = length; size_t bytes = length;
...@@ -197,7 +197,7 @@ static int sh_file_write(io_entity_t *entity, const uintptr_t buffer, ...@@ -197,7 +197,7 @@ static int sh_file_write(io_entity_t *entity, const uintptr_t buffer,
/* Close a file on the semi-hosting device */ /* Close a file on the semi-hosting device */
static int sh_file_close(io_entity_t *entity) static int sh_file_close(io_entity_t *entity)
{ {
long sh_result = -1; long sh_result;
long file_handle; long file_handle;
assert(entity != NULL); assert(entity != NULL);
......
...@@ -257,7 +257,7 @@ X509_EXTENSION *ext_new_nvcounter(int nid, int crit, int value) ...@@ -257,7 +257,7 @@ X509_EXTENSION *ext_new_nvcounter(int nid, int crit, int value)
X509_EXTENSION *ex = NULL; X509_EXTENSION *ex = NULL;
ASN1_INTEGER *counter = NULL; ASN1_INTEGER *counter = NULL;
unsigned char *p = NULL; unsigned char *p = NULL;
int sz = -1; int sz;
/* Encode counter */ /* Encode counter */
counter = ASN1_INTEGER_new(); counter = ASN1_INTEGER_new();
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment