Skip to content

GitLab

Switch branch/tag
  1. 02 Dec, 2020 2 commits
  3. 01 Dec, 2020 1 commit
  5. 30 Nov, 2020 2 commits
  7. 27 Nov, 2020 1 commit
  9. 24 Nov, 2020 1 commit
  11. 23 Nov, 2020 3 commits
  13. 20 Nov, 2020 3 commits
  15. 19 Nov, 2020 9 commits
  17. 18 Nov, 2020 1 commit
  19. 17 Nov, 2020 4 commits
  21. 13 Nov, 2020 1 commit
    • Alexei Fedorov's avatar
      TSP: Fix GCC 11.0.0 compilation error. · caff3c87
      Alexei Fedorov authored 
      

This patch fixes the following compilation error
reported by aarch64-none-elf-gcc 11.0.0:

bl32/tsp/tsp_main.c: In function 'tsp_smc_handler':
bl32/tsp/tsp_main.c:393:9: error: 'tsp_get_magic'
 accessing 32 bytes in a region of size 16
 [-Werror=stringop-overflow=]
  393 |         tsp_get_magic(service_args);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
bl32/tsp/tsp_main.c:393:9: note: referencing argument 1
 of type 'uint64_t *' {aka 'long long unsigned int *'}
In file included from bl32/tsp/tsp_main.c:19:
bl32/tsp/tsp_private.h:64:6: note: in a call to function 'tsp_get_magic'
   64 | void tsp_get_magic(uint64_t args[4]);
      |      ^~~~~~~~~~~~~

by changing declaration of tsp_get_magic function from
void tsp_get_magic(uint64_t args[4]);
to
uint128_t tsp_get_magic(void);
which returns arguments directly in x0 and x1 registers.

In bl32\tsp\tsp_main.c the current tsp_smc_handler()
implementation calls tsp_get_magic(service_args);
, where service_args array is declared as
uint64_t service_args[2];
and tsp_get_magic() in bl32\tsp\aarch64\tsp_request.S
copies only 2 registers in output buffer:
	/* Store returned arguments to the array */
	stp	x0, x1, [x4, #0]

Change-Id: Ib34759fc5d7bb803e6c734540d91ea278270b330
Signed-off-by: default avatarAlexei Fedorov <Alexei.Fedorov@arm.com>
      caff3c87
  23. 12 Nov, 2020 6 commits
  25. 09 Nov, 2020 2 commits
  27. 29 Oct, 2020 2 commits
    • Alexei Fedorov's avatar
      Merge "Use constant stack size with RECLAIM_INIT_CODE" into integration · 8109d2dd
      Alexei Fedorov authored
      8109d2dd
    • Manish Pandey's avatar
      Merge changes from topic "mbox-patches" into integration · 271708e0
      Manish Pandey authored 
      * changes:
  intel: common: Fix non-MISRA compliant code v2
  intel: mailbox: Fix non-MISRA compliant code
  intel: mailbox: Mailbox error recovery handling
  intel: mailbox: Enable sending large mailbox command
  intel: mailbox: Use retry count in mailbox poll
  intel: mailbox: Ensure time out duration is predictive
  intel: mailbox: Read mailbox response even there is an error
  intel: mailbox: Driver now handles larger response
  intel: common: Change how mailbox handles job id & buffer
  intel: common: Improve readability of mailbox read response
  intel: SIP: increase FPGA_CONFIG_SIZE to 32 MB
  intel: common: Remove urgent from mailbox async
  intel: common: Improve mailbox driver readability
      271708e0
  29. 28 Oct, 2020 2 commits
    • David Horstmann's avatar
      Use constant stack size with RECLAIM_INIT_CODE · 3ed5606b
      David Horstmann authored 
      

Currently, when RECLAIM_INIT_CODE is set, the
stacks are scaled to ensure that the entirety
of the init section can be reclaimed as stack.

This causes an issue in lib/psci/aarch64/psci_helpers.S,
where the stack size is used for cache operations in
psci_do_pwrdown_cache_maintenance(). If the stacks
are scaled, then the PSCI code may fail to invalidate
some of the stack memory before power down.

Resizing stacks is also not good for stability in general,
since code that works with a small number of cores may
overflow the stack when the number of cores is increased.

Change to make every stack be PLATFORM_STACK_SIZE big,
and allow the total stack to be smaller than the
init section.

Any pages of the init section not reclaimed as
stack will be set to read-only and execute-never,
for security.

Change-Id: I10b3884981006431f2fcbec3864c81d4a8c246e8
Signed-off-by: default avatarDavid Horstmann <david.horstmann@arm.com>
      3ed5606b
    • André Przywara's avatar
      Merge "aarch64/arm: Add compiler barrier to barrier instructions" into integration · fc860630
      André Przywara authored
      fc860630