1. 14 Sep, 2020 1 commit
    • Sami Mujawar's avatar
      Fix fiptool packaging issue on windows · cb5c08b6
      Sami Mujawar authored
      
      
      Windows does not have a standard getopt implementation. To address
      this an equivalent implementation has been provided in win_posix.c
      However, the implementation has an issue with option processing as
      described below.
      
      Long option names may be abbreviated if the abbreviation is unique
      or an exact match for some defined option.
      Since some options can be substring of other options e.g. "scp-fw"
      option is a substring of "scp-fwu-cfg", we need to identify if an
      option is abbreviated and also check for uniqueness. Otherwise if
      a user passes --scp-fw as an option, the "scp-fwu-cfg" option may
      get selected, resulting in an incorrectly packaged FIP.
      
      This issue has been be fixed by:
        - First searching for an exact match.
        - If exact match was not found search for a abbreviated match.
      By doing this an incorrect option selection can be avoided.
      
      Change-Id: I22f4e7a683f3df857f5b6f0783bf9b03a64a0bcc
      Signed-off-by: default avatarSami Mujawar <sami.mujawar@arm.com>
      cb5c08b6
  2. 10 Sep, 2020 4 commits
  3. 09 Sep, 2020 6 commits
  4. 08 Sep, 2020 2 commits
  5. 07 Sep, 2020 4 commits
    • joanna.farley's avatar
    • Max Shvetsov's avatar
      Fix: fixing coverity issue for SPM Core. · f7fb0bf7
      Max Shvetsov authored
      
      
      spmd_get_context_by_mpidr was using potentially negative value as an
      array index. plat_core_pos_by_mpidr could return -1 on failure which is
      utilized by some platforms.
      Signed-off-by: default avatarMax Shvetsov <maksims.svecovs@arm.com>
      Change-Id: I7f8827e77f18da389c9cafdc1fc841aba9f03120
      f7fb0bf7
    • Manish V Badarkhe's avatar
      plat: Fix build issue for qemu and rpi3 platforms · dad2934c
      Manish V Badarkhe authored
      
      
      Coverity build periodically throws below errors(non-consistently)
      for 'QEMU' and 'RPI3' platforms.
      
      /bin/sh: 1: cannot create build/qemu/debug/rot_key.pem: Directory
      nonexistent
      plat/qemu/qemu/platform.mk:86: recipe for target 'build/qemu/debug/
      rot_key.pem' failed
      make: *** [build/qemu/debug/rot_key.pem] Error 2
      
      /bin/sh: 1: cannot create /work/workspace/workspace/tf-coverity/build
      /rpi3/debug/rot_key.pem: Directory nonexistent
      plat/rpi/rpi3/platform.mk:214: recipe for target '/work/workspace/
      workspace/tf-coverity/build/rpi3/debug/rot_key.pem' failed
      make: *** [/work/workspace/workspace/tf-coverity/build/rpi3/debug/
      rot_key.pem] Error 2
      
      Issue seems to be occurred when 'ROT key' is generated before creating
      the platform build folder(for e.g.build/qemu/debug).
      
      Changes are made to fix this issue by adding orderly dependancy of
      the platform folder for the 'ROT key' creation which ensures that
      platform folder is created before generating 'ROT key'.
      Signed-off-by: default avatarManish V Badarkhe <Manish.Badarkhe@arm.com>
      Change-Id: I20c82172dde84e4c7f2373c0bd095d353f845d38
      dad2934c
    • Manish V Badarkhe's avatar
      tools: Set the tool's default binary name · b13e3f9f
      Manish V Badarkhe authored
      This patch: fafd3ec9
      
       assumes that tools must build from
      the main makefile folder.
      This assumption leads to the error when somebody wants to
      build a tool from the tool's folder.
      Hence changes are done to provide the default binary name
      in the tool's makefile.
      
      Change-Id: Iae570a7f8d322151376b6feb19e739300eecc3fc
      Signed-off-by: default avatarManish V Badarkhe <Manish.Badarkhe@arm.com>
      b13e3f9f
  6. 03 Sep, 2020 6 commits
  7. 02 Sep, 2020 10 commits
  8. 01 Sep, 2020 7 commits