1. 16 Aug, 2019 2 commits
  2. 15 Aug, 2019 1 commit
  3. 14 Aug, 2019 1 commit
  4. 13 Aug, 2019 2 commits
  5. 09 Aug, 2019 2 commits
    • Heiko Stuebner's avatar
      rockchip: rk3399: store actual debug uart information on suspend · 0eb7fa91
      Heiko Stuebner authored
      
      
      The rk3399 suspend code saves and restores the debug uart settings, but
      right now always does this for the default uart. Right now this works
      only by chance for the majority of rk3399 boards, which do not deviate
      from that default.
      
      But both Coreboot as well as U-Boot-based platforms can actually use
      different uarts for their output, which can be configured from either
      devicetree or Coreboot-variables.
      
      To fix this, just use the stored uart-base information instead of the
      default constant.
      Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
      Change-Id: I1ea059d59a1126f6f8702315df7e620e632b686e
      0eb7fa91
    • Heiko Stuebner's avatar
      rockchip: move dt-coreboot uart distinction into param handling code · dd4a0d16
      Heiko Stuebner authored
      
      
      Rockchip platforms can be booted from either u-boot or coreboot.
      
      So far the Coreboot-console was initizalized from a coreboot data struct
      in the early_param2 callbacks and dt-based consoles with data from the
      rockchip_get_uart_* functions.
      
      But later code may also need this console information for example for
      special suspend handling. To make this easy follow a suggestion from
      Julius Werner and move the coreboot<->dt distinction into the
      rockchip_get_uart_* functions, thus making correct data about the used
      uart available to all Rockchip platform code at all times.
      
      This includes a new rockchip_get_uart_clock as well, because while the
      dt-platforms right now always just default the rate defined in a constant
      Coreboot provides its own field for the clock rate and we don't want to
      loose that information for the console init. Similarly the rk_uart_*
      variables should move into the non-Coreboot code, to prevent them from
      being marked as unused, which also requires the rk_get_uart_* functions
      to move below the actual dt-parsing.
      Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
      Change-Id: I278d595d2aa6c6864187fc8979a9fbff9814feac
      dd4a0d16
  6. 07 Aug, 2019 1 commit
  7. 05 Aug, 2019 2 commits
    • Heiko Stuebner's avatar
      rockchip: make uart baudrate configurable · 30970e0f
      Heiko Stuebner authored
      
      
      A previous patch already allowed to configure the uart output from the
      devicetree, but on Rockchip platforms we also have the issue of different
      vendors using different baudrates for their uarts.
      
      For example, rk3399 has a default baudrate of 115200 which is true for
      ChromeOS-devices and boards from Theobroma-Systems, while all the boards
      using the vendor boot chain actually use a baudrate of 1500000.
      
      Similarly the newly added px30 has a default of said 1500000 but some
      boards may want to use the more widely used 115200.
      
      The devicetree stdout-path node already contains the desired baudrate,
      so add simple code to parse it from there and override the default,
      which stays unchanged.
      Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
      Change-Id: I7412139c3df3073a1996eb508ec08642ec6af90d
      30970e0f
    • Heiko Stuebner's avatar
      rockchip: px30: add uart5 as option for serial output · 5f441a7b
      Heiko Stuebner authored
      
      
      The px30 mini-evb can use either uart2 (muxed with the sd-card pins) or
      uart5 via its pin header for serial output. Uart5 is especially useful
      when needing to boot from the sd-card, where uart2 obviously is not
      useable.
      
      So add the uart5 constants and it as uart option for the serial-param
      handler.
      Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
      Change-Id: Ib88df7a55d761ee104d312c9953a13de3beba1c4
      5f441a7b
  8. 02 Aug, 2019 3 commits
    • Hadi Asyrafi's avatar
      intel: stratix10: Fix BL31 memory mapping · 600db4e3
      Hadi Asyrafi authored
      
      
      Previous config blocks ATF runtime service communications with SDM mailbox
      Signed-off-by: default avatarHadi Asyrafi <muhammad.hadi.asyrafi.abdul.halim@intel.com>
      Change-Id: Ia857facd0bd0790056df94ed1e016bcf619a161e
      600db4e3
    • Remi Pommarel's avatar
      meson: gxl: Fix CPU hotplug · b4694a86
      Remi Pommarel authored
      
      
      The CPU[1-3] are reset to initial/cold boot state (with their reset
      address set to 0x0). In this state the cpus are waiting for another
      one to set the reset address to bl31_warm_entrypoint and wake them up.
      
      The CPU0 needs a bit of a workaround as changing the reset address
      either through PSCI mailbox or the mmio mapped RVBAR (at 0xda834650)
      does not seem to have any effect. Thus the workaround consists in
      emulating the other CPUs' behavior with a WFE loop and manually jumping
      to bl31_warm_entrypoint when woken back up by another one.
      
      Change-Id: I11265620b5fd0619285e3993253a3f9a3ff6a7a4
      Signed-off-by: default avatarRemi Pommarel <repk@triplefau.lt>
      b4694a86
    • Remi Pommarel's avatar
      meson: gxl: Fix reset and power off · 43d4a291
      Remi Pommarel authored
      
      
      Before CPU enters standby state (wfi), the AP needs to signal the SCP
      through PSCI mailbox.
      
      Also at boot time the AP has to wait for the SCP to be ready before
      sending the first scpi commands or it can crash.
      
      Change-Id: Iacc99f5bec745ad71922c5ea07ca5b87088133b6
      Signed-off-by: default avatarRemi Pommarel <repk@triplefau.lt>
      43d4a291
  9. 01 Aug, 2019 3 commits
    • Julius Werner's avatar
      Switch AARCH32/AARCH64 to __aarch64__ · 402b3cf8
      Julius Werner authored
      
      
      NOTE: AARCH32/AARCH64 macros are now deprecated in favor of __aarch64__.
      
      All common C compilers pre-define the same macros to signal which
      architecture the code is being compiled for: __arm__ for AArch32 (or
      earlier versions) and __aarch64__ for AArch64. There's no need for TF-A
      to define its own custom macros for this. In order to unify code with
      the export headers (which use __aarch64__ to avoid another dependency),
      let's deprecate the AARCH32 and AARCH64 macros and switch the code base
      over to the pre-defined standard macro. (Since it is somewhat
      unintuitive that __arm__ only means AArch32, let's standardize on only
      using __aarch64__.)
      
      Change-Id: Ic77de4b052297d77f38fc95f95f65a8ee70cf200
      Signed-off-by: default avatarJulius Werner <jwerner@chromium.org>
      402b3cf8
    • Julius Werner's avatar
      Replace __ASSEMBLY__ with compiler-builtin __ASSEMBLER__ · d5dfdeb6
      Julius Werner authored
      
      
      NOTE: __ASSEMBLY__ macro is now deprecated in favor of __ASSEMBLER__.
      
      All common C compilers predefine a macro called __ASSEMBLER__ when
      preprocessing a .S file. There is no reason for TF-A to define it's own
      __ASSEMBLY__ macro for this purpose instead. To unify code with the
      export headers (which use __ASSEMBLER__ to avoid one extra dependency),
      let's deprecate __ASSEMBLY__ and switch the code base over to the
      predefined standard.
      
      Change-Id: Id7d0ec8cf330195da80499c68562b65cb5ab7417
      Signed-off-by: default avatarJulius Werner <jwerner@chromium.org>
      d5dfdeb6
    • Hadi Asyrafi's avatar
      intel: Platform common code refactor · d8820789
      Hadi Asyrafi authored
      
      
      Pull out common code from agilex and stratix10
      Signed-off-by: default avatarHadi Asyrafi <muhammad.hadi.asyrafi.abdul.halim@intel.com>
      Change-Id: Iddc0a9e6eccb30823d7b15615d5ce9c6bedb2abc
      d8820789
  10. 31 Jul, 2019 2 commits
  11. 30 Jul, 2019 1 commit
  12. 29 Jul, 2019 1 commit
  13. 26 Jul, 2019 2 commits
  14. 25 Jul, 2019 3 commits
    • Ambroise Vincent's avatar
      rockchip: px30: Fix build error · 8a079e88
      Ambroise Vincent authored
      "result of '1 << 31' requires 33 bits to represent, but 'int' only has
      32 bits [-Werror=shift-overflow=]"
      
      This is treated as an error since commit 93c690eb
      
       ("Enable
      -Wshift-overflow=2 to check for undefined shift behavior")
      
      Only the actual errors are being tackled by this patch. It is up to the
      platform to choose whether there needs to be further modifications to
      the code.
      
      Change-Id: I70860ae5f2a34d7c684bd491b76da50aa04f778e
      Signed-off-by: default avatarAmbroise Vincent <ambroise.vincent@arm.com>
      8a079e88
    • Madhukar Pappireddy's avatar
      sgm775: Fix build fail for TSP support on sgm775 · 425ace7d
      Madhukar Pappireddy authored
      
      
      Fixed the path to a source file specified in tsp makefile
      Created a platform specific tsp makefile
      
      Change-Id: I89565127c67eff510e48e21fd450af4c3088c2d4
      Signed-off-by: default avatarMadhukar Pappireddy <madhukar.pappireddy@arm.com>
      425ace7d
    • Gilad Ben-Yossef's avatar
      cryptocell: move Cryptocell specific API into driver · 36ec2bb0
      Gilad Ben-Yossef authored
      
      
      Code using Cryptocell specific APIs was used as part of the
      arm common board ROT support, instead of being abstracted
      in Cryptocell specific driver code, creating two problems:
      - Any none arm board that uses Cryptocell wuld need to
        copy and paste the same code.
      - Inability to cleanly support multiple versions of Cryptocell
        API and products.
      
      Move over Cryptocell specific API calls into the Cryptocell
      driver, creating abstraction API where needed.
      Signed-off-by: default avatarGilad Ben-Yossef <gilad.benyossef@arm.com>
      Change-Id: I9e03ddce90fcc47cfdc747098bece86dbd11c58e
      36ec2bb0
  15. 24 Jul, 2019 7 commits
    • Julius Werner's avatar
      plat/mediatek/mt81*: Use new bl31_params_parse() helper · cbdc72b5
      Julius Werner authored
      
      
      The Mediatek MT8173/MT8183 SoCs are prime candidates for switching to
      the new bl31_params_parse() helper, so switch them over. This will allow
      BL2 implementations on these platforms to transparently switch over to
      the version 2 parameter structure.
      
      Change-Id: I0d17ba6c455102d325a06503d2078a76d12b5deb
      Signed-off-by: default avatarJulius Werner <jwerner@chromium.org>
      cbdc72b5
    • Julius Werner's avatar
      plat/rockchip: Use new bl31_params_parse_helper() · 3e02c743
      Julius Werner authored
      
      
      The Rockchip platform is a prime candidate for switching to the new
      bl31_params_parse_helper(), so switch it over. This will allow BL2
      implementations on this platform to transparently switch over to the
      version 2 parameter structure.
      
      Change-Id: I540741d2425c93f66c8697ce749a351eb2b3a7e8
      Signed-off-by: default avatarJulius Werner <jwerner@chromium.org>
      3e02c743
    • Ambroise Vincent's avatar
      intel: agilex: Fix build error · 3bd24e72
      Ambroise Vincent authored
      "result of '1 << 31' requires 33 bits to represent, but 'int' only has
      32 bits [-Werror=shift-overflow=]"
      
      This is treated as an error since commit 93c690eb
      
       ("Enable
      -Wshift-overflow=2 to check for undefined shift behavior")
      
      Change-Id: I141827a6711ab7759bfd6357e4ed9c1176da7c7b
      Signed-off-by: default avatarAmbroise Vincent <ambroise.vincent@arm.com>
      3bd24e72
    • Julius Werner's avatar
      Factor out cross-BL API into export headers suitable for 3rd party code · 57bf6057
      Julius Werner authored
      
      
      This patch adds a new include/export/ directory meant for inclusion in
      third-party code. This is useful for cases where third-party code needs
      to interact with TF-A interfaces and data structures (such as a custom
      BL2-implementation like coreboot handing off to BL31). Directly
      including headers from the TF-A repository avoids having to duplicate
      all these definitions (and risk them going stale), but with the current
      header structure this is not possible because handoff API definitions
      are too deeply intertwined with other TF code/headers and chain-include
      other headers that will not be available in the other environment.
      
      The new approach aims to solve this by separating only the parts that
      are really needed into these special headers that are self-contained and
      will not chain-include other (non-export) headers. TF-A code should
      never include them directly but should instead always include the
      respective wrapper header, which will include the required prerequisites
      (like <stdint.h>) before including the export header. Third-party code
      can include the export headers via its own wrappers that make sure the
      necessary definitions are available in whatever way that environment can
      provide them.
      
      Change-Id: Ifd769320ba51371439a8e5dd5b79c2516c3b43ab
      Signed-off-by: default avatarJulius Werner <jwerner@chromium.org>
      57bf6057
    • Julius Werner's avatar
      Use explicit-width data types in AAPCS parameter structs · 9352be88
      Julius Werner authored
      
      
      It's not a good idea to use u_register_t for the members of
      aapcs64_params_t and aapcs32_params_t, since the width of that type
      always depends on the current execution environment. This would cause
      problems if e.g. we used this structure to set up the entry point of an
      AArch32 program from within an AArch64 program. (It doesn't seem like
      any code is doing that today, but it's probably still a good idea to
      write this defensively. Also, it helps with my next patch.)
      
      Change-Id: I12c04a85611f2b6702589f3362bea3e6a7c9f776
      Signed-off-by: default avatarJulius Werner <jwerner@chromium.org>
      9352be88
    • Julius Werner's avatar
      plat/rockchip: Switch to use new common BL aux parameter library · c1185ffd
      Julius Werner authored
      
      
      This patch changes all Rockchip platforms to use the new common BL aux
      parameter helpers. Since the parameter space is now cleanly split in
      generic and vendor-specific parameters and the COREBOOT_TABLE
      parameter is now generic, the parameter type number for that parameter
      has to change. Since it only affects coreboot which always builds TF as
      a submodule and includes its headers directly to get these constants,
      this should not cause any issues. In general, after this point, we
      should avoid changing already assigned parameter type numbers whenever
      possible.
      
      Change-Id: Ic99ddd1e91ff5e5fe212fa30c793a0b8394c9dad
      Signed-off-by: default avatarJulius Werner <jwerner@chromium.org>
      c1185ffd
    • Jacky Bai's avatar
      plat: imx8m: Add basic rdc module init driver · 3d660799
      Jacky Bai authored
      
      
      Add the basic support for RDC init/config driver,
      this module driver can be enhanced more if necessary.
      Signed-off-by: default avatarJacky Bai <ping.bai@nxp.com>
      Change-Id: I290dc378d0d85671435f9de46d5aa790b4e006c8
      3d660799
  16. 23 Jul, 2019 2 commits
    • Manoj Kumar's avatar
      n1sdp: fix DMC ECC enablement sequence in N1SDP platform · 7428bbf4
      Manoj Kumar authored
      
      
      The DMC-620 memory controllers in N1SDP platform has to be put
      into CONFIG state before writing to ERR0CTLR0 register to enable
      ECC.
      
      This patch fixes the sequence so that DMCs are set to CONFIG
      state before writing to ERR0CTLR0 register and moved back to
      READY state after writing.
      
      Change-Id: I1252f3ae0991603bb29234029cddb5fbf869c1b2
      Signed-off-by: default avatarManoj Kumar <manoj.kumar3@arm.com>
      7428bbf4
    • Ambroise Vincent's avatar
      arm: Shorten the Firmware Update (FWU) process · 37b70031
      Ambroise Vincent authored
      
      
      The watchdog is configured with a default value of 256 seconds in order
      to implement the Trusted Board Boot Requirements.
      
      For the FVP and Juno platforms, the FWU process relies on a watchdog
      reset. In order to automate the test of FWU, the length of this process
      needs to be as short as possible. Instead of waiting for those 4 minutes
      to have a reset by the watchdog, tell it to reset immediately.
      
      There are no side effects as the value of the watchdog's load register
      resets to 0xFFFFFFFF.
      
      Tested on Juno.
      
      Change-Id: Ib1aea80ceddc18ff1e0813a5b98dd141ba8a3ff2
      Signed-off-by: default avatarAmbroise Vincent <ambroise.vincent@arm.com>
      37b70031
  17. 17 Jul, 2019 3 commits
  18. 16 Jul, 2019 2 commits