Commit 83e6bbf5 authored by Juan Batiz-Benet's avatar Juan Batiz-Benet
Browse files

testing/ci: all env var checks now use new pkgs

Good thing, i checked one wrong, too!
parent 9f8999a8
...@@ -3,13 +3,14 @@ package conn ...@@ -3,13 +3,14 @@ package conn
import ( import (
"bytes" "bytes"
"fmt" "fmt"
"os"
"runtime" "runtime"
"sync" "sync"
"testing" "testing"
"time" "time"
context "github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context" context "github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context"
travis "github.com/jbenet/go-ipfs/util/testutil/ci/travis"
) )
func testOneSendRecv(t *testing.T, c1, c2 Conn) { func testOneSendRecv(t *testing.T, c1, c2 Conn) {
...@@ -62,7 +63,7 @@ func TestCloseLeak(t *testing.T) { ...@@ -62,7 +63,7 @@ func TestCloseLeak(t *testing.T) {
t.SkipNow() t.SkipNow()
} }
if os.Getenv("TRAVIS") == "true" { if travis.IsRunning() {
t.Skip("this doesn't work well on travis") t.Skip("this doesn't work well on travis")
} }
......
...@@ -2,13 +2,13 @@ package conn ...@@ -2,13 +2,13 @@ package conn
import ( import (
"bytes" "bytes"
"os"
"runtime" "runtime"
"sync" "sync"
"testing" "testing"
"time" "time"
ic "github.com/jbenet/go-ipfs/p2p/crypto" ic "github.com/jbenet/go-ipfs/p2p/crypto"
travis "github.com/jbenet/go-ipfs/util/testutil/ci/travis"
context "github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context" context "github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context"
) )
...@@ -131,7 +131,7 @@ func TestSecureCloseLeak(t *testing.T) { ...@@ -131,7 +131,7 @@ func TestSecureCloseLeak(t *testing.T) {
if testing.Short() { if testing.Short() {
t.SkipNow() t.SkipNow()
} }
if os.Getenv("TRAVIS") == "true" { if travis.IsRunning() {
t.Skip("this doesn't work well on travis") t.Skip("this doesn't work well on travis")
} }
......
...@@ -2,14 +2,16 @@ package swarm ...@@ -2,14 +2,16 @@ package swarm
import ( import (
"net" "net"
"os"
"sync" "sync"
"testing" "testing"
"time" "time"
addrutil "github.com/jbenet/go-ipfs/p2p/net/swarm/addr" addrutil "github.com/jbenet/go-ipfs/p2p/net/swarm/addr"
peer "github.com/jbenet/go-ipfs/p2p/peer" peer "github.com/jbenet/go-ipfs/p2p/peer"
testutil "github.com/jbenet/go-ipfs/util/testutil" testutil "github.com/jbenet/go-ipfs/util/testutil"
jenkins "github.com/jbenet/go-ipfs/util/testutil/ci/jenkins"
travis "github.com/jbenet/go-ipfs/util/testutil/ci/travis"
context "github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context" context "github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context"
ma "github.com/jbenet/go-ipfs/Godeps/_workspace/src/github.com/jbenet/go-multiaddr" ma "github.com/jbenet/go-ipfs/Godeps/_workspace/src/github.com/jbenet/go-multiaddr"
...@@ -114,7 +116,7 @@ func TestDialWait(t *testing.T) { ...@@ -114,7 +116,7 @@ func TestDialWait(t *testing.T) {
defer s1.Close() defer s1.Close()
s1.dialT = time.Millisecond * 300 // lower timeout for tests. s1.dialT = time.Millisecond * 300 // lower timeout for tests.
if os.Getenv("TRAVIS") == "true" { if travis.IsRunning() {
s1.dialT = time.Second s1.dialT = time.Second
} }
...@@ -148,8 +150,8 @@ func TestDialWait(t *testing.T) { ...@@ -148,8 +150,8 @@ func TestDialWait(t *testing.T) {
func TestDialBackoff(t *testing.T) { func TestDialBackoff(t *testing.T) {
// t.Skip("skipping for another test") // t.Skip("skipping for another test")
if os.Getenv("TRAVIS") == "true" { if travis.IsRunning() || jenkins.IsRunning() {
t.Skip("travis will never have fun with this test") t.Skip("travis and jenkins will never have fun with this test")
} }
t.Parallel() t.Parallel()
...@@ -375,7 +377,7 @@ func TestDialBackoffClears(t *testing.T) { ...@@ -375,7 +377,7 @@ func TestDialBackoffClears(t *testing.T) {
defer s2.Close() defer s2.Close()
s1.dialT = time.Millisecond * 300 // lower timeout for tests. s1.dialT = time.Millisecond * 300 // lower timeout for tests.
s2.dialT = time.Millisecond * 300 // lower timeout for tests. s2.dialT = time.Millisecond * 300 // lower timeout for tests.
if os.Getenv("TRAVIS") == "true" { if travis.IsRunning() {
s1.dialT = time.Second s1.dialT = time.Second
s2.dialT = time.Second s2.dialT = time.Second
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment