GitLab

That's what the Swarm does and that's what the function's documentation says it
does.

The swarm does this as well and most of our services will fail if we don't have
this.

This was probably failing (rarely) due to the fact that we're shrinking the
timeout asynchronously (I think?).

RandLocalTCPAddress is mostly useful when we *actually* want to listen on a real
address. Unfortunately, when running a bunch of tests, we can actually run
out.

With this change, a collision means we have a duplicate peer ID so yeah...

fixes #473

also check that we don't initially advertise any.

macosx seems to fail intermittently, and that race is the likely culprit.

This was causing https://github.com/ipfs/go-ipfs/pull/5637#issuecomment-432792969

Sending a protocol version is nice. However, this "disconnect if our versions
are different" logic makes the version entirely useless (because we can't change
it).

Really, each indevidual protocol is versioned so let's just leave it at that. If
we make a breaking change that requires a protocol bump, we can do that and
then switch on the other side's version. However, we'll have to wait for the
entire network to upgrade for that to work.