GitLab

This was causing https://github.com/ipfs/go-ipfs/pull/5637#issuecomment-432792969

Sending a protocol version is nice. However, this "disconnect if our versions
are different" logic makes the version entirely useless (because we can't change
it).

Really, each indevidual protocol is versioned so let's just leave it at that. If
we make a breaking change that requires a protocol bump, we can do that and
then switch on the other side's version. However, we'll have to wait for the
entire network to upgrade for that to work.

the first component must be P_P2P, or else we have a specific address to dial

- map internal -> []{external -> { observer -> [time, direction] } }
- some cleaning

Signed-off-by: gukq <gukaiqiang@gmail.com>

fixes #419

Also call FullClose in a goroutine; no need to block this.

(not happy with that but I'm starting to think we need to rethink stream
closing, again...)

(avoids the race condition)

This reverts commit aca83b9b, reversing
changes made to 86b8929d.

This was is not the correct fix. We already expose these addresses via the
host's AllAddrs method. The real problem is probably that we just don't ever
tell anyone about them (unless we disconnect and reconnect to our nearby DHT
nodes).

We need an address gossip protocol.

and regenerate protobuf files

related to #383

I won't call this *fixed* yet but it should help.

Currently, we leak a stream. We could use FullClose but, IMO, it's not worth it.
We might as well just reset and walk away.

This happens all the time in tests where we intentionally use fake keys for
performance.

Anyways, users probably don't want their logs spammed with errors they can't do
anything about.

(counting open connections requires copying)