Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
Menu
Open sidebar
adam.huang
htop
Commits
1afbc190
Commit
1afbc190
authored
Apr 22, 2014
by
Hisham Muhammad
Browse files
safer code, test for return of fcntl
parent
28d4cad5
Changes
1
Hide whitespace changes
Inline
Side-by-side
TraceScreen.c
View file @
1afbc190
...
...
@@ -87,9 +87,11 @@ void TraceScreen_run(TraceScreen* this) {
if
(
child
==
-
1
)
return
;
if
(
child
==
0
)
{
dup2
(
fdpair
[
1
],
STDERR_FILENO
);
fcntl
(
fdpair
[
1
],
F_SETFL
,
O_NONBLOCK
);
sprintf
(
buffer
,
"%d"
,
this
->
process
->
pid
);
execlp
(
"strace"
,
"strace"
,
"-p"
,
buffer
,
NULL
);
int
ok
=
fcntl
(
fdpair
[
1
],
F_SETFL
,
O_NONBLOCK
);
if
(
ok
!=
-
1
)
{
sprintf
(
buffer
,
"%d"
,
this
->
process
->
pid
);
execlp
(
"strace"
,
"strace"
,
"-p"
,
buffer
,
NULL
);
}
const
char
*
message
=
"Could not execute 'strace'. Please make sure it is available in your $PATH."
;
write
(
fdpair
[
1
],
message
,
strlen
(
message
));
exit
(
1
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment