Unverified Commit 7fa32bcc authored by Brian Norris's avatar Brian Norris Committed by Josh Boyer
Browse files

Makefile: improve `make check` usefulness



Silence the make echo'ing, so the output is cleaner.

Add an exit code to check_whence.py, so we can get a real failure for
bad WHENCE files.
Signed-off-by: default avatarBrian Norris <briannorris@chromium.org>
Signed-off-by: default avatarJosh Boyer <jwboyer@kernel.org>
parent 4bb6805b
...@@ -6,7 +6,7 @@ FIRMWAREDIR = /lib/firmware ...@@ -6,7 +6,7 @@ FIRMWAREDIR = /lib/firmware
all: all:
check: check:
./check_whence.py @./check_whence.py
install: install:
mkdir -p $(DESTDIR)$(FIRMWAREDIR) mkdir -p $(DESTDIR)$(FIRMWAREDIR)
......
...@@ -33,6 +33,7 @@ def list_git(): ...@@ -33,6 +33,7 @@ def list_git():
yield line.rstrip('\n') yield line.rstrip('\n')
def main(): def main():
ret = 0
whence_list = list(list_whence()) whence_list = list(list_whence())
known_files = set(name for name in whence_list if not name.endswith('/')) | \ known_files = set(name for name in whence_list if not name.endswith('/')) | \
set(['check_whence.py', 'configure', 'Makefile', set(['check_whence.py', 'configure', 'Makefile',
...@@ -42,6 +43,7 @@ def main(): ...@@ -42,6 +43,7 @@ def main():
for name in sorted(list(known_files - git_files)): for name in sorted(list(known_files - git_files)):
sys.stderr.write('E: %s listed in WHENCE does not exist\n' % name) sys.stderr.write('E: %s listed in WHENCE does not exist\n' % name)
ret = 1
for name in sorted(list(git_files - known_files)): for name in sorted(list(git_files - known_files)):
# Ignore subdirectory changelogs and GPG detached signatures # Ignore subdirectory changelogs and GPG detached signatures
...@@ -55,6 +57,8 @@ def main(): ...@@ -55,6 +57,8 @@ def main():
break break
else: else:
sys.stderr.write('E: %s not listed in WHENCE\n' % name) sys.stderr.write('E: %s not listed in WHENCE\n' % name)
ret = 1
return ret
if __name__ == '__main__': if __name__ == '__main__':
main() sys.exit(main())
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment