Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
Menu
Open sidebar
adam.huang
Oh My Zsh
Commits
bc2ccdd8
Commit
bc2ccdd8
authored
Oct 16, 2015
by
ncanceill
Committed by
Marc Cornellà
Mar 30, 2017
Browse files
contributing: improve PR section
parent
5a031ce3
Changes
1
Hide whitespace changes
Inline
Side-by-side
CONTRIBUTING.md
View file @
bc2ccdd8
...
...
@@ -72,11 +72,11 @@ _"Fixes #XXXX"_ for issue number XXXX.
### You have a solution
Please be so kind as to
[
search
](
#use-the-search-luke
)
for any open issue already covering
your
[
problem
](
#you-have-a-problem
)
, and any pending PR covering your solution.
your
[
problem
](
#you-have-a-problem
)
, and any pending
/merged/rejected
PR covering your solution.
If the solution is already reported, try it out and +1 the pull request if the
solution works ok. On the other hand, if you think your solution is better, post
it so we can have both solutions to compare.
it
with a reference to the other one
so we can have both solutions to compare.
If not, then go ahead and submit a PR. Please copy to anyone relevant (_eg_ plugin
maintainers) by mentioning their GitHub handle (starting with
`@`
) in your message.
...
...
@@ -86,7 +86,7 @@ maintainers) by mentioning their GitHub handle (starting with `@`) in your messa
Please
[
do not
](
https://github.com/robbyrussell/oh-my-zsh/wiki/Themes#dont-send-us-your-theme-for-now
)
send themes for now.
Please be so kind as to
[
search
](
#use-the-search-luke
)
for any pending PR covering or
Please be so kind as to
[
search
](
#use-the-search-luke
)
for any pending
/merged/rejected
PR covering or
related to what you want to add.
If you find one, try it out and work with the author on a common solution.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment