Commit 27228d83 authored by Michael Morgan's avatar Michael Morgan Committed by Marc Cornellà
Browse files

fasd: update `v` alias to evaluate $EDITOR lazily (#7900)

For the `v` alias to work in its current state, the environment variable
EDITOR must already be defined by the time `source $ZSH/oh-my-zsh.sh`
happens. However, in the included zshrc template, EDITOR is set from
within the "User configuration" section, which begins immediately after
the above line. This means that, unless the user knows to move their
`export EDITOR` statements, EDITOR will be undefined when fasd.plugin.zsh
loads, and therefore the alias will have the value 'f -e ""', preventing
it from functioning.

With this change, `"$EDITOR"` will be evaluated each time the alias is
invoked, instead of just once when the alias is created. This allows for
EDITOR to be set from "User configuration" in the zshrc, and has the
additional flexibility of allowing a user to specify a different EDITOR
for a single session or invocation of the alias.
parent 9930dd6e
...@@ -6,7 +6,7 @@ if [ $commands[fasd] ]; then # check if fasd is installed ...@@ -6,7 +6,7 @@ if [ $commands[fasd] ]; then # check if fasd is installed
source "$fasd_cache" source "$fasd_cache"
unset fasd_cache unset fasd_cache
alias v="f -e \"$EDITOR\"" alias v='f -e "$EDITOR"'
alias o='a -e xdg-open' alias o='a -e xdg-open'
alias j='zz' alias j='zz'
fi fi
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment