1. 20 Oct, 2015 6 commits
    • Brian J Brennan's avatar
      Make install script safer · c9d93757
      Brian J Brennan authored
      This changeset wraps all of the commands in tools/install.sh in a
      function and then calls that function as the last line of the
      script.
      
      The current install instructions ask the user to download the install
      script using `curl` and pass the result to `sh`. This is totally
      fine (as long as both the instructions and the script itself are served
      using HTTPS), but the script should be written in a way such that it
      doesn't start trying to actually *do* anything until the very last line.
      
      The reason is due to the way `curl` work: if the socket drops before the
      request is complete (server abruptly hangs up, client's internet flakes
      out, etc.), `curl` will return the partial data that it received. Here
      is an example of that:
      
      ![partial file execution](https://cldup.com/qU_Mnh2GmT.png)
      
      A way this might cause issues for tools/install.sh is if the connection drops
      after cloning but before the repository (L53-56). The .zshrc
      configuration will not be copied and the shell will not be changed, but
      if the user tries to run the install script again it will claim
      oh-my-zsh is already installed (L31-39).
      
      While this is not a particularly dangerous error condition (the user can
      just delete .oh-my-zsh and re-run), it can certainly be confusing for
      new users. This also helps future-proof the script for a time when it
      might need to use a "dangerous" command, e.g. `rm`, and we want to make
      sure it happens in the most transactional way possible.
      c9d93757
    • Marc Cornellà's avatar
      Merge pull request #4526 from sachin21/fix_typo · a7b4c093
      Marc Cornellà authored
      [FIX #4525]: Fix typo
      a7b4c093
    • Satoshi Ohmori's avatar
      [FIX #4525]: Fix typo · 2c8697b9
      Satoshi Ohmori authored
      2c8697b9
    • Marc Cornellà's avatar
      Merge pull request #4419 from apjanke/installer-termcap-hack · 8c73eb4f
      Marc Cornellà authored
      installer: ignore errors in color setup, for FreeBSD portability
      8c73eb4f
    • Marc Cornellà's avatar
      Merge pull request #4508 from Superbil/master · 45f0a280
      Marc Cornellà authored
      Fixd bug for pyenv plugin
      45f0a280
    • Marc Cornellà's avatar
      Merge pull request #4473 from apjanke/5_1_1-bracketed-paste-hack · 56345c26
      Marc Cornellà authored
      Disable bracketed-paste-magic in zsh 5.1.1, where it is buggy
      56345c26
  2. 19 Oct, 2015 1 commit
  3. 15 Oct, 2015 3 commits
  4. 14 Oct, 2015 3 commits
  5. 12 Oct, 2015 1 commit
  6. 10 Oct, 2015 5 commits
  7. 09 Oct, 2015 11 commits
  8. 08 Oct, 2015 1 commit
  9. 05 Oct, 2015 5 commits
  10. 04 Oct, 2015 3 commits
  11. 03 Oct, 2015 1 commit