Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
Menu
Open sidebar
adam.huang
Arm Trusted Firmware
Commits
55120f9c
Commit
55120f9c
authored
3 years ago
by
Bipin Ravi
Committed by
TrustedFirmware Code Review
3 years ago
Browse files
Options
Download
Plain Diff
Merge "errata: workaround for Neoverse V1 errata 1852267" into integration
parents
1d24eb33
143b1965
master
No related merge requests found
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
docs/design/cpu-specific-build-macros.rst
+4
-0
docs/design/cpu-specific-build-macros.rst
include/lib/cpus/aarch64/neoverse_v1.h
+1
-0
include/lib/cpus/aarch64/neoverse_v1.h
lib/cpus/aarch64/neoverse_v1.S
+34
-0
lib/cpus/aarch64/neoverse_v1.S
lib/cpus/cpu-ops.mk
+8
-0
lib/cpus/cpu-ops.mk
with
47 additions
and
0 deletions
+47
-0
docs/design/cpu-specific-build-macros.rst
View file @
55120f9c
...
...
@@ -333,6 +333,10 @@ For Neoverse V1, the following errata build flags are defined :
CPU. This needs to be enabled only for revisions r0p0 and r1p0, it is fixed
in r1p1.
- ``ERRATA_V1_1852267``: This applies errata 1852267 workaround to Neoverse-V1
CPU. This needs to be enabled only for revisions r0p0 and r1p0, it is fixed
in r1p1.
- ``ERRATA_V1_1940577``: This applies errata 1940577 workaround to Neoverse-V1
CPU. This needs to be enabled only for revision r1p0 and r1p1 of the
CPU.
...
...
This diff is collapsed.
Click to expand it.
include/lib/cpus/aarch64/neoverse_v1.h
View file @
55120f9c
...
...
@@ -26,5 +26,6 @@
******************************************************************************/
#define NEOVERSE_V1_ACTLR2_EL1 S3_0_C15_C1_1
#define NEOVERSE_V1_ACTLR2_EL1_BIT_2 (ULL(1) << 2)
#define NEOVERSE_V1_ACTLR2_EL1_BIT_28 (ULL(1) << 28)
#endif
/* NEOVERSE_V1_H */
This diff is collapsed.
Click to expand it.
lib/cpus/aarch64/neoverse_v1.S
View file @
55120f9c
...
...
@@ -77,6 +77,34 @@ func check_errata_1791573
b
cpu_rev_var_ls
endfunc
check_errata_1791573
/
*
--------------------------------------------------
*
Errata
Workaround
for
Neoverse
V1
Errata
#
1852267
.
*
This
applies
to
revisions
r0p0
and
r1p0
,
fixed
in
r1p1
.
*
x0
:
variant
[
4
:
7
]
and
revision
[
0
:
3
]
of
current
cpu
.
*
Shall
clobber
:
x0
-
x17
*
--------------------------------------------------
*/
func
errata_neoverse_v1_1852267_wa
/
*
Check
workaround
compatibility
.
*/
mov
x17
,
x30
bl
check_errata_1852267
cbz
x0
,
1
f
/
*
Set
bit
28
in
ACTLR2_EL1
*/
mrs
x1
,
NEOVERSE_V1_ACTLR2_EL1
orr
x1
,
x1
,
#
NEOVERSE_V1_ACTLR2_EL1_BIT_28
msr
NEOVERSE_V1_ACTLR2_EL1
,
x1
isb
1
:
ret
x17
endfunc
errata_neoverse_v1_1852267_wa
func
check_errata_1852267
/
*
Applies
to
r0p0
and
r1p0
.
*/
mov
x1
,
#
0x10
b
cpu_rev_var_ls
endfunc
check_errata_1852267
/
*
--------------------------------------------------
*
Errata
Workaround
for
Neoverse
V1
Erratum
#
1940577
*
This
applies
to
revisions
r1p0
-
r1p1
and
is
open
.
...
...
@@ -164,6 +192,7 @@ func neoverse_v1_errata_report
*/
report_errata
ERRATA_V1_1774420
,
neoverse_v1
,
1774420
report_errata
ERRATA_V1_1791573
,
neoverse_v1
,
1791573
report_errata
ERRATA_V1_1852267
,
neoverse_v1
,
1852267
report_errata
ERRATA_V1_1940577
,
neoverse_v1
,
1940577
ldp
x8
,
x30
,
[
sp
],
#
16
...
...
@@ -188,6 +217,11 @@ func neoverse_v1_reset_func
bl
errata_neoverse_v1_1791573_wa
#endif
#if ERRATA_V1_1852267
mov
x0
,
x18
bl
errata_neoverse_v1_1852267_wa
#endif
#if ERRATA_V1_1940577
mov
x0
,
x18
bl
errata_neoverse_v1_1940577_wa
...
...
This diff is collapsed.
Click to expand it.
lib/cpus/cpu-ops.mk
View file @
55120f9c
...
...
@@ -380,6 +380,10 @@ ERRATA_V1_1774420 ?=0
# to revisions r0p0 and r1p0 of the Neoverse V1 core, and was fixed in r1p1.
ERRATA_V1_1791573
?=
0
# Flag to apply erratum 1852267 workaround during reset. This erratum applies
# to revisions r0p0 and r1p0 of the Neoverse V1 core, and was fixed in r1p1.
ERRATA_V1_1852267
?=
0
# Flag to apply erratum 1940577 workaround during reset. This erratum applies
# to revisions r1p0 and r1p1 of the Neoverse V1 cpu.
ERRATA_V1_1940577
?=
0
...
...
@@ -697,6 +701,10 @@ $(eval $(call add_define,ERRATA_V1_1774420))
$(eval
$(call
assert_boolean,ERRATA_V1_1791573))
$(eval
$(call
add_define,ERRATA_V1_1791573))
# Process ERRATA_V1_1852267 flag
$(eval
$(call
assert_boolean,ERRATA_V1_1852267))
$(eval
$(call
add_define,ERRATA_V1_1852267))
# Process ERRATA_V1_1940577 flag
$(eval
$(call
assert_boolean,ERRATA_V1_1940577))
$(eval
$(call
add_define,ERRATA_V1_1940577))
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment
Menu
Projects
Groups
Snippets
Help