Unverified Commit b79239db authored by Soby Mathew's avatar Soby Mathew Committed by GitHub
Browse files

Merge pull request #1879 from pbeesley-arm/pb/todo-removal

Pb/todo removal
Showing with 0 additions and 11 deletions
+0 -11
...@@ -85,7 +85,6 @@ static inline int compare_uuids(const uuid_t *uuid1, const uuid_t *uuid2) ...@@ -85,7 +85,6 @@ static inline int compare_uuids(const uuid_t *uuid1, const uuid_t *uuid2)
} }
/* TODO: We could check version numbers or do a package checksum? */
static inline int is_valid_header(fip_toc_header_t *header) static inline int is_valid_header(fip_toc_header_t *header)
{ {
if ((header->name == TOC_HEADER_NAME) && (header->serial_number != 0)) { if ((header->name == TOC_HEADER_NAME) && (header->serial_number != 0)) {
......
...@@ -189,9 +189,6 @@ int io_dev_init(uintptr_t dev_handle, const uintptr_t init_params) ...@@ -189,9 +189,6 @@ int io_dev_init(uintptr_t dev_handle, const uintptr_t init_params)
return result; return result;
} }
/* TODO: Consider whether an explicit "shutdown" API should be included */
/* Close a connection to a device */ /* Close a connection to a device */
int io_dev_close(uintptr_t dev_handle) int io_dev_close(uintptr_t dev_handle)
{ {
......
...@@ -79,8 +79,6 @@ int io_dev_open(const struct io_dev_connector *dev_con, ...@@ -79,8 +79,6 @@ int io_dev_open(const struct io_dev_connector *dev_con,
* re-initialisation */ * re-initialisation */
int io_dev_init(uintptr_t dev_handle, const uintptr_t init_params); int io_dev_init(uintptr_t dev_handle, const uintptr_t init_params);
/* TODO: Consider whether an explicit "shutdown" API should be included */
/* Close a connection to a device */ /* Close a connection to a device */
int io_dev_close(uintptr_t dev_handle); int io_dev_close(uintptr_t dev_handle);
......
...@@ -19,10 +19,6 @@ ...@@ -19,10 +19,6 @@
#include "tbbr/tbb_ext.h" #include "tbbr/tbb_ext.h"
#include "tbbr/tbb_key.h" #include "tbbr/tbb_key.h"
/* TODO: get these values from the command line */
#define TRUSTED_WORLD_NVCTR_VALUE 0
#define NORMAL_WORLD_NVCTR_VALUE 0
static ext_t tbb_ext[] = { static ext_t tbb_ext[] = {
[TRUSTED_FW_NVCOUNTER_EXT] = { [TRUSTED_FW_NVCOUNTER_EXT] = {
.oid = TRUSTED_FW_NVCOUNTER_OID, .oid = TRUSTED_FW_NVCOUNTER_OID,
......
...@@ -11,7 +11,6 @@ ...@@ -11,7 +11,6 @@
#include <uuid.h> #include <uuid.h>
/* TODO: Update this number as required */
#define TOC_HEADER_SERIAL_NUMBER 0x12345678 #define TOC_HEADER_SERIAL_NUMBER 0x12345678
typedef struct toc_entry { typedef struct toc_entry {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment