Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
Menu
Open sidebar
adam.huang
Arm Trusted Firmware
Commits
b79239db
Unverified
Commit
b79239db
authored
6 years ago
by
Soby Mathew
Committed by
GitHub
6 years ago
Browse files
Options
Download
Plain Diff
Merge pull request #1879 from pbeesley-arm/pb/todo-removal
Pb/todo removal
parents
c0ce16fb
7d721816
master
v2.5
v2.5-rc1
v2.5-rc0
v2.4
v2.4-rc2
v2.4-rc1
v2.4-rc0
v2.3
v2.3-rc2
v2.3-rc1
v2.3-rc0
v2.2
v2.2-rc2
v2.2-rc1
v2.2-rc0
v2.1
v2.1-rc1
v2.1-rc0
arm_cca_v0.2
arm_cca_v0.1
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
drivers/io/io_fip.c
+0
-1
drivers/io/io_fip.c
drivers/io/io_storage.c
+0
-3
drivers/io/io_storage.c
include/drivers/io/io_storage.h
+0
-2
include/drivers/io/io_storage.h
tools/cert_create/src/tbbr/tbb_ext.c
+0
-4
tools/cert_create/src/tbbr/tbb_ext.c
tools/fiptool/tbbr_config.h
+0
-1
tools/fiptool/tbbr_config.h
with
0 additions
and
11 deletions
+0
-11
drivers/io/io_fip.c
View file @
b79239db
...
...
@@ -85,7 +85,6 @@ static inline int compare_uuids(const uuid_t *uuid1, const uuid_t *uuid2)
}
/* TODO: We could check version numbers or do a package checksum? */
static
inline
int
is_valid_header
(
fip_toc_header_t
*
header
)
{
if
((
header
->
name
==
TOC_HEADER_NAME
)
&&
(
header
->
serial_number
!=
0
))
{
...
...
This diff is collapsed.
Click to expand it.
drivers/io/io_storage.c
View file @
b79239db
...
...
@@ -189,9 +189,6 @@ int io_dev_init(uintptr_t dev_handle, const uintptr_t init_params)
return
result
;
}
/* TODO: Consider whether an explicit "shutdown" API should be included */
/* Close a connection to a device */
int
io_dev_close
(
uintptr_t
dev_handle
)
{
...
...
This diff is collapsed.
Click to expand it.
include/drivers/io/io_storage.h
View file @
b79239db
...
...
@@ -79,8 +79,6 @@ int io_dev_open(const struct io_dev_connector *dev_con,
* re-initialisation */
int
io_dev_init
(
uintptr_t
dev_handle
,
const
uintptr_t
init_params
);
/* TODO: Consider whether an explicit "shutdown" API should be included */
/* Close a connection to a device */
int
io_dev_close
(
uintptr_t
dev_handle
);
...
...
This diff is collapsed.
Click to expand it.
tools/cert_create/src/tbbr/tbb_ext.c
View file @
b79239db
...
...
@@ -19,10 +19,6 @@
#include "tbbr/tbb_ext.h"
#include "tbbr/tbb_key.h"
/* TODO: get these values from the command line */
#define TRUSTED_WORLD_NVCTR_VALUE 0
#define NORMAL_WORLD_NVCTR_VALUE 0
static
ext_t
tbb_ext
[]
=
{
[
TRUSTED_FW_NVCOUNTER_EXT
]
=
{
.
oid
=
TRUSTED_FW_NVCOUNTER_OID
,
...
...
This diff is collapsed.
Click to expand it.
tools/fiptool/tbbr_config.h
View file @
b79239db
...
...
@@ -11,7 +11,6 @@
#include <uuid.h>
/* TODO: Update this number as required */
#define TOC_HEADER_SERIAL_NUMBER 0x12345678
typedef
struct
toc_entry
{
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment
Menu
Projects
Groups
Snippets
Help