Skip to content

GitLab

Switch branch/tag
  1. 17 Dec, 2019 5 commits
    • Heiko Stuebner's avatar
      rockchip: make miniloader ddr_parameter handling optional · df5a9683
      Heiko Stuebner authored 
      

Transfering the regions of ddr memory to additionally protect is very much
specific to some rockchip internal first stage bootloader and doesn't get
used in either mainline uboot or even Rockchip's published vendor uboot
sources.

This results in a big error
    ERROR:   over or zero region, nr=0, max=10
getting emitted on every boot for most users and such a message coming
from early firmware might actually confuse developers working with the
system.

As this mechanism seems to be only be used by Rockchip's internal miniloader
hide it behind a build conditional, so it doesn't confuse people too much.
Signed-off-by: default avatarHeiko Stuebner <heiko.stuebner@theobroma-systems.com>
Change-Id: I52c02decc60fd431ea78c7486cad5bac82bdbfbe
      df5a9683
    • Heiko Stuebner's avatar
      rockchip: px30: cleanup securing of ddr regions · f55ef85e
      Heiko Stuebner authored 
      

So far the px30-related ddr security was loading data for regions to secure
from a pre-specified memory location and also setting region0 to secure
the first megabyte of memory in hard-coded setting (top=0, end=0, meaning
1MB).

To make things more explicit and easier to read add a function doing
the settings for specified memory areas, like other socs have and also
add an assert to make sure any descriptor read from memory does not
overlap the TZRAM security in region0 and TEE security in region1.
Signed-off-by: default avatarHeiko Stuebner <heiko.stuebner@theobroma-systems.com>
Change-Id: I78441875112bf66a62fde5f1789f4e52a78ef95f
      f55ef85e
    • Heiko Stuebner's avatar
      rockchip: px30: move secure init to separate file · d2483afa
      Heiko Stuebner authored 
      

Similar to others like rk3399 and rk3288 move the secure init to a
separate file to unclutter the soc init a bit.
Signed-off-by: default avatarHeiko Stuebner <heiko.stuebner@theobroma-systems.com>
Change-Id: Iebb38e24f1c7fe5353f139c896fb8ca769bf9691
      d2483afa
    • Heiko Stuebner's avatar
      rockchip: really use base+size for secure ddr regions · 7f0b2e78
      Heiko Stuebner authored 
      

The calls to secure ddr regions on rk3288 and rk3399 use parameters of
base and size - as it custom for specifying memory regions, but the
functions themself expect start and endpoints of the area.

This only works by chance for the TZRAM, as it starts a 0x0 and therefore
its end location is the same as its size.

To not fall into a trap later on adapt the functions to really take
base+size parameters.
Signed-off-by: default avatarHeiko Stuebner <heiko.stuebner@theobroma-systems.com>
Change-Id: Idb9fab38aa081f3335a4eca971e7b7f6757fbbab
      7f0b2e78
    • Heiko Stuebner's avatar
      rockchip: bring TZRAM_SIZE values in line · c6ee020e
      Heiko Stuebner authored 
      

The agreed upon division of early boot locations is 0x40000 for bl31
to leave enough room for u-boot-spl and 0x100000 for bl33 (u-boot).

rk3288 and rk3399 already correctly secure the ddr up to the 1MB boundary
so pull the other platforms along to also give the Rockchip TF-A enough
room to comfortably live in.
Signed-off-by: default avatarHeiko Stuebner <heiko.stuebner@theobroma-systems.com>
Change-Id: Ie9e0c927d3074a418b6fd23b599d2ed7c15c8c6f
      c6ee020e
  3. 13 Dec, 2019 1 commit
    • Joshua Watt's avatar
      rockchip: Prevent macro expansion in paths · 39a97dce
      Joshua Watt authored 
      

Instead of stringizing the paths to binary files, add them as string
defines on the command line (e.g. -DFOO=\"BAR\" instead of -DFOO=BAR).
This prevents macros from being expanded inside the string value itself.
For example, -DFOO=/path/with-linux-in-it would have been expanded to
"/path/with-1-in-it" because `linux=1` is one of the standard GCC
defines.

Change-Id: I7b65df3c9930faed4f1aff75ad726982ae3671e6
Signed-off-by: default avatarJoshua Watt <JPEWhacker@gmail.com>
      39a97dce
  5. 12 Dec, 2019 1 commit
  7. 10 Dec, 2019 4 commits
  9. 09 Dec, 2019 2 commits
  11. 04 Dec, 2019 3 commits
  13. 28 Nov, 2019 24 commits