swarm_dial.go 14.2 KB
Newer Older
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1
2
3
4
5
package swarm

import (
	"errors"
	"fmt"
6
	"sync"
7
	"time"
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
8

Jeromy's avatar
Jeromy committed
9
10
11
	lgbl "github.com/ipfs/go-libp2p-loggables"
	peer "github.com/ipfs/go-libp2p-peer"
	ma "github.com/jbenet/go-multiaddr"
12
13
	conn "github.com/libp2p/go-libp2p/p2p/net/conn"
	addrutil "github.com/libp2p/go-libp2p/p2p/net/swarm/addr"
Jeromy's avatar
Jeromy committed
14
	context "golang.org/x/net/context"
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
15
16
)

17
18
19
20
21
22
23
24
25
26
27
// Diagram of dial sync:
//
//   many callers of Dial()   synched w.  dials many addrs       results to callers
//  ----------------------\    dialsync    use earliest            /--------------
//  -----------------------\              |----------\           /----------------
//  ------------------------>------------<-------     >---------<-----------------
//  -----------------------|              \----x                 \----------------
//  ----------------------|                \-----x                \---------------
//                                         any may fail          if no addr at end
//                                                             retry dialAttempt x

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
28
var (
29
30
	// ErrDialBackoff is returned by the backoff code when a given peer has
	// been dialed too frequently
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
31
	ErrDialBackoff = errors.New("dial backoff")
32
33
34
35
36
37

	// ErrDialFailed is returned when connecting to a peer has ultimately failed
	ErrDialFailed = errors.New("dial attempt failed")

	// ErrDialToSelf is returned if we attempt to dial our own peer
	ErrDialToSelf = errors.New("dial to self attempted")
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
38
39
)

40
// dialAttempts governs how many times a goroutine will try to dial a given peer.
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
41
42
43
// Note: this is down to one, as we have _too many dials_ atm. To add back in,
// add loop back in Dial(.)
const dialAttempts = 1
44

Jeromy's avatar
Jeromy committed
45
46
47
// number of concurrent outbound dials over transports that consume file descriptors
const concurrentFdDials = 160

Jeromy's avatar
Jeromy committed
48
49
50
// number of concurrent outbound dials to make per peer
const defaultPerPeerRateLimit = 8

51
52
53
// DialTimeout is the amount of time each dial attempt has. We can think about making
// this larger down the road, or putting more granular timeouts (i.e. within each
// subcomponent of Dial)
54
var DialTimeout = time.Second * 10
55

56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
// dialsync is a small object that helps manage ongoing dials.
// this way, if we receive many simultaneous dial requests, one
// can do its thing, while the rest wait.
//
// this interface is so would-be dialers can just:
//
//  for {
//  	c := findConnectionToPeer(peer)
//  	if c != nil {
//  		return c
//  	}
//
//  	// ok, no connections. should we dial?
//  	if ok, wait := dialsync.Lock(peer); !ok {
//  		<-wait // can optionally wait
//  		continue
//  	}
//  	defer dialsync.Unlock(peer)
//
//  	c := actuallyDial(peer)
//  	return c
//  }
//
type dialsync struct {
	// ongoing is a map of tickets for the current peers being dialed.
	// this way, we dont kick off N dials simultaneously.
	ongoing map[peer.ID]chan struct{}
	lock    sync.Mutex
}

// Lock governs the beginning of a dial attempt.
// If there are no ongoing dials, it returns true, and the client is now
// scheduled to dial. Every other goroutine that calls startDial -- with
//the same dst -- will block until client is done. The client MUST call
// ds.Unlock(p) when it is done, to unblock the other callers.
// The client is not reponsible for achieving a successful dial, only for
// reporting the end of the attempt (calling ds.Unlock(p)).
//
// see the example below `dialsync`
func (ds *dialsync) Lock(dst peer.ID) (bool, chan struct{}) {
	ds.lock.Lock()
	if ds.ongoing == nil { // init if not ready
		ds.ongoing = make(map[peer.ID]chan struct{})
	}
	wait, found := ds.ongoing[dst]
	if !found {
		ds.ongoing[dst] = make(chan struct{})
	}
	ds.lock.Unlock()

	if found {
		return false, wait
	}

	// ok! you're signed up to dial!
	return true, nil
}

// Unlock releases waiters to a dial attempt. see Lock.
// if Unlock(p) is called without calling Lock(p) first, Unlock panics.
func (ds *dialsync) Unlock(dst peer.ID) {
	ds.lock.Lock()
	wait, found := ds.ongoing[dst]
	if !found {
		panic("called dialDone with no ongoing dials to peer: " + dst.Pretty())
	}
Jeromy's avatar
Jeromy committed
122

123
124
125
126
127
	delete(ds.ongoing, dst) // remove ongoing dial
	close(wait)             // release everyone else
	ds.lock.Unlock()
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
// dialbackoff is a struct used to avoid over-dialing the same, dead peers.
// Whenever we totally time out on a peer (all three attempts), we add them
// to dialbackoff. Then, whenevers goroutines would _wait_ (dialsync), they
// check dialbackoff. If it's there, they don't wait and exit promptly with
// an error. (the single goroutine that is actually dialing continues to
// dial). If a dial is successful, the peer is removed from backoff.
// Example:
//
//  for {
//  	if ok, wait := dialsync.Lock(p); !ok {
//  		if backoff.Backoff(p) {
//  			return errDialFailed
//  		}
//  		<-wait
//  		continue
//  	}
//  	defer dialsync.Unlock(p)
//  	c, err := actuallyDial(p)
//  	if err != nil {
//  		dialbackoff.AddBackoff(p)
//  		continue
//  	}
//  	dialbackoff.Clear(p)
//  }
//
Jeromy's avatar
Jeromy committed
153

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
154
type dialbackoff struct {
Jeromy's avatar
Jeromy committed
155
	entries map[peer.ID]*backoffPeer
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
156
157
158
	lock    sync.RWMutex
}

Jeromy's avatar
Jeromy committed
159
160
161
162
163
type backoffPeer struct {
	tries int
	until time.Time
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
164
165
func (db *dialbackoff) init() {
	if db.entries == nil {
Jeromy's avatar
Jeromy committed
166
		db.entries = make(map[peer.ID]*backoffPeer)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
167
168
169
170
	}
}

// Backoff returns whether the client should backoff from dialing
Jeromy's avatar
Jeromy committed
171
172
// peer p
func (db *dialbackoff) Backoff(p peer.ID) (backoff bool) {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
173
	db.lock.Lock()
Jeromy's avatar
Jeromy committed
174
	defer db.lock.Unlock()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
175
	db.init()
Jeromy's avatar
Jeromy committed
176
177
178
179
180
181
	bp, found := db.entries[p]
	if found && time.Now().Before(bp.until) {
		return true
	}

	return false
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
182
183
}

Jeromy's avatar
Jeromy committed
184
185
186
const baseBackoffTime = time.Second * 5
const maxBackoffTime = time.Minute * 5

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
187
188
189
190
191
// AddBackoff lets other nodes know that we've entered backoff with
// peer p, so dialers should not wait unnecessarily. We still will
// attempt to dial with one goroutine, in case we get through.
func (db *dialbackoff) AddBackoff(p peer.ID) {
	db.lock.Lock()
Jeromy's avatar
Jeromy committed
192
	defer db.lock.Unlock()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
193
	db.init()
Jeromy's avatar
Jeromy committed
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
	bp, ok := db.entries[p]
	if !ok {
		db.entries[p] = &backoffPeer{
			tries: 1,
			until: time.Now().Add(baseBackoffTime),
		}
		return
	}

	expTimeAdd := time.Second * time.Duration(bp.tries*bp.tries)
	if expTimeAdd > maxBackoffTime {
		expTimeAdd = maxBackoffTime
	}
	bp.until = time.Now().Add(baseBackoffTime + expTimeAdd)
	bp.tries++
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
209
210
211
212
213
214
}

// Clear removes a backoff record. Clients should call this after a
// successful Dial.
func (db *dialbackoff) Clear(p peer.ID) {
	db.lock.Lock()
Jeromy's avatar
Jeromy committed
215
	defer db.lock.Unlock()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
216
217
218
219
	db.init()
	delete(db.entries, p)
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
220
221
222
223
224
225
226
// Dial connects to a peer.
//
// The idea is that the client of Swarm does not need to know what network
// the connection will happen over. Swarm can use whichever it choses.
// This allows us to use various transport protocols, do NAT traversal/relay,
// etc. to achive connection.
func (s *Swarm) Dial(ctx context.Context, p peer.ID) (*Conn, error) {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
227
	var logdial = lgbl.Dial("swarm", s.LocalPeer(), p, nil, nil)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
228
	if p == s.local {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
229
230
		log.Event(ctx, "swarmDialSelf", logdial)
		return nil, ErrDialToSelf
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
231
232
	}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
233
234
	return s.gatedDialAttempt(ctx, p)
}
235

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
236
237
238
239
240
241
242
243
244
func (s *Swarm) bestConnectionToPeer(p peer.ID) *Conn {
	cs := s.ConnectionsToPeer(p)
	for _, conn := range cs {
		if conn != nil { // dump out the first one we find. (TODO pick better)
			return conn
		}
	}
	return nil
}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
245

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
246
247
248
249
250
// gatedDialAttempt is an attempt to dial a node. It is gated by the swarm's
// dial synchronization systems: dialsync and dialbackoff.
func (s *Swarm) gatedDialAttempt(ctx context.Context, p peer.ID) (*Conn, error) {
	var logdial = lgbl.Dial("swarm", s.LocalPeer(), p, nil, nil)
	defer log.EventBegin(ctx, "swarmDialAttemptSync", logdial).Done()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
251

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
252
253
254
255
256
	// check if we already have an open connection first
	conn := s.bestConnectionToPeer(p)
	if conn != nil {
		return conn, nil
	}
257

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
258
259
	// check if there's an ongoing dial to this peer
	if ok, wait := s.dsync.Lock(p); ok {
Jeromy's avatar
Jeromy committed
260
261
262
263
264
265
266
267
		defer s.dsync.Unlock(p)

		// if this peer has been backed off, lets get out of here
		if s.backf.Backoff(p) {
			log.Event(ctx, "swarmDialBackoff", logdial)
			return nil, ErrDialBackoff
		}

268
		// ok, we have been charged to dial! let's do it.
269
		// if it succeeds, dial will add the conn to the swarm itself.
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
270
		defer log.EventBegin(ctx, "swarmDialAttemptStart", logdial).Done()
271
		ctxT, cancel := context.WithTimeout(ctx, s.dialT)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
272
		conn, err := s.dial(ctxT, p)
273
		cancel()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
274
		log.Debugf("dial end %s", conn)
275
		if err != nil {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
276
			log.Event(ctx, "swarmDialBackoffAdd", logdial)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
277
278
			s.backf.AddBackoff(p) // let others know to backoff

279
280
			// ok, we failed. try again. (if loop is done, our error is output)
			return nil, fmt.Errorf("dial attempt failed: %s", err)
281
		}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
282
		log.Event(ctx, "swarmDialBackoffClear", logdial)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
283
		s.backf.Clear(p) // okay, no longer need to backoff
284
		return conn, nil
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307

	} else {
		// we did not dial. we must wait for someone else to dial.

		// check whether we should backoff first...
		if s.backf.Backoff(p) {
			log.Event(ctx, "swarmDialBackoff", logdial)
			return nil, ErrDialBackoff
		}

		defer log.EventBegin(ctx, "swarmDialWait", logdial).Done()
		select {
		case <-wait: // wait for that other dial to finish.

			// see if it worked, OR we got an incoming dial in the meantime...
			conn := s.bestConnectionToPeer(p)
			if conn != nil {
				return conn, nil
			}
			return nil, ErrDialFailed
		case <-ctx.Done(): // or we may have to bail...
			return nil, ctx.Err()
		}
308
309
310
311
312
	}
}

// dial is the actual swarm's dial logic, gated by Dial.
func (s *Swarm) dial(ctx context.Context, p peer.ID) (*Conn, error) {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
313
	var logdial = lgbl.Dial("swarm", s.LocalPeer(), p, nil, nil)
314
	if p == s.local {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
315
316
		log.Event(ctx, "swarmDialDoDialSelf", logdial)
		return nil, ErrDialToSelf
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
317
	}
318
319
	defer log.EventBegin(ctx, "swarmDialDo", logdial).Done()
	logdial["dial"] = "failure" // start off with failure. set to "success" at the end.
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
320
321

	sk := s.peers.PrivKey(s.local)
322
	logdial["encrypted"] = (sk != nil) // log wether this will be an encrypted dial or not.
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
323
	if sk == nil {
324
		// fine for sk to be nil, just log.
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
325
		log.Debug("Dial not given PrivateKey, so WILL NOT SECURE conn.")
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
326
327
	}

328
	ila, _ := s.InterfaceListenAddresses()
329
	subtractFilter := addrutil.SubtractFilter(append(ila, s.peers.Addrs(s.local)...)...)
Jeromy's avatar
Jeromy committed
330
331
332
333
334

	// get live channel of addresses for peer, filtered by the given filters
	/*
		remoteAddrChan := s.peers.AddrsChan(ctx, p,
			addrutil.AddrUsableFilter,
335
			subtractFilter,
Jeromy's avatar
Jeromy committed
336
337
338
			s.Filters.AddrBlocked)
	*/

Jeromy's avatar
Jeromy committed
339
340
341
342
343
344
345
346
	//////
	/*
		This code is temporary, the peerstore can currently provide
		a channel as an interface for receiving addresses, but more thought
		needs to be put into the execution. For now, this allows us to use
		the improved rate limiter, while maintaining the outward behaviour
		that we previously had (halting a dial when we run out of addrs)
	*/
Jeromy's avatar
Jeromy committed
347
	paddrs := s.peers.Addrs(p)
348
	goodAddrs := addrutil.FilterAddrs(paddrs,
Jeromy's avatar
Jeromy committed
349
		addrutil.AddrUsableFunc,
350
		subtractFilter,
Jeromy's avatar
Jeromy committed
351
352
		addrutil.FilterNeg(s.Filters.AddrBlocked),
	)
353
354
	remoteAddrChan := make(chan ma.Multiaddr, len(goodAddrs))
	for _, a := range goodAddrs {
Jeromy's avatar
Jeromy committed
355
		remoteAddrChan <- a
356
	}
Jeromy's avatar
Jeromy committed
357
358
	close(remoteAddrChan)
	/////////
359

360
	// try to get a connection to any addr
Jeromy's avatar
Jeromy committed
361
	connC, err := s.dialAddrs(ctx, p, remoteAddrChan)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
362
	if err != nil {
363
		logdial["error"] = err
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
364
365
		return nil, err
	}
366
	logdial["netconn"] = lgbl.NetConn(connC)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
367
368

	// ok try to setup the new connection.
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
369
	defer log.EventBegin(ctx, "swarmDialDoSetup", logdial, lgbl.NetConn(connC)).Done()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
370
371
	swarmC, err := dialConnSetup(ctx, s, connC)
	if err != nil {
372
		logdial["error"] = err
373
		connC.Close() // close the connection. didn't work out :(
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
374
375
376
		return nil, err
	}

377
	logdial["dial"] = "success"
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
378
379
380
	return swarmC, nil
}

Jeromy's avatar
Jeromy committed
381
func (s *Swarm) dialAddrs(ctx context.Context, p peer.ID, remoteAddrs <-chan ma.Multiaddr) (conn.Conn, error) {
382
	log.Debugf("%s swarm dialing %s %s", s.local, p, remoteAddrs)
383
384
385
386

	ctx, cancel := context.WithCancel(ctx)
	defer cancel() // cancel work when we exit func

Jeromy's avatar
Jeromy committed
387
388
	// use a single response type instead of errs and conns, reduces complexity *a ton*
	respch := make(chan dialResult)
389

Jeromy's avatar
Jeromy committed
390
391
	defaultDialFail := fmt.Errorf("failed to dial %s (default failure)", p)
	exitErr := defaultDialFail
Jeromy's avatar
Jeromy committed
392

Jeromy's avatar
Jeromy committed
393
394
	var active int
	for {
395
		select {
Jeromy's avatar
Jeromy committed
396
397
398
399
400
401
402
		case addr, ok := <-remoteAddrs:
			if !ok {
				remoteAddrs = nil
				if active == 0 {
					return nil, exitErr
				}
				continue
403
			}
404

Jeromy's avatar
Jeromy committed
405
406
407
408
409
			s.limitedDial(ctx, p, addr, respch)
			active++
		case <-ctx.Done():
			if exitErr == defaultDialFail {
				exitErr = ctx.Err()
Jeromy's avatar
Jeromy committed
410
			}
Jeromy's avatar
Jeromy committed
411
412
413
414
			return nil, exitErr
		case resp := <-respch:
			active--
			if resp.Err != nil {
Jeromy's avatar
Jeromy committed
415
				log.Info("got error on dial: ", resp.Err)
Jeromy's avatar
Jeromy committed
416
417
418
419
420
421
422
423
				// Errors are normal, lots of dials will fail
				exitErr = resp.Err

				if remoteAddrs == nil && active == 0 {
					return nil, exitErr
				}
			} else if resp.Conn != nil {
				return resp.Conn, nil
424
			}
425
		}
426
	}
Jeromy's avatar
Jeromy committed
427
428
}

Jeromy's avatar
Jeromy committed
429
430
431
// limitedDial will start a dial to the given peer when
// it is able, respecting the various different types of rate
// limiting that occur without using extra goroutines per addr
Jeromy's avatar
Jeromy committed
432
433
434
435
436
437
438
func (s *Swarm) limitedDial(ctx context.Context, p peer.ID, a ma.Multiaddr, resp chan dialResult) {
	s.limiter.AddDialJob(&dialJob{
		addr: a,
		peer: p,
		resp: resp,
		ctx:  ctx,
	})
439
440
}

Jeromy's avatar
Jeromy committed
441
func (s *Swarm) dialAddr(ctx context.Context, p peer.ID, addr ma.Multiaddr) (conn.Conn, error) {
442
443
	log.Debugf("%s swarm dialing %s %s", s.local, p, addr)

Jeromy's avatar
Jeromy committed
444
	connC, err := s.dialer.Dial(ctx, addr, p)
445
	if err != nil {
446
		return nil, fmt.Errorf("%s --> %s dial attempt failed: %s", s.local, p, err)
447
	}
448
449
450
451
452

	// if the connection is not to whom we thought it would be...
	remotep := connC.RemotePeer()
	if remotep != p {
		connC.Close()
453
454
		_, err := connC.Read(nil) // should return any potential errors (ex: from secio)
		return nil, fmt.Errorf("misdial to %s through %s (got %s): %s", p, addr, remotep, err)
455
456
457
458
459
460
461
462
463
464
465
466
	}

	// if the connection is to ourselves...
	// this can happen TONS when Loopback addrs are advertized.
	// (this should be caught by two checks above, but let's just make sure.)
	if remotep == s.local {
		connC.Close()
		return nil, fmt.Errorf("misdial to %s through %s (got self)", p, addr)
	}

	// success! we got one!
	return connC, nil
467
468
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
469
470
471
472
473
474
475
476
477
478
479
480
481
// dialConnSetup is the setup logic for a connection from the dial side. it
// needs to add the Conn to the StreamSwarm, then run newConnSetup
func dialConnSetup(ctx context.Context, s *Swarm, connC conn.Conn) (*Conn, error) {

	psC, err := s.swarm.AddConn(connC)
	if err != nil {
		// connC is closed by caller if we fail.
		return nil, fmt.Errorf("failed to add conn to ps.Swarm: %s", err)
	}

	// ok try to setup the new connection. (newConnSetup will add to group)
	swarmC, err := s.newConnSetup(ctx, psC)
	if err != nil {
482
		psC.Close() // we need to make sure psC is Closed.
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
483
484
485
486
487
		return nil, err
	}

	return swarmC, err
}