swarm_dial.go 14.2 KB
Newer Older
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1
2
3
4
5
package swarm

import (
	"errors"
	"fmt"
6
	"math/rand"
7
	"net"
8
	"sync"
9
	"time"
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
10
11

	conn "github.com/jbenet/go-ipfs/p2p/net/conn"
12
	addrutil "github.com/jbenet/go-ipfs/p2p/net/swarm/addr"
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
13
14
15
	peer "github.com/jbenet/go-ipfs/p2p/peer"
	lgbl "github.com/jbenet/go-ipfs/util/eventlog/loggables"

16
	ma "github.com/jbenet/go-ipfs/Godeps/_workspace/src/github.com/jbenet/go-multiaddr"
17
	manet "github.com/jbenet/go-ipfs/Godeps/_workspace/src/github.com/jbenet/go-multiaddr-net"
18
19
	process "github.com/jbenet/go-ipfs/Godeps/_workspace/src/github.com/jbenet/goprocess"
	ratelimit "github.com/jbenet/go-ipfs/Godeps/_workspace/src/github.com/jbenet/goprocess/ratelimit"
20
	context "github.com/jbenet/go-ipfs/Godeps/_workspace/src/golang.org/x/net/context"
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
21
22
)

23
24
25
26
27
28
29
30
31
32
33
// Diagram of dial sync:
//
//   many callers of Dial()   synched w.  dials many addrs       results to callers
//  ----------------------\    dialsync    use earliest            /--------------
//  -----------------------\              |----------\           /----------------
//  ------------------------>------------<-------     >---------<-----------------
//  -----------------------|              \----x                 \----------------
//  ----------------------|                \-----x                \---------------
//                                         any may fail          if no addr at end
//                                                             retry dialAttempt x

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
34
35
36
37
38
39
var (
	ErrDialBackoff = errors.New("dial backoff")
	ErrDialFailed  = errors.New("dial attempt failed")
	ErrDialToSelf  = errors.New("dial to self attempted")
)

40
// dialAttempts governs how many times a goroutine will try to dial a given peer.
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
41
42
43
// Note: this is down to one, as we have _too many dials_ atm. To add back in,
// add loop back in Dial(.)
const dialAttempts = 1
44

45
46
47
// DialTimeout is the amount of time each dial attempt has. We can think about making
// this larger down the road, or putting more granular timeouts (i.e. within each
// subcomponent of Dial)
48
var DialTimeout time.Duration = time.Second * 10
49

50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
// dialsync is a small object that helps manage ongoing dials.
// this way, if we receive many simultaneous dial requests, one
// can do its thing, while the rest wait.
//
// this interface is so would-be dialers can just:
//
//  for {
//  	c := findConnectionToPeer(peer)
//  	if c != nil {
//  		return c
//  	}
//
//  	// ok, no connections. should we dial?
//  	if ok, wait := dialsync.Lock(peer); !ok {
//  		<-wait // can optionally wait
//  		continue
//  	}
//  	defer dialsync.Unlock(peer)
//
//  	c := actuallyDial(peer)
//  	return c
//  }
//
type dialsync struct {
	// ongoing is a map of tickets for the current peers being dialed.
	// this way, we dont kick off N dials simultaneously.
	ongoing map[peer.ID]chan struct{}
	lock    sync.Mutex
}

// Lock governs the beginning of a dial attempt.
// If there are no ongoing dials, it returns true, and the client is now
// scheduled to dial. Every other goroutine that calls startDial -- with
//the same dst -- will block until client is done. The client MUST call
// ds.Unlock(p) when it is done, to unblock the other callers.
// The client is not reponsible for achieving a successful dial, only for
// reporting the end of the attempt (calling ds.Unlock(p)).
//
// see the example below `dialsync`
func (ds *dialsync) Lock(dst peer.ID) (bool, chan struct{}) {
	ds.lock.Lock()
	if ds.ongoing == nil { // init if not ready
		ds.ongoing = make(map[peer.ID]chan struct{})
	}
	wait, found := ds.ongoing[dst]
	if !found {
		ds.ongoing[dst] = make(chan struct{})
	}
	ds.lock.Unlock()

	if found {
		return false, wait
	}

	// ok! you're signed up to dial!
	return true, nil
}

// Unlock releases waiters to a dial attempt. see Lock.
// if Unlock(p) is called without calling Lock(p) first, Unlock panics.
func (ds *dialsync) Unlock(dst peer.ID) {
	ds.lock.Lock()
	wait, found := ds.ongoing[dst]
	if !found {
		panic("called dialDone with no ongoing dials to peer: " + dst.Pretty())
	}
	delete(ds.ongoing, dst) // remove ongoing dial
	close(wait)             // release everyone else
	ds.lock.Unlock()
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
// dialbackoff is a struct used to avoid over-dialing the same, dead peers.
// Whenever we totally time out on a peer (all three attempts), we add them
// to dialbackoff. Then, whenevers goroutines would _wait_ (dialsync), they
// check dialbackoff. If it's there, they don't wait and exit promptly with
// an error. (the single goroutine that is actually dialing continues to
// dial). If a dial is successful, the peer is removed from backoff.
// Example:
//
//  for {
//  	if ok, wait := dialsync.Lock(p); !ok {
//  		if backoff.Backoff(p) {
//  			return errDialFailed
//  		}
//  		<-wait
//  		continue
//  	}
//  	defer dialsync.Unlock(p)
//  	c, err := actuallyDial(p)
//  	if err != nil {
//  		dialbackoff.AddBackoff(p)
//  		continue
//  	}
//  	dialbackoff.Clear(p)
//  }
//
type dialbackoff struct {
	entries map[peer.ID]struct{}
	lock    sync.RWMutex
}

func (db *dialbackoff) init() {
	if db.entries == nil {
		db.entries = make(map[peer.ID]struct{})
	}
}

// Backoff returns whether the client should backoff from dialing
// peeer p
func (db *dialbackoff) Backoff(p peer.ID) bool {
	db.lock.Lock()
	db.init()
	_, found := db.entries[p]
	db.lock.Unlock()
	return found
}

// AddBackoff lets other nodes know that we've entered backoff with
// peer p, so dialers should not wait unnecessarily. We still will
// attempt to dial with one goroutine, in case we get through.
func (db *dialbackoff) AddBackoff(p peer.ID) {
	db.lock.Lock()
	db.init()
	db.entries[p] = struct{}{}
	db.lock.Unlock()
}

// Clear removes a backoff record. Clients should call this after a
// successful Dial.
func (db *dialbackoff) Clear(p peer.ID) {
	db.lock.Lock()
	db.init()
	delete(db.entries, p)
	db.lock.Unlock()
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
186
187
188
189
190
191
192
// Dial connects to a peer.
//
// The idea is that the client of Swarm does not need to know what network
// the connection will happen over. Swarm can use whichever it choses.
// This allows us to use various transport protocols, do NAT traversal/relay,
// etc. to achive connection.
func (s *Swarm) Dial(ctx context.Context, p peer.ID) (*Conn, error) {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
193
	var logdial = lgbl.Dial("swarm", s.LocalPeer(), p, nil, nil)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
194
	if p == s.local {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
195
196
		log.Event(ctx, "swarmDialSelf", logdial)
		return nil, ErrDialToSelf
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
197
198
	}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
199
200
	return s.gatedDialAttempt(ctx, p)
}
201

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
202
203
204
205
206
207
208
209
210
func (s *Swarm) bestConnectionToPeer(p peer.ID) *Conn {
	cs := s.ConnectionsToPeer(p)
	for _, conn := range cs {
		if conn != nil { // dump out the first one we find. (TODO pick better)
			return conn
		}
	}
	return nil
}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
211

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
212
213
214
215
216
// gatedDialAttempt is an attempt to dial a node. It is gated by the swarm's
// dial synchronization systems: dialsync and dialbackoff.
func (s *Swarm) gatedDialAttempt(ctx context.Context, p peer.ID) (*Conn, error) {
	var logdial = lgbl.Dial("swarm", s.LocalPeer(), p, nil, nil)
	defer log.EventBegin(ctx, "swarmDialAttemptSync", logdial).Done()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
217

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
218
219
220
221
222
	// check if we already have an open connection first
	conn := s.bestConnectionToPeer(p)
	if conn != nil {
		return conn, nil
	}
223

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
224
225
	// check if there's an ongoing dial to this peer
	if ok, wait := s.dsync.Lock(p); ok {
226
		// ok, we have been charged to dial! let's do it.
227
		// if it succeeds, dial will add the conn to the swarm itself.
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
228
229

		defer log.EventBegin(ctx, "swarmDialAttemptStart", logdial).Done()
230
		ctxT, _ := context.WithTimeout(ctx, s.dialT)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
231
		conn, err := s.dial(ctxT, p)
232
		s.dsync.Unlock(p)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
233
		log.Debugf("dial end %s", conn)
234
		if err != nil {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
235
			log.Event(ctx, "swarmDialBackoffAdd", logdial)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
236
237
			s.backf.AddBackoff(p) // let others know to backoff

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
238
			return nil, ErrDialFailed // ok, we failed. try again. (if loop is done, our error is output)
239
		}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
240
		log.Event(ctx, "swarmDialBackoffClear", logdial)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
241
		s.backf.Clear(p) // okay, no longer need to backoff
242
		return conn, nil
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265

	} else {
		// we did not dial. we must wait for someone else to dial.

		// check whether we should backoff first...
		if s.backf.Backoff(p) {
			log.Event(ctx, "swarmDialBackoff", logdial)
			return nil, ErrDialBackoff
		}

		defer log.EventBegin(ctx, "swarmDialWait", logdial).Done()
		select {
		case <-wait: // wait for that other dial to finish.

			// see if it worked, OR we got an incoming dial in the meantime...
			conn := s.bestConnectionToPeer(p)
			if conn != nil {
				return conn, nil
			}
			return nil, ErrDialFailed
		case <-ctx.Done(): // or we may have to bail...
			return nil, ctx.Err()
		}
266
267
268
269
270
	}
}

// dial is the actual swarm's dial logic, gated by Dial.
func (s *Swarm) dial(ctx context.Context, p peer.ID) (*Conn, error) {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
271
	var logdial = lgbl.Dial("swarm", s.LocalPeer(), p, nil, nil)
272
	if p == s.local {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
273
274
		log.Event(ctx, "swarmDialDoDialSelf", logdial)
		return nil, ErrDialToSelf
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
275
	}
276
277
	defer log.EventBegin(ctx, "swarmDialDo", logdial).Done()
	logdial["dial"] = "failure" // start off with failure. set to "success" at the end.
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
278
279

	sk := s.peers.PrivKey(s.local)
280
	logdial["encrypted"] = (sk != nil) // log wether this will be an encrypted dial or not.
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
281
	if sk == nil {
282
		// fine for sk to be nil, just log.
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
283
		log.Debug("Dial not given PrivateKey, so WILL NOT SECURE conn.")
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
284
285
	}

286
287
288
289
	// get our own addrs. try dialing out from our listener addresses (reusing ports)
	// Note that using our peerstore's addresses here is incorrect, as that would
	// include observed addresses. TODO: make peerstore's address book smarter.
	localAddrs := s.ListenAddresses()
290
291
292
293
294
	if len(localAddrs) == 0 {
		log.Debug("Dialing out with no local addresses.")
	}

	// get remote peer addrs
295
	remoteAddrs := s.peers.Addrs(p)
296
	// make sure we can use the addresses.
297
	remoteAddrs = addrutil.FilterUsableAddrs(remoteAddrs)
298
299
	// drop out any addrs that would just dial ourselves. use ListenAddresses
	// as that is a more authoritative view than localAddrs.
300
	ila, _ := s.InterfaceListenAddresses()
301
	remoteAddrs = addrutil.Subtract(remoteAddrs, ila)
302
	remoteAddrs = addrutil.Subtract(remoteAddrs, s.peers.Addrs(s.local))
303
	log.Debugf("%s swarm dialing %s -- local:%s remote:%s", s.local, p, s.ListenAddresses(), remoteAddrs)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
304
	if len(remoteAddrs) == 0 {
305
306
307
		err := errors.New("peer has no addresses")
		logdial["error"] = err
		return nil, err
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
308
309
310
311
	}

	// open connection to peer
	d := &conn.Dialer{
312
313
		Dialer: manet.Dialer{
			Dialer: net.Dialer{
314
				Timeout: s.dialT,
315
316
			},
		},
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
317
318
319
320
321
		LocalPeer:  s.local,
		LocalAddrs: localAddrs,
		PrivateKey: sk,
	}

322
323
	// try to get a connection to any addr
	connC, err := s.dialAddrs(ctx, d, p, remoteAddrs)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
324
	if err != nil {
325
		logdial["error"] = err
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
326
327
		return nil, err
	}
328
	logdial["netconn"] = lgbl.NetConn(connC)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
329
330

	// ok try to setup the new connection.
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
331
	defer log.EventBegin(ctx, "swarmDialDoSetup", logdial, lgbl.NetConn(connC)).Done()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
332
333
	swarmC, err := dialConnSetup(ctx, s, connC)
	if err != nil {
334
		logdial["error"] = err
335
		connC.Close() // close the connection. didn't work out :(
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
336
337
338
		return nil, err
	}

339
	logdial["dial"] = "success"
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
340
341
342
	return swarmC, nil
}

343
344
345
func (s *Swarm) dialAddrs(ctx context.Context, d *conn.Dialer, p peer.ID, remoteAddrs []ma.Multiaddr) (conn.Conn, error) {

	// try to connect to one of the peer's known addresses.
346
347
348
349
	// we dial concurrently to each of the addresses, which:
	// * makes the process faster overall
	// * attempts to get the fastest connection available.
	// * mitigates the waste of trying bad addresses
350
	log.Debugf("%s swarm dialing %s %s", s.local, p, remoteAddrs)
351
352
353
354
355
356
357
358

	ctx, cancel := context.WithCancel(ctx)
	defer cancel() // cancel work when we exit func

	foundConn := make(chan struct{})
	conns := make(chan conn.Conn, len(remoteAddrs))
	errs := make(chan error, len(remoteAddrs))

359
360
361
	// dialSingleAddr is used in the rate-limited async thing below.
	dialSingleAddr := func(addr ma.Multiaddr) {
		connC, err := s.dialAddr(ctx, d, p, addr)
362

363
364
365
366
367
		// check parent still wants our results
		select {
		case <-foundConn:
			if connC != nil {
				connC.Close()
368
			}
369
370
371
			return
		default:
		}
372

373
374
375
376
377
378
379
		if err != nil {
			errs <- err
		} else if connC == nil {
			errs <- fmt.Errorf("failed to dial %s %s", p, addr)
		} else {
			conns <- connC
		}
380
	}
381

382
383
384
385
	// this whole thing is in a goroutine so we can use foundConn
	// to end early.
	go func() {
		// rate limiting just in case. at most 10 addrs at once.
386
		limiter := ratelimit.NewRateLimiter(process.Background(), 10)
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
		limiter.Go(func(worker process.Process) {
			// permute addrs so we try different sets first each time.
			for _, i := range rand.Perm(len(remoteAddrs)) {
				select {
				case <-foundConn: // if one of them succeeded already
					break
				case <-worker.Closing(): // our context was cancelled
					break
				default:
				}

				workerAddr := remoteAddrs[i] // shadow variable to avoid race
				limiter.LimitedGo(func(worker process.Process) {
					dialSingleAddr(workerAddr)
				})
402
			}
403
		})
404
405
406

		<-ctx.Done()
		limiter.Close()
407
408
409
410
	}()

	// wair fot the results.
	exitErr := fmt.Errorf("failed to dial %s", p)
411
412
	for i := 0; i < len(remoteAddrs); i++ {
		select {
413
414
		case exitErr = <-errs: //
			log.Debug(exitErr)
415
416
417
418
419
		case connC := <-conns:
			// take the first + return asap
			close(foundConn)
			return connC, nil
		}
420
	}
421
	return nil, exitErr
422
423
424
425
426
427
}

func (s *Swarm) dialAddr(ctx context.Context, d *conn.Dialer, p peer.ID, addr ma.Multiaddr) (conn.Conn, error) {
	log.Debugf("%s swarm dialing %s %s", s.local, p, addr)

	connC, err := d.Dial(ctx, addr, p)
428
	if err != nil {
429
		return nil, fmt.Errorf("%s --> %s dial attempt failed: %s", s.local, p, err)
430
	}
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448

	// if the connection is not to whom we thought it would be...
	remotep := connC.RemotePeer()
	if remotep != p {
		connC.Close()
		return nil, fmt.Errorf("misdial to %s through %s (got %s)", p, addr, remotep)
	}

	// if the connection is to ourselves...
	// this can happen TONS when Loopback addrs are advertized.
	// (this should be caught by two checks above, but let's just make sure.)
	if remotep == s.local {
		connC.Close()
		return nil, fmt.Errorf("misdial to %s through %s (got self)", p, addr)
	}

	// success! we got one!
	return connC, nil
449
450
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
451
452
453
454
455
456
457
458
459
460
461
462
463
// dialConnSetup is the setup logic for a connection from the dial side. it
// needs to add the Conn to the StreamSwarm, then run newConnSetup
func dialConnSetup(ctx context.Context, s *Swarm, connC conn.Conn) (*Conn, error) {

	psC, err := s.swarm.AddConn(connC)
	if err != nil {
		// connC is closed by caller if we fail.
		return nil, fmt.Errorf("failed to add conn to ps.Swarm: %s", err)
	}

	// ok try to setup the new connection. (newConnSetup will add to group)
	swarmC, err := s.newConnSetup(ctx, psC)
	if err != nil {
464
		psC.Close() // we need to make sure psC is Closed.
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
465
466
467
468
469
		return nil, err
	}

	return swarmC, err
}