Skip to content

GitLab

Switch branch/tag
  1. 05 May, 2016 3 commits
  3. 04 May, 2016 7 commits
  5. 30 Apr, 2016 2 commits
  7. 19 Apr, 2016 2 commits
  9. 18 Apr, 2016 2 commits
  11. 31 Mar, 2016 3 commits
  13. 25 Mar, 2016 1 commit
  15. 22 Mar, 2016 1 commit
    • Explorer09's avatar
      BarMeterMode_draw minor code improvement · 7b3c8bc7
      Explorer09 authored 
      Removed a loop that sets the bar[] buffer with spaces and merged that
task to the snprintf() call just below. No need for the barOffset
variable. Display behavior is unchanged.

Size comparision (when compiled on Ubuntu 14.04 64-bit):

    $ size htop.old htop.new
       text    data     bss     dec     hex filename
     137312   15112    3776  156200   26228 htop.old
     137216   15112    3776  156104   261c8 htop.new
      7b3c8bc7
  17. 20 Mar, 2016 1 commit
  19. 19 Mar, 2016 1 commit
    • Explorer09's avatar
      Assert (Platform_meterTypes[0]==&CPUMeter_class) · 328de356
      Explorer09 authored 
      Just assume Platform_meterTypes[0] is always &CPUMeter_class for every
platform. This removes a conditional in AvailableMetersPanel_new().

Also adds some comments about the logic here. Without assuming
Platform_meterTypes[0], the (int i=1) clause in this for loop will not
make sense. (I.e. Why not (int i=0)? )

Also replaced a sprintf() call with safer snprintf() in code further
below.
      328de356
  21. 13 Mar, 2016 1 commit
  23. 11 Mar, 2016 2 commits
    • Explorer09's avatar
      Explicit "maxItems" property of meters · 99fb3070
      Explorer09 authored 
      Two changes in this commit:
- All meters now explicitly specify "maxItems" property, even for just
  1 item. (Exception is "container" CPU meter classes, which use
  CUSTOM_METERMODE.)
- "maxItems" being 0 is now allowed. This will let bar meters and graph
  meters render an empty meter.
      99fb3070
    • Explorer09's avatar
      Revert 5c593fae (xCalloc) · 7d3f67e8
      Explorer09 authored 
      calloc() allows 'nmemb' or 'size' to be zero, in which case NULL may be
returned. Letting htop die because of either argument being zero doesn't
make sense.

As a side note: As size_t is unsigned, compiler should be able to optimize
conditional (nmemb > 0 && size > 0) to (nmemb && size). This theorically
shouldn't increase code size too much.
      7d3f67e8
  25. 09 Mar, 2016 2 commits
  27. 08 Mar, 2016 1 commit
  29. 07 Mar, 2016 8 commits
  31. 06 Mar, 2016 3 commits
    • Michael McConville's avatar
      A few more OpenBSD fixes · 4b780a34
      Michael McConville authored 
      Namely:

 o use malloc where an xCalloc slipped in

 o safeguard against an empty arg list - I don't think it's possible,
   but it would be potentially exploitable

 o we need to initialize the arg string to an empty string because we no
 longer use strlcpy(3)

 o annotate a tricky use of strlcpy(3)'s truncation
      4b780a34
    • Michael McConville's avatar
      Misc. OpenBSD tuneup and improvement · b08cb735
      Michael McConville authored 
      Including:

 o set *basenameEnd even in error cases (FreeBSD probably needs this)

 o use kvm_openfiles(3) rather than kvm_open(3) so that we can report
   errors (as with FreeBSD)

 o sanify the process argument list creation by using strlcat(3)

 o drop the pageSizeKb variable and use the PAGE_SIZE_KB macro directly,
   as the page size can't change anyway

 o clean up a few macros, add MINIMUM() and MAXIMUM() (should be
   mirrored to FreeBSD)

 o fix some syntax

 o add some useful comments
      b08cb735
    • Michael McConville's avatar
      Improve error reporting on FreeBSD libkvm call · b886ecc4
      Michael McConville authored 
      This involves switching from kvm_open(3) to kvm_openfiles(3). The only
difference is that the latter has saner error reporting (see the man
page for details). We can now fatally report the error rather than just
calling assert(3).
      b886ecc4