Skip to content

GitLab

Switch branch/tag
  1. 19 May, 2016 2 commits
  3. 16 May, 2016 1 commit
  5. 08 May, 2016 3 commits
    • Explorer09's avatar
      Update INSTALL text from autoconf-2.69 · c0df4047
      Explorer09 authored
      c0df4047
    • Explorer09's avatar
      Reorder configure macros to avoid "missing script" warning. · b71b07f5
      Explorer09 authored 
      3 effects in this commit, with the first being the main one:

1. Fix the "`missing' script is too old or missing" warning. See:
   <https://lists.gnu.org/archive/html/automake/2010-08/msg00108.html>

2. By moving AC_CANONICAL_TARGET down in order, we are now able to
   set the directory for auxiliary scripts. For now it's still './'.
   I added the line "AC_CONFIG_AUX_DIR([.])" to show that the directory
   change is possible.

3. AC_USE_SYSTEM_EXTENSIONS includes checks from AC_PROG_CC, by moving
   the former macro down, we can save size in 'configure' by not
   generating repeated checks.
      b71b07f5
    • Explorer09's avatar
      Replace deprecated autoconf macros. · f0df28a4
      Explorer09 authored 
      AC_HELP_STRING -> AS_HELP_STRING
AC_TRY_COMPILE -> AC_COMPILE_IFELSE([AC_LANG_PROGRAM([...])],...)
AC_CONFIG_HEADER -> AC_CONFIG_HEADERS
AC_PROG_LIBTOOL -> LT_INIT

Note: There might be more deprecated macros that I haven't noticed.
I just wish to avoid painful highlighting from my text editor (gedit)
that complains about them. :)
      f0df28a4
  7. 07 May, 2016 2 commits
  9. 05 May, 2016 3 commits
  11. 04 May, 2016 7 commits
  13. 30 Apr, 2016 2 commits
  15. 28 Apr, 2016 1 commit
  17. 19 Apr, 2016 2 commits
  19. 18 Apr, 2016 2 commits
  21. 31 Mar, 2016 3 commits
  23. 25 Mar, 2016 1 commit
  25. 22 Mar, 2016 1 commit
    • Explorer09's avatar
      BarMeterMode_draw minor code improvement · 7b3c8bc7
      Explorer09 authored 
      Removed a loop that sets the bar[] buffer with spaces and merged that
task to the snprintf() call just below. No need for the barOffset
variable. Display behavior is unchanged.

Size comparision (when compiled on Ubuntu 14.04 64-bit):

    $ size htop.old htop.new
       text    data     bss     dec     hex filename
     137312   15112    3776  156200   26228 htop.old
     137216   15112    3776  156104   261c8 htop.new
      7b3c8bc7
  27. 20 Mar, 2016 1 commit
  29. 19 Mar, 2016 1 commit
    • Explorer09's avatar
      Assert (Platform_meterTypes[0]==&CPUMeter_class) · 328de356
      Explorer09 authored 
      Just assume Platform_meterTypes[0] is always &CPUMeter_class for every
platform. This removes a conditional in AvailableMetersPanel_new().

Also adds some comments about the logic here. Without assuming
Platform_meterTypes[0], the (int i=1) clause in this for loop will not
make sense. (I.e. Why not (int i=0)? )

Also replaced a sprintf() call with safer snprintf() in code further
below.
      328de356
  31. 13 Mar, 2016 1 commit
  33. 11 Mar, 2016 2 commits
    • Explorer09's avatar
      Explicit "maxItems" property of meters · 99fb3070
      Explorer09 authored 
      Two changes in this commit:
- All meters now explicitly specify "maxItems" property, even for just
  1 item. (Exception is "container" CPU meter classes, which use
  CUSTOM_METERMODE.)
- "maxItems" being 0 is now allowed. This will let bar meters and graph
  meters render an empty meter.
      99fb3070
    • Explorer09's avatar
      Revert 5c593fae (xCalloc) · 7d3f67e8
      Explorer09 authored 
      calloc() allows 'nmemb' or 'size' to be zero, in which case NULL may be
returned. Letting htop die because of either argument being zero doesn't
make sense.

As a side note: As size_t is unsigned, compiler should be able to optimize
conditional (nmemb > 0 && size > 0) to (nmemb && size). This theorically
shouldn't increase code size too much.
      7d3f67e8
  35. 09 Mar, 2016 2 commits
  37. 08 Mar, 2016 1 commit
  39. 07 Mar, 2016 2 commits