CONTRIBUTING.md 4.88 KB
Newer Older
1
2
# CONTRIBUTING GUIDELINES

3
Oh-My-Zsh is a community-driven project. Contribution is welcome, encouraged, and appreciated.
ncanceill's avatar
ncanceill committed
4
It is also essential for the development of the project.
5

6
7
First, please take a moment to review our [code of conduct](CODE_OF_CONDUCT.md).

8
These guidelines are an attempt at better addressing the huge amount of pending
ncanceill's avatar
ncanceill committed
9
issues and pull requests. Please read them closely.
10

11
Foremost, be so kind as to [search](#use-the-search-luke). This ensures any contribution
ncanceill's avatar
ncanceill committed
12
you would make is not already covered.
13

ncanceill's avatar
ncanceill committed
14
15
16
17
18
19
20
21
* [Issues](#reporting-issues)
  * [You have a problem](#you-have-a-problem)
  * [You have a suggestion](#you-have-a-suggestion)
* [Pull Requests](#submitting-pull-requests)
  * [Getting started](#getting-started)
  * [You have a solution](#you-have-a-solution)
  * [You have an addition](#you-have-an-addition)
* [Information sources (_aka_ search)](#use-the-search-luke)
22

ncanceill's avatar
ncanceill committed
23
**BONUS:** [Volunteering](#you-have-spare-time-to-volunteer)
24

ncanceill's avatar
ncanceill committed
25
## Reporting Issues
26

ncanceill's avatar
ncanceill committed
27
28
29
30
### You have a problem

Please be so kind as to [search](#use-the-search-luke) for any open issue already covering
your problem.
31

ncanceill's avatar
ncanceill committed
32
If you find one, comment on it so we can know there are more people experiencing it.
33

ncanceill's avatar
ncanceill committed
34
35
If not, look at the [Troubleshooting](https://github.com/robbyrussell/oh-my-zsh/wiki/Troubleshooting)
page for instructions on how to gather data to better debug your problem.
36

ncanceill's avatar
ncanceill committed
37
38
Then, you can go ahead and create an issue with as much detail as you can provide.
It should include the data gathered as indicated above, along with:
39

ncanceill's avatar
ncanceill committed
40
41
42
1. How to reproduce the problem
2. What the correct behavior should be
3. What the actual behavior is
43

ncanceill's avatar
ncanceill committed
44
45
Please copy to anyone relevant (_eg_ plugin maintainers) by mentioning their GitHub handle
(starting with `@`) in your message.
46

ncanceill's avatar
ncanceill committed
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
We will do our very best to help you.

### You have a suggestion

Please be so kind as to [search](#use-the-search-luke) for any open issue already covering
your suggestion.

If you find one, comment on it so we can know there are more people supporting it.

If not, you can go ahead and create an issue. Please copy to anyone relevant (_eg_ plugin
maintainers) by mentioning their GitHub handle (starting with `@`) in your message.

## Submitting Pull Requests

### Getting started
62

ncanceill's avatar
ncanceill committed
63
64
65
You should be familiar with the basics of
[contributing on GitHub](https://help.github.com/articles/using-pull-requests) and have a fork
[properly set up](https://github.com/robbyrussell/oh-my-zsh/wiki/Contribution-Technical-Practices).
66

ncanceill's avatar
ncanceill committed
67
You MUST always create PRs with _a dedicated branch_ based on the latest upstream tree.
68

ncanceill's avatar
ncanceill committed
69
70
71
72
If you create your own PR, please make sure you do it right. Also be so kind as to reference
any issue that would be solved in the PR description body,
[for instance](https://help.github.com/articles/closing-issues-via-commit-messages/)
_"Fixes #XXXX"_ for issue number XXXX.
73

ncanceill's avatar
ncanceill committed
74
### You have a solution
75

ncanceill's avatar
ncanceill committed
76
Please be so kind as to [search](#use-the-search-luke) for any open issue already covering
ncanceill's avatar
ncanceill committed
77
your [problem](#you-have-a-problem), and any pending/merged/rejected PR covering your solution.
78
79
80

If the solution is already reported, try it out and +1 the pull request if the
solution works ok. On the other hand, if you think your solution is better, post
ncanceill's avatar
ncanceill committed
81
it with a reference to the other one so we can have both solutions to compare.
82

83
If not, then go ahead and submit a PR. Please copy to anyone relevant (e.g. plugin
ncanceill's avatar
ncanceill committed
84
maintainers) by mentioning their GitHub handle (starting with `@`) in your message.
85

ncanceill's avatar
ncanceill committed
86
87
88
89
90
### You have an addition

Please [do not](https://github.com/robbyrussell/oh-my-zsh/wiki/Themes#dont-send-us-your-theme-for-now)
send themes for now.

91
92
Please be so kind as to [search](#use-the-search-luke) for any pending, merged or rejected Pull Requests
covering or related to what you want to add.
ncanceill's avatar
ncanceill committed
93
94
95
96
97
98

If you find one, try it out and work with the author on a common solution.

If not, then go ahead and submit a PR. Please copy to anyone relevant (_eg_ plugin
maintainers) by mentioning their GitHub handle (starting with `@`) in your message.

ncanceill's avatar
ncanceill committed
99
100
For any extensive change, _eg_ a new plugin, you will have to find testers to +1 your PR.

ncanceill's avatar
ncanceill committed
101
102
103
104
----

## Use the Search, Luke

105
_May the Force (of past experiences) be with you_
ncanceill's avatar
ncanceill committed
106
107
108
109
110
111
112
113

GitHub offers [many search features](https://help.github.com/articles/searching-github/)
to help you check whether a similar contribution to yours already exists. Please search
before making any contribution, it avoids duplicates and eases maintenance. Trust me,
that works 90% of the time.

You can also take a look at the [FAQ](https://github.com/robbyrussell/oh-my-zsh/wiki/FAQ)
to be sure your contribution has not already come up.
114

ncanceill's avatar
ncanceill committed
115
116
If all fails, your thing has probably not been reported yet, so you can go ahead
and [create an issue](#reporting-issues) or [submit a PR](#submitting-pull-requests).
117
118
119

----

ncanceill's avatar
ncanceill committed
120
### You have spare time to volunteer
121
122
123
124
125

Very nice!! :)

Please have a look at the [Volunteer](https://github.com/robbyrussell/oh-my-zsh/wiki/Volunteers)
page for instructions on where to start and more.